tested and added root org support #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds and tests support for retrieving and integrating root organization data using the LUMS API. Key changes include the introduction of a new rootOrg package with an HTTP client, poller, and configuration; updates to the evaluation logic in the local evaluation package; and minor import and naming adjustments.
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/rootOrg/rootOrg.go | Introduces LUMS API client for fetching root organization |
| pkg/rootOrg/poller.go | Implements a poller for periodically triggering requests |
| pkg/rootOrg/config.go | Adds configuration settings for root organization support |
| pkg/rootOrg/client.go | Provides a client for root org integration and evaluation |
| pkg/experiment/local/client.go | Minor import reordering and update in client usage |
| model/lums.go | Defines models for LUMS API responses |
| localEvaluation/localEvaluation.go | Updates initialization and evaluation logic to include root org support |
Files not reviewed (1)
- go.mod: Language not supported
amathur-LT
requested changes
May 14, 2025
amathur-LT
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.