Skip to content

Commit 81e852d

Browse files
authored
Merge pull request #314 from LambdaTest/dev
Release 14 march
2 parents f9d9d2c + 4d61af0 commit 81e852d

File tree

6 files changed

+26
-4
lines changed

6 files changed

+26
-4
lines changed

commands/utils/batch/batch_runner.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ async function run(lt_config, batches, env) {
140140
lt_config.run_settings.reject_unauthorized
141141
)
142142
.then(function (session_id) {
143-
if (lt_config["run_settings"]["retry_failed"] == false ) {
143+
if (!lt_config["run_settings"]["retry_failed"]) {
144144
delete_archive(project_file);
145145
}
146146
delete_archive(file_obj["name"]);

commands/utils/set_args.js

+10
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,16 @@ function sync_args_from_cmd(args) {
373373
lt_config["run_settings"]["network_http2"] = false;
374374
}
375375

376+
if ("useNode18" in args) {
377+
if (args["useNode18"] == "true") {
378+
lt_config.run_settings.useNode18 = true;
379+
} else {
380+
lt_config.run_settings.useNode18 = false;
381+
}
382+
} else if (lt_config["run_settings"]["useNode18"] && !lt_config["run_settings"]["useNode18"]) {
383+
lt_config["run_settings"]["useNode18"] = false;
384+
}
385+
376386
if ("network_ws" in args) {
377387
if (args["network_ws"] == "true") {
378388
lt_config.run_settings.network_ws = true;

commands/utils/validate.js

+7
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,13 @@ module.exports = validate_config = function (lt_config, validation_configs) {
198198
}
199199
}
200200

201+
//validate if network_http2 field contains expected value
202+
if ("useNode18" in lt_config["run_settings"]) {
203+
if (![true, false].includes(lt_config["run_settings"]["useNode18"])) {
204+
reject("Error!! boolean value is expected in useNode18 key");
205+
}
206+
}
207+
201208
if (
202209
"downloads" in lt_config["run_settings"] &&
203210
lt_config["run_settings"]["downloads"] != ""

index.js

+5
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,11 @@ const argv = require("yargs")
236236
describe: "Bypass web socket calls for Network logs",
237237
type: "bool",
238238
})
239+
.option("node18", {
240+
alias: "useNode18",
241+
describe: "Use node version 18 for cypress",
242+
type: "bool",
243+
})
239244
.option("net_sse", {
240245
alias: "network_sse",
241246
describe: "Bypass sse events calls for Network logs",

package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "lambdatest-cypress-cli",
3-
"version": "3.0.28",
3+
"version": "3.0.29",
44
"description": "The lambdatest-cypress-cli is LambdaTest's command-line interface (CLI) aimed to help you run your Cypress tests on LambdaTest platform.",
55
"homepage": "https://github.com/LambdaTest/lambdatest-cypress-cli",
66
"author": "LambdaTest <[email protected]>",

0 commit comments

Comments
 (0)