Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 16, 2025

The Romanian language files were missing multiple translation strings that are present in the English versions, causing inconsistent localization coverage. This was particularly noticeable for newer features like bulk operations, export functionality, and field selections.

Issues Fixed

  • Missing translations: Added 47 missing keys in crud.php and 28 missing keys in base.php
  • Key ordering: Reordered all keys to match the exact structure of English files
  • Feature parity: Romanian now has 100% translation coverage matching English

Key Changes

CRUD translations (ro/crud.php)

  • Clone operations: clone, clone_success, clone_failure
  • Bulk actions: Complete bulk selection, deletion, and cloning messages
  • Export functionality: All export format options and column visibility
  • Date filters: today, yesterday, last_7_days, last_30_days, etc.
  • Field operations: select_entry, select_entries, unselect_all, file selections
  • Advanced features: Inline operations, pivot validations, quick buttons, Google Maps integration

Base translations (ro/base.php)

  • Authentication: username, email, notification types (warning, notice)
  • Error handling: Complete error page system with all HTTP status codes (400, 401, 403, 404, etc.)
  • Password reset: Enhanced workflow with step, confirm_email, choose_new_password
  • Email verification: Complete verification system with resend functionality

Before/After

  • CRUD: 82 → 129 keys (47 added)
  • Base: 49 → 77 keys (28 added)
  • Total: 75 new Romanian translations added

All translations are contextually appropriate and follow Romanian language conventions. The key ordering now exactly matches the English files for easier maintenance.

Fixes #5866.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/GrahamCampbell/Result-Type/zipball/3ba905c11371512af9d9bdd27d99b782216b6945
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/7O3mAm /usr/bin/composer install --no-dev (http block)
  • https://api.github.com/repos/schmittjoh/php-option/zipball/638a154f8d4ee6a5cfa96d6a34dfbe0cffa9566d
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/7O3mAm /usr/bin/composer install --no-dev (http block)
  • https://api.github.com/repos/symfony/css-selector/zipball/601a5ce9aaad7bf10797e3663faefce9e26c24e2
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/7O3mAm /usr/bin/composer install --no-dev (http block)
  • https://api.github.com/repos/symfony/polyfill-php80/zipball/0cc9dd0f17f61d8131e7df6b84bd344899fe2608
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/7O3mAm /usr/bin/composer install --no-dev (http block)
  • https://api.github.com/repos/vlucas/phpdotenv/zipball/24ac4c74f91ee2c193fa1aaa5c249cb0822809af
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/7O3mAm /usr/bin/composer install --no-dev (http block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copy link
Contributor Author

Copilot AI commented Sep 16, 2025

@tabacitu 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Copilot AI changed the title [WIP] [Bug] Romanian lang files have some missing lang strings Fix Romanian language files missing translations and key ordering Sep 16, 2025
Copilot AI requested a review from tabacitu September 16, 2025 10:25
Copilot finished work on behalf of tabacitu September 16, 2025 10:25
@tabacitu tabacitu marked this pull request as ready for review October 10, 2025 15:17
@tabacitu tabacitu merged commit 9d6c2ba into main Oct 10, 2025
15 checks passed
@tabacitu tabacitu deleted the copilot/fix-5866 branch October 10, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Romanian lang files have some missing lang strings

2 participants