Help with obtaining firmware config (select params)

I am working on another frontend where I intend using lw.comms-server as well.

In this frontend, I want to obtain the Smoothie config file and then parse it.
In my old project CoPrint, i used (which should not be used) MSD to access the Config file from SD over nodejs-fs: See https://github.com/openhardwarecoza/CoPrint/blob/9b602c256c2fab10158bd9033d4c14ab33bbdccc/server-smoothie.js#L192-L205

Of course that being the wrong way, i am now trying to do the same over Serial. using Smoothie command 'cat /sd/config' works beautifully, but instead of getting the file as a whole, i am getting each line as a seperate event. This makes parsing it much harder

I almost have to do

if ( data.indexOf('alpha_steps_per_mm') === 0 || data.indexOf('beta_steps_per_mm') === 0 || data.indexOf('gamma_steps_per_mm') === 0 || data.indexOf('x_axis_max_speed') === 0 || data.indexOf('y_axis_max_speed') === 0 || data.indexOf('z_axis_max_speed') === 0 || data.indexOf('acceleration') === 0 || data.indexOf('z_acceleration') === 0 || data.indexOf('endstops_enable') === 0) {...}

for each value i want to work with... yikes.

@cprezzi any ideas how I can go about reading the file using 'cat' and get it in ONE event?

(Goal: In the end i assemble it into a smoothieParams object:

with the eventual goal of then sending set-config commands back to update the popular settings for noobs

For what its further worth, I get the output of '$$" from Grbl in seperate events too, but that very useful "$number..." is easy to get with

 } else if (data.indexOf('$') === 0) {
           grblSettings(data)
       }

[cprezzi]

You get it line by line, because lw.comm-server get linebreaks from smoothieware. I think cat is the wrong way to do it, because there are no start or end of file marks.

Instead, you could read value by value with config-get and change a param with config-set.

[cprezzi]

This should be easy to implement as you anyways have a structured array.

Thanks!

I think cat is the wrong way to do it, vs ...

[cprezzi]

Hm. didn't see that. There is no such hint in smoothiehappy api (https://lautr3k.github.io/smoothie-happy/docs/function/index.html#static-function-cmd_config_get) and I think @lautr3k is also using it for his new configuration dialog.

Isnt smoothiehappy still just ethernet?

…

On Aug 4, 2017 4:06 PM, "Claudio Prezzi" ***@***.***> wrote: Hm. didn't see that. There is no such hint in smoothiehappy api ( https://lautr3k.github.io/smoothie-happy/docs/function/ index.html#static-function-cmd_config_get) and I think @lautr3k <https://github.com/lautr3k> is also using it for his new configuration dialog. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHVr26skdMFUyxnxTu7ZrHx5sT0w93Hgks5sUyV_gaJpZM4Os7tQ> .

[cprezzi]

Yes, I think so.

[cprezzi]

In the smoothie code I found that if the limit param of cat is -d we should get a eof at the end of the file :)
https://github.com/Smoothieware/Smoothieware/blob/edge/src/modules/utils/simpleshell/SimpleShell.cpp#L380

But we still need to make sure the queue is empty and all timers are off before sending the cat command.

[cprezzi]

What do you think about lw.comm-server providing a command "getFirmwareConfig" which delivers a complete json object with all config parameters?

The app could then dynamically create a form with all settings. It should also be possible to embed all field options in the json object. Something like:

{ 
    laser_mode: 1,
    laser_mode_options: [
        1: On, 
        0: Off
    ]
}

This way, the app (frontend) can stay firmware independant.

I would love that. Didnt want to intrude though as that looks like a lot of work. Would be especially cool if its cross-firmware. Ie same param name whether its grbl or smoothie. On Aug 4, 2017 4:37 PM, "Claudio Prezzi" <notifications@github.com> wrote: What do you think about lw.comm-server providing a command "getFirmwareConfig" which delivers a complete json object with all config parameters? The app could then dynamically create a form with all settings. It should also be possible to embed all field options in the json object. Something like: { laser_mode: 1, laser_mode_options: [ 1: On, 0: Off ] } — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHVr2-Ed6ID6T37ks6Ut6QcMP3Yw3goGks5sUyyXgaJpZM4Os7tQ> .

[cprezzi]

I think it's hard to find parameter names that match every firmware (because they are so different), but that wouldn't be needed if the frontend form is created dynamically with the names & options in the json object.

[cprezzi]

I know this could be less flexible for a frontend (for adding help or designing super nice tabbed forms).