Skip to content

Varstore should be replace by a HashMap #1008

@freemanliu

Description

@freemanliu

Varstore has so many problems. It does not respect no_grad_guard. It only create float dtype. It include shallow copy of the tesnors. There is not much point of such struct. To keep track of all the weights, a hashmap is perfect. But the nn module are hardcoded to depend on it. Any reason it is this way?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions