make skipping compile time

LaurenzV · Aug 31, 2024 · 8466e9f · 8466e9f
1 parent 64b385d
commit 8466e9f
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 11 deletions.
diff --git a/krilla-macros/src/lib.rs b/krilla-macros/src/lib.rs
@@ -24,6 +24,8 @@ enum SnapshotMode {
     Document,
 }
 
+const SKIP_SNAPSHOT: Option<&str> = option_env!("SKIP_SNAPSHOT");
+
 #[proc_macro_attribute]
 pub fn snapshot(attr: TokenStream, item: TokenStream) -> TokenStream {
     let attrs = parse_macro_input!(attr as AttributeInput);
@@ -55,13 +57,9 @@ pub fn snapshot(attr: TokenStream, item: TokenStream) -> TokenStream {
 
     let common = quote! {
         use crate::serialize::{SerializeSettings, SerializerContext};
-        use crate::tests::{SKIP_SNAPSHOT, check_snapshot};
+        use crate::tests::check_snapshot;
         use crate::document::{Document, PageSettings};
         use crate::Size;
-
-        if SKIP_SNAPSHOT.is_some() {
-            return;
-        }
     };
 
     let fn_content = match mode {
@@ -97,9 +95,16 @@ pub fn snapshot(attr: TokenStream, item: TokenStream) -> TokenStream {
         }
     };
 
+    let ignore_snippet = if SKIP_SNAPSHOT.is_some() {
+        quote! { #[ignore] }
+    }   else {
+        quote! {}
+    };
+
     let expanded = quote! {
         #input_fn
 
+        #ignore_snippet
         #[test]
         fn #fn_name() {
             #fn_content
@@ -127,11 +132,14 @@ impl RendererExt for Renderer {
     }
 }
 
+const SKIP_VISREG: Option<&str> = option_env!("SKIP_VISREG");
+
 #[proc_macro_attribute]
 pub fn visreg(attr: TokenStream, item: TokenStream) -> TokenStream {
     let attrs = parse_macro_input!(attr as AttributeInput);
     let mut serialize_settings = format_ident!("default");
 
+
     let mut pdfium = false;
     let mut mupdf = false;
     let mut pdfbox = false;
@@ -224,6 +232,12 @@ pub fn visreg(attr: TokenStream, item: TokenStream) -> TokenStream {
         let name = format_ident!("{}_visreg_{}", fn_name.to_string(), renderer.name());
         let renderer_ident = renderer.as_token_stream();
 
+        let ignore_snippet = if SKIP_VISREG.is_some() {
+            quote! { #[ignore] }
+        }   else {
+            quote! {}
+        };
+
         let quartz_snippet = if renderer == Renderer::Quartz {
             quote! { #[cfg(target_os = "macos")] }
         } else {
@@ -232,19 +246,17 @@ pub fn visreg(attr: TokenStream, item: TokenStream) -> TokenStream {
 
         if include {
             quote! {
+                #ignore_snippet
                 #quartz_snippet
                 #[test]
                 fn #name() {
-                    use crate::tests::{render_document, check_render, SKIP_VISREG};
+                    use crate::tests::{render_document, check_render};
                     use crate::Size;
                     use crate::document::{Document, PageSettings};
                     use crate::serialize::SerializeSettings;
                     use sitro::Renderer;
                     let renderer = #renderer_ident;
 
-                    if SKIP_VISREG.is_some() {
-                        return;
-                    }
                     #fn_body
                 }
             }

diff --git a/src/tests/mod.rs b/src/tests/mod.rs
@@ -25,8 +25,6 @@ mod visreg;
 
 const REPLACE: Option<&str> = option_env!("REPLACE");
 const STORE: Option<&str> = option_env!("STORE");
-pub const SKIP_VISREG: Option<&str> = option_env!("SKIP_VISREG");
-pub const SKIP_SNAPSHOT: Option<&str> = option_env!("SKIP_SNAPSHOT");
 
 static ASSETS_PATH: LazyLock<PathBuf> =
     LazyLock::new(|| PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("assets"));