Only set outline if it's not empty

LaurenzV · Dec 17, 2024 · e1a36bf · e1a36bf
1 parent 8bbff37
commit e1a36bf
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/crates/krilla/src/object/outline.rs b/crates/krilla/src/object/outline.rs
@@ -33,6 +33,12 @@ pub struct Outline {
     children: Vec<OutlineNode>,
 }
 
+impl Outline {
+    pub(crate) fn is_empty(&self) -> bool {
+        self.children.is_empty()
+    }
+}
+
 impl Default for Outline {
     fn default() -> Self {
         Self::new()

diff --git a/crates/krilla/src/serialize.rs b/crates/krilla/src/serialize.rs
@@ -247,7 +247,16 @@ impl SerializeContext {
     }
 
     pub(crate) fn set_outline(&mut self, outline: Outline) {
-        self.global_objects.outline = MaybeTaken::new(Some(outline));
+        // Only set it if it's not empty or if the current validator requires an
+        // outline.
+        if !outline.is_empty()
+            || self
+                .serialize_settings
+                .validator
+                .prohibits(&ValidationError::MissingDocumentOutline)
+        {
+            self.global_objects.outline = MaybeTaken::new(Some(outline));
+        }
     }
 
     pub(crate) fn set_metadata(&mut self, metadata: Metadata) {