fix feedbacks of the team

Author: Lawndlwd

data/config.json

@@ -1,10 +1,10 @@
 {
   "port": 3000,
-  "appName": "Scaleway",
-  "appSubtitle": "hellllllooooooo",
+  "appName": "",
+  "appSubtitle": "",
   "jwtSecret": "change-this-secret-in-production",
   "questionTimeSec": 20,
-  "defaultBaseScore": 300,
+  "defaultBaseScore": 500,
   "speedBonusMax": 200,
   "speedBonusMin": 10,
   "maxPlayersPerSession": 50,

docker-compose.yml

@@ -11,24 +11,22 @@ services:
       - JWT_SECRET=${JWT_SECRET:-change-this-secret-in-production}
     volumes:
       - ./data:/data
-      # Avatars live on the host — drop image files here and they appear in the picker
-      - ./avatars:/data/avatars
 
-  caddy:
-    image: caddy:latest
-    restart: unless-stopped
-    depends_on:
-      - app
-    ports:
-      - "80:80"
-      - "443:443"
-    environment:
-      - DOMAIN=${DOMAIN:-}
-    volumes:
-      - ./Caddyfile:/etc/caddy/Caddyfile
-      - ./site:/srv
-      - caddy_data:/data
-      - caddy_config:/config
+  # caddy:
+  #   image: caddy:latest
+  #   restart: unless-stopped
+  #   depends_on:
+  #     - app
+  #   ports:
+  #     - "80:80"
+  #     - "443:443"
+  #   environment:
+  #     - DOMAIN=${DOMAIN:-}
+  #   volumes:
+  #     - ./Caddyfile:/etc/caddy/Caddyfile
+  #     - ./site:/srv
+  #     - caddy_data:/data
+  #     - caddy_config:/config
 
 volumes:
   caddy_data:

server/src/config.ts

@@ -6,28 +6,6 @@ import type { AppConfig } from './types';
 const dataDir = process.env.DATA_DIR || path.join(process.cwd(), '..', 'data');
 const configPath = path.join(dataDir, 'config.json');
 
-// ── Migration: move config from old locations into the unified data dir ──────
-const OLD_CONFIG_PATHS = [
-  path.join(process.cwd(), 'data', 'config.json'),   // server/data/config.json
-  path.join(process.cwd(), '..', 'config.json'),      // <root>/config.json
-];
-
-function migrateConfig(): void {
-  if (fs.existsSync(configPath)) return; // already in the right place
-  fs.mkdirSync(dataDir, { recursive: true });
-
-  for (const oldPath of OLD_CONFIG_PATHS) {
-    if (fs.existsSync(oldPath)) {
-      fs.copyFileSync(oldPath, configPath);
-      fs.unlinkSync(oldPath);
-      console.log(`[migrate] Moved config from ${oldPath} → ${configPath}`);
-      return;
-    }
-  }
-}
-
-migrateConfig();
-
 // Defaults ensure any field added to the codebase after a deployment
 // still has a sane value even if the persisted config.json pre-dates it.
 const DEFAULTS: AppConfig = {
@@ -55,23 +33,9 @@ export function loadConfig(): AppConfig {
   }
 
   const raw = fs.readFileSync(configPath, 'utf-8');
-  const saved = JSON.parse(raw) as Record<string, unknown>;
-
-  // Strip legacy credential fields — auth now lives in the database
-  let dirty = false;
-  for (const key of ['adminUsername', 'adminPassword', 'lobbyTimeoutMin']) {
-    if (key in saved) {
-      delete saved[key];
-      dirty = true;
-    }
-  }
-  if (dirty) {
-    fs.writeFileSync(configPath, JSON.stringify(saved, null, 2), 'utf-8');
-    console.log('[migrate] Removed legacy credential fields from config.json');
-  }
-
+  const saved = JSON.parse(raw) as Partial<AppConfig>;
   // Merge: saved values win; any key missing from the file falls back to DEFAULTS
-  const cfg = { ...DEFAULTS, ...(saved as Partial<AppConfig>) };
+  const cfg = { ...DEFAULTS, ...saved };
   // Env vars always win over file — useful for Docker deployments
   if (process.env.JWT_SECRET) cfg.jwtSecret = process.env.JWT_SECRET;
   return cfg;

server/src/db.ts

@@ -7,34 +7,6 @@ import sqlite3 from 'sqlite3';
 const dataDir = process.env.DATA_DIR || path.join(process.cwd(), '..', 'data');
 const DB_PATH = path.join(dataDir, 'quizz.db');
 
-// ── Migration: move DB from old locations into the unified data dir ──────────
-const OLD_DB_PATHS = [
-  path.join(process.cwd(), '..', 'quizz.db'),  // <root>/quizz.db
-];
-
-function migrateDb(): void {
-  if (fs.existsSync(DB_PATH)) return; // already in the right place
-  fs.mkdirSync(dataDir, { recursive: true });
-
-  for (const oldPath of OLD_DB_PATHS) {
-    if (fs.existsSync(oldPath)) {
-      // Move the main DB file + WAL/SHM sidecar files
-      for (const suffix of ['', '-wal', '-shm']) {
-        const src = oldPath + suffix;
-        const dst = DB_PATH + suffix;
-        if (fs.existsSync(src)) {
-          fs.copyFileSync(src, dst);
-          fs.unlinkSync(src);
-        }
-      }
-      console.log(`[migrate] Moved database from ${oldPath} → ${DB_PATH}`);
-      return;
-    }
-  }
-}
-
-migrateDb();
-
 export let db: Database;
 
 export async function initDb(): Promise<void> {