feat: move addresses to constructor (#397)

Author: gpsanant

src/interfaces/IInstantSlasher.sol

@@ -9,12 +9,6 @@ import {ISlasher} from "./ISlasher.sol";
 /// @notice A slashing contract that immediately executes slashing requests without any delay or veto period
 /// @dev Extends base interfaces to provide access controlled slashing functionality
 interface IInstantSlasher is ISlasher {
-    /// @notice Initializes the contract with a slasher address
-    /// @param _slasher Address authorized to create and fulfill slashing requests
-    function initialize(
-        address _slasher
-    ) external;
-
     /// @notice Immediately executes a slashing request
     /// @param _slashingParams Parameters defining the slashing request including operator and amount
     /// @dev Can only be called by the authorized slasher

src/interfaces/IVetoableSlasher.sol

@@ -63,11 +63,6 @@ interface IVetoableSlasher is
     /// @notice Address of the committee that has veto power over slashing requests
     function vetoCommittee() external view returns (address);
 
-    /// @notice Initializes the contract with a veto committee and slasher address
-    /// @param _vetoCommittee Address of the committee that can veto slashing requests
-    /// @param _slasher Address authorized to create and fulfill slashing requests
-    function initialize(address _vetoCommittee, address _slasher) external;
-
     /// @notice Queues a new slashing request
     /// @param params Parameters defining the slashing request including operator and amount
     /// @dev Can only be called by the authorized slasher

src/slashers/InstantSlasher.sol

@@ -16,14 +16,7 @@ contract InstantSlasher is IInstantSlasher, SlasherBase {
         IAllocationManager _allocationManager,
         ISlashingRegistryCoordinator _slashingRegistryCoordinator,
         address _slasher
-    ) SlasherBase(_allocationManager, _slashingRegistryCoordinator) {}
-
-    /// @inheritdoc IInstantSlasher
-    function initialize(
-        address _slasher
-    ) external override initializer {
-        __SlasherBase_init(_slasher);
-    }
+    ) SlasherBase(_allocationManager, _slashingRegistryCoordinator, _slasher) {}
 
     /// @inheritdoc IInstantSlasher
     function fulfillSlashingRequest(

src/slashers/VetoableSlasher.sol

@@ -16,7 +16,7 @@ contract VetoableSlasher is IVetoableSlasher, SlasherBase {
     uint32 public immutable override vetoWindowBlocks;
 
     /// @inheritdoc IVetoableSlasher
-    address public override vetoCommittee;
+    address public immutable override vetoCommittee;
 
     /// @notice Mapping of request IDs to their corresponding slashing request details
     mapping(uint256 => IVetoableSlasherTypes.VetoableSlashingRequest) public slashingRequests;
@@ -30,17 +30,11 @@ contract VetoableSlasher is IVetoableSlasher, SlasherBase {
     constructor(
         IAllocationManager _allocationManager,
         ISlashingRegistryCoordinator _slashingRegistryCoordinator,
+        address _slasher,
+        address _vetoCommittee,
         uint32 _vetoWindowBlocks
-    ) SlasherBase(_allocationManager, _slashingRegistryCoordinator) {
+    ) SlasherBase(_allocationManager, _slashingRegistryCoordinator, _slasher) {
         vetoWindowBlocks = _vetoWindowBlocks;
-    }
-
-    /// @inheritdoc IVetoableSlasher
-    function initialize(
-        address _vetoCommittee,
-        address _slasher
-    ) external virtual override initializer {
-        __SlasherBase_init(_slasher);
         vetoCommittee = _vetoCommittee;
     }
 

src/slashers/base/SlasherBase.sol

@@ -1,7 +1,6 @@
 // SPDX-License-Identifier: BUSL-1.1
 pragma solidity ^0.8.27;
 
-import {Initializable} from "@openzeppelin-upgrades/contracts/proxy/utils/Initializable.sol";
 import {SlasherStorage, ISlashingRegistryCoordinator} from "./SlasherStorage.sol";
 import {
     IAllocationManagerTypes,
@@ -12,7 +11,7 @@ import {IStrategy} from "eigenlayer-contracts/src/contracts/interfaces/IStrategy
 /// @title SlasherBase
 /// @notice Base contract for implementing slashing functionality in EigenLayer middleware
 /// @dev Provides core slashing functionality and interfaces with EigenLayer's AllocationManager
-abstract contract SlasherBase is Initializable, SlasherStorage {
+abstract contract SlasherBase is SlasherStorage {
     /// @notice Ensures only the authorized slasher can call certain functions
     modifier onlySlasher() {
         _checkSlasher(msg.sender);
@@ -22,20 +21,12 @@ abstract contract SlasherBase is Initializable, SlasherStorage {
     /// @notice Constructs the base slasher contract
     /// @param _allocationManager The EigenLayer allocation manager contract
     /// @param _registryCoordinator The registry coordinator for this middleware
+    /// @param _slasher The address of the slasher
     constructor(
         IAllocationManager _allocationManager,
-        ISlashingRegistryCoordinator _registryCoordinator
-    ) SlasherStorage(_allocationManager, _registryCoordinator) {
-        _disableInitializers();
-    }
-
-    /// @notice Initializes the slasher contract with authorized slasher address
-    /// @param _slasher Address authorized to create and fulfill slashing requests
-    function __SlasherBase_init(
+        ISlashingRegistryCoordinator _registryCoordinator,
         address _slasher
-    ) internal onlyInitializing {
-        slasher = _slasher;
-    }
+    ) SlasherStorage(_allocationManager, _registryCoordinator, _slasher) {}
 
     /// @notice Internal function to execute a slashing request
     /// @param _requestId The ID of the slashing request to fulfill

src/slashers/base/SlasherStorage.sol

@@ -20,17 +20,19 @@ abstract contract SlasherStorage is ISlasher {
     IAllocationManager public immutable allocationManager;
     /// @notice the SlashingRegistryCoordinator for this AVS
     ISlashingRegistryCoordinator public immutable slashingRegistryCoordinator;
-
-    address public slasher;
+    /// @notice the address of the slasher
+    address public immutable slasher;
 
     uint256 public nextRequestId;
 
     constructor(
         IAllocationManager _allocationManager,
-        ISlashingRegistryCoordinator _slashingRegistryCoordinator
+        ISlashingRegistryCoordinator _slashingRegistryCoordinator,
+        address _slasher
     ) {
         allocationManager = _allocationManager;
         slashingRegistryCoordinator = _slashingRegistryCoordinator;
+        slasher = _slasher;
     }
 
     uint256[48] private __gap;

test/unit/InstantSlasher.t.sol

@@ -250,8 +250,6 @@ contract InstantSlasherTest is Test {
         );
         vm.stopPrank();
 
-        instantSlasher.initialize(slasher);
-
         vm.startPrank(serviceManager);
         PermissionController(coreDeployment.permissionController).setAppointee(
             address(serviceManager),

test/unit/VetoableSlasher.t.sol

@@ -239,6 +239,8 @@ contract VetoableSlasherTest is Test {
         vetoableSlasherImplementation = new VetoableSlasher(
             IAllocationManager(coreDeployment.allocationManager),
             ISlashingRegistryCoordinator(slashingRegistryCoordinator),
+            slasher,
+            vetoCommittee,
             vetoWindowBlocks
         );
 
@@ -255,8 +257,6 @@ contract VetoableSlasherTest is Test {
         );
         vm.stopPrank();
 
-        vetoableSlasher.initialize(vetoCommittee, slasher);
-
         vm.startPrank(serviceManager);
         PermissionController(coreDeployment.permissionController).setAppointee(
             address(serviceManager),