Skip to content

Commit 9a1d70e

Browse files
committed
Pin the provider release that makes the name a name
This branch removed the second field and the warning about it on the argument that the WebAuthn user handle is no longer derived from what somebody types. That is only true from Le-Space/orbitdb-identity-provider-webauthn-did#46, which is merged upstream but was in no release when this was opened — so the PR said it must not merge until one existed. One does: 0.5.1 on npm. Its `createCredential` builds the handle as const userHandle = crypto.getRandomValues(new Uint8Array(64)) and passes it as `user.id`, which is exactly the change this depends on. It is easy to miss, and that is worth recording: 0.5.1 was published to npm without a GitHub release, so the release list still ends at v0.5.0 from a day before the merge. Looking there says the blocker is still there. Both the override and the dependency range move together; leaving the range at ^0.5.0 while the override said 0.5.1 would be two sources of truth for one decision. Refs #85
1 parent 0617d76 commit 9a1d70e

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
},
5555
"pnpm": {
5656
"overrides": {
57-
"@le-space/orbitdb-identity-provider-webauthn-did": "0.5.0"
57+
"@le-space/orbitdb-identity-provider-webauthn-did": "0.5.1"
5858
},
5959
"onlyBuiltDependencies": [
6060
"esbuild"
@@ -65,7 +65,7 @@
6565
"@helia/libp2p": "^1.0.6",
6666
"@ipld/dag-cbor": "^10.0.1",
6767
"@le-space/libp2p-webrtc-qr": "^0.8.0",
68-
"@le-space/orbitdb-identity-provider-webauthn-did": "^0.5.0",
68+
"@le-space/orbitdb-identity-provider-webauthn-did": "^0.5.1",
6969
"@libp2p/crypto": "^5.1.21",
7070
"@libp2p/gossipsub": "^16.1.0",
7171
"@libp2p/identify": "^4.1.10",

pnpm-lock.yaml

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)