Commit 9a1d70e
committed
Pin the provider release that makes the name a name
This branch removed the second field and the warning about it on the
argument that the WebAuthn user handle is no longer derived from what
somebody types. That is only true from
Le-Space/orbitdb-identity-provider-webauthn-did#46, which is merged
upstream but was in no release when this was opened — so the PR said it
must not merge until one existed.
One does: 0.5.1 on npm. Its `createCredential` builds the handle as
const userHandle = crypto.getRandomValues(new Uint8Array(64))
and passes it as `user.id`, which is exactly the change this depends on.
It is easy to miss, and that is worth recording: 0.5.1 was published to
npm without a GitHub release, so the release list still ends at v0.5.0
from a day before the merge. Looking there says the blocker is still
there.
Both the override and the dependency range move together; leaving the
range at ^0.5.0 while the override said 0.5.1 would be two sources of
truth for one decision.
Refs #851 parent 0617d76 commit 9a1d70e
2 files changed
Lines changed: 8 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments