feat: fix bug in IsPreviewMode()

Author: hsluoyz

controllers/provider.go

@@ -65,7 +65,7 @@ func (c *ApiController) GetProviders() {
 		providers = object.GetMaskedProviders(providers, true, user)
 		c.ResponseOk(providers)
 	} else {
-		if !c.IsPreviewMode() && !c.RequireAdmin() {
+		if !c.RequireAdmin() {
 			return
 		}
 		limit := util.ParseInt(limit)

controllers/store.go

@@ -46,9 +46,10 @@ func (c *ApiController) GetGlobalStores() {
 
 		c.ResponseOk(stores)
 	} else {
-		if !c.IsPreviewMode() && !c.RequireAdmin() {
+		if !c.RequireAdmin() {
 			return
 		}
+
 		limit := util.ParseInt(limit)
 		count, err := object.GetStoreCount(field, value)
 		if err != nil {

controllers/util.go

@@ -113,6 +113,11 @@ func (c *ApiController) CheckSignedIn() (string, bool) {
 }
 
 func (c *ApiController) RequireAdmin() bool {
+	disablePreviewMode, _ := beego.AppConfig.Bool("disablePreviewMode")
+	if !disablePreviewMode {
+		return true
+	}
+
 	if !c.IsAdmin() {
 		c.ResponseError("this operation requires admin privilege")
 		return false
@@ -131,15 +136,6 @@ func (c *ApiController) IsAdmin() bool {
 	return res
 }
 
-func (c *ApiController) IsPreviewMode() bool {
-	disablePreviewMode, _ := beego.AppConfig.Bool("disablePreviewMode")
-	if disablePreviewMode {
-		c.ResponseError("this operation requires admin privilege")
-		return false
-	}
-	return true
-}
-
 func DenyRequest(ctx *context.Context) {
 	responseError(ctx, "Unauthorized operation")
 }