Add rule elements for active effects (#519)

* Make the checktypes a set
* Add triggers for expenses
* Add a targeting rule predicate
* Provide quantifier option for effect predicate
* Let's use CharacterInfo as the name for the event data
* Add a rule trigger on effect toggling
* Add a prompt for applying damage
* Add update resource prompt
* Add action to update track
* Add dialog prompt for effects that can modify damage types
* Add custom icon select dialog
* Add damage source option to calculate damage trigger
* Add update token action
* Add play sound effect action
* Add text enrichment to the message rule action
* Use a foldout for the REs
* Make the damage rule trigger sources a aset
* Add action to execute macro
* Add render check rule trigger
* Add initialize check rule trigger
Refactor common section targeted
* Add support for update resource to add targeted actions
* Add selected option for update resource
* Add initialize check trigger support on weapons
* Fix remove effect message handler
* Add support for instancing effect from fuid to apply effect RE
* Filter by check types
* Fix up resource request absoluting on request ctor
* Support targeting non-check skills
* Use colors for resource gain/loss
* Fix missing check for inspector
* Add damage and resource data models to consumables
* Add trigger and action for create consumable
* Add a generic traits data model
* Add a traits rule predicate
* Separate model for traits and trait predicate
* Fix up several trait issues
* Use new icon set for affinities
* Add resource data model for spell
* Add various confirmation dialogs for RE window
* Fix up resouce usage  by spell data
* Remove base 64 methods from inline helper
* Clean up character info
* Simplify the dispatch of the initialize check event
* Rename CommonSections.actions
* Add register callback for process check hook
* Add comments for async hooks
* Add effect application data to spell
* Fix invoking modifyDamage when no damage is set
* Add support for resource + effects in skills
* Fix up spell damage validation
* Rename to subscollectionfield
* Rename the sub document uuid property to guid as it'ss not an actual uuid
* Remove the duplicate icons
* Add warnings for when players try to apply to non-owned actors
* Fix up the array element rendering
* Have the spell rule predicate replace the spell rule trigger
* Add source info to the apply effect prompt
* Start implementing a damage customizer on REs
* Consolidate the changes applied by REs into the damage modifiers
* Set event hook for the toggles in the dialog
* Update the type selection
* Add cost data to the damage modifiers
* Correct the damage customization check
* Add support for elementalist cataclysm

Author: Azurelol

lang/en.json

@@ -488,6 +488,7 @@
 		"DamageCollateral": "Collateral Damage",
 		"DamageTypeCollateral": "Collateral Damage Type",
 		"DamageType": "Damage Type",
+		"DamageSource": "Damage Source",
 		"Damage": "Damage",
 		"HasDamage": "Has Damage?",
 		"UseWeaponDamage": "Use Weapon Damage",
@@ -566,6 +567,7 @@
 		"EnemyTurn": "Enemy Turn",
 		"Round": "Round",
 		"SurpriseRound": "Surprise Round",
+		"StartOfCombat": "Start of Combat",
 		"StartOfTurn": "Start of Turn",
 		"EndOfTurn": "End Of Turn",
 		"EndOfRound": "End of Round",
@@ -689,9 +691,13 @@
 		"ChatContextRerollFabula": "Invoke Trait to Reroll",
 		"ChatContextPush": "Invoke Bond to Push",
 		"ChatContextRerollUltima": "Invoke Trait to Reroll",
+		"ChatActorOwnershipWarning": "You cannot perform that action on that actor as you do not own it.",
 		"DialogPushBond": "Bond of ",
 		"DialogPushAnd": " and ",
 		"DialogPushWith": " with ",
+		"DialogRemoveTitle": "Remove",
+		"DialogRemoveMessage": "Remove <strong>{label}</strong>?",
+		"DialogClearMessage": "Clear all elements?",
 		"Success": "Success",
 		"Critical": "Critical",
 		"Failure": "Failure",
@@ -937,6 +943,16 @@
 		"ChatFumbleOpportunity": "The opposition of <strong>{actor}</strong> gets to apply the effects of an opportunity!",
 		"ChatOpportunitySettingMissing": "Automation for opportunities must be set on the system's homebrew settings",
 		"ChatPromptCheck": "A check has been prompted to <strong>{verb}</strong> the following clock:",
+		"ChatApplyEffect": "<strong>{effect}</strong> has been applied by <strong>{source}</source>",
+		"ChatApplyEffectHint": "Apply <strong>{effect}</strong> to the target.",
+		"ChatApplyEffectPrompt": "One of the following effects can be applied due to <strong>{source}</strong>.",
+		"ChatRemoveEffect": "Remove effect",
+		"ChatRemoveEffectPrompt": "One of the following effects can be removed due to <strong>{source}</strong>.",
+		"ChatApplyDamagePrompt": "The followings characters have <strong>suffered {amount} {type} damage</strong> due to <strong>{source}</strong>.",
+		"ChatResourceGainPrompt": "The followings characters have <strong>gained {amount} {type}</strong> due to <strong>{source}</strong>.",
+		"ChatResourceLossPrompt": "The followings characters have <strong>lost {amount} {type}</strong> due to <strong>{source}</strong>.",
+		"ChatResourceGainTooltip": "Gain <strong>{amount} {resource}</strong>.",
+		"ChatResourceLossTooltip": "Lose <strong>{amount} {resource}</strong>.",
 		"Increment": "Increment",
 		"Decrement": "Decrement",
 		"TotalAvailableSkills": "Total Available Skills",
@@ -1586,6 +1602,106 @@
 			"ChangeWarning2": "Changing an Item's Fabula Ultima ID might break references to the Item! Proceed with caution and only if you are sure.",
 			"ChangeWarning3": "Do you want to proceed?",
 			"ChangeWarning1": "Proceed with caution!"
-		}
+		},
+		"EventRelation": "Event Relation",
+		"EventRelationHint": "The context in which the the character fits in the event",
+		"FactionRelation": "Faction Relation",
+		"FactionRelationHint": "The targets' faction relation with the character",
+		"Selector": "Selector",
+		"SelectorHint": "Determines which characters is the rule element executed on.",
+		"Id": "Id",
+		"AutomationRuleElements": "Rule Elements",
+		"AutomationRuleElementsHint": "Whether to enable rule element automation",
+		"RuleElement": "Rule Element",
+		"RuleElementOptions": "Rule Elements",
+		"RuleElementNew": "Add new rule element",
+		"RuleActions": "Rule Actions",
+		"RuleActionMessage": "Message",
+		"RuleActionApplyDamage": "Apply Damage",
+		"RuleActionModifyDamage": "Modify Damage",
+		"RuleActionUpdateResource": "Update Resource",
+		"RuleActionApplyEffect": "Apply Effect",
+		"RuleActionClearEffect": "Clear Effect",
+		"RuleActionChangeTraits": "Change Traits",
+		"RuleActionModifyCheck": "Modify Check",
+		"RuleActionModifyExpense": "Modify Expense",
+		"RuleActionNotify": "Notify",
+		"RuleActionUpdateTrack": "Update Track",
+		"RuleActionUpdateToken": "Update Token",
+		"RuleActionPlaySoundEffect": "Play Sound Effect",
+		"RuleActionExecuteMacro": "Execute Macro",
+		"RuleActionModifyConsumable": "Modify Consumable",
+		"RuleTrigger": "Rule Trigger",
+		"RuleTriggerCombat": "Combat",
+		"RuleTriggerAttack": "Attack",
+		"RuleTriggerInitializeCheck": "Initialize Check",
+		"RuleTriggerPerformCheck": "Perform Check",
+		"RuleTriggerResolveCheck": "Resolve Check",
+		"RuleTriggerRenderCheck": "Render Check",
+		"RuleTriggerDamage": "Damage",
+		"RuleTriggerStatus": "Status",
+		"RuleTriggerResourceUpdate": "Resource Update",
+		"RuleTriggerResourceExpend": "Resource Expenditure",
+		"RuleTriggerCalculateDamage": "Calculate Damage",
+		"RuleTriggerToggle": "Toggle",
+		"RuleTriggerNotify": "Notify",
+		"RuleTriggerCreateConsumable": "Create Consumable",
+		"RulePredicates": "Rule Predicates",
+		"RulePredicateBond": "Bond",
+		"RulePredicateSpell": "Spell",
+		"RulePredicateFactionRelation": "Faction Relation",
+		"RulePredicateEffect": "Effect",
+		"RulePredicateSpecies": "Species",
+		"RulePredicateWeapon": "Weapon",
+		"RulePredicateResource": "Resource",
+		"RulePredicateTargeting": "Targeting",
+		"RulePredicateTraits": "Traits",
+		"AccuracyCheckRule": "Accuracy Check Rule",
+		"Type": "Type",
+		"Mode": "Mode",
+		"Any": "Any",
+		"Initial": "Initial",
+		"Ally": "Ally",
+		"Enemy": "Enemy",
+		"Allies": "Allies",
+		"Enemies": "Enemies",
+		"Even": "Even",
+		"Odd": "Odd",
+		"CheckResult": "Check Result",
+		"Outcome": "Outcome",
+		"True": "True",
+		"False": "False",
+		"Status": "Status",
+		"Change": "Change",
+		"Added": "Added",
+		"Removed": "Removed",
+		"CheckType": "Check Type",
+		"Result": "Result",
+		"ComparisonOperator": "Comparison Operator",
+		"GreaterThan": "Greater Than",
+		"LessThan": "Less Than",
+		"ExpenseSource": "Expense Source",
+		"Quantifier": "Quantifier",
+		"Enabled": "Enabled",
+		"Update": "Update",
+		"Reset": "Reset",
+		"Equals": "Equals",
+		"SelectDamageType": "Damage Type Selection",
+		"Scale": "Scale",
+		"Image": "Image",
+		"Asset": "Asset",
+		"Volume": "Volume",
+		"Macro": "Macro",
+		"OnApply": "On Apply",
+		"OnRoll": "On Roll",
+		"Multiplier": "Multiplier",
+		"Targeting": "Targeting",
+		"Changes": "Changes",
+		"Types": "Types",
+		"Expense": "Expense",
+		"Modifiers": "Modifiers",
+		"Variant": "Variant",
+		"OverChannel": "Over Channel",
+		"IncubationWarning": "The following feature is currently incubating and there may be issues present. Please bear that in mind."
 	}
 }

module/checks/accuracy-check.mjs

@@ -1,6 +1,5 @@
-import { FU, SYSTEM } from '../helpers/config.mjs';
+import { SYSTEM } from '../helpers/config.mjs';
 import { CheckHooks } from './check-hooks.mjs';
-import { CHECK_ROLL } from './default-section-order.mjs';
 import { Flags } from '../helpers/flags.mjs';
 import { CommonSections } from './common-sections.mjs';
 import { CommonEvents } from './common-events.mjs';
@@ -97,49 +96,47 @@ const handleWeaponTraitAccuracyBonuses = (check, actor, item) => {
 
 /**
  * Hook called to process the result of the roll
- * @param {CheckResultV2} check
- * @param {FUActor} actor
- * @param {FUItem} [item]
+ * @type ProcessCheckHook
  */
-const onProcessCheck = (check, actor, item) => {
+const onProcessCheck = (check, actor, item, registerCallback) => {
 	const { type, critical, fumble } = check;
 	if (type === 'accuracy') {
-		const configurer = CheckConfiguration.configure(check);
-		configurer.modifyTargetedDefense((value) => value ?? 'def');
+		const config = CheckConfiguration.configure(check);
+		config.modifyTargetedDefense((value) => value ?? 'def');
 		// TODO: Refactor alongside magic-checks
 		if (critical) {
-			configurer.addTraits('critical');
+			config.addTraits('critical');
 		} else if (fumble) {
-			configurer.addTraits('fumble');
+			config.addTraits('fumble');
 		}
-		configurer.modifyDamage((damage) => {
+		config.modifyDamage((damage) => {
 			if (damage) {
 				const weaponTraits = CheckConfiguration.inspect(check).getWeaponTraits();
 
 				// All Damage
 				const globalBonus = actor.system.bonuses.damage.all;
 				if (globalBonus) {
-					damage.modifiers.push({ label: `FU.DamageBonusAll`, value: globalBonus });
+					damage.addModifier(`FU.DamageBonusAll`, globalBonus);
 				}
 				// Attack Type
 				if (weaponTraits.weaponType) {
 					const attackTypeBonus = actor.system.bonuses.damage[weaponTraits.weaponType] ?? 0;
 					if (attackTypeBonus) {
-						damage.modifiers.push({ label: `FU.DamageBonusType${weaponTraits.weaponType.capitalize()}`, value: attackTypeBonus });
+						damage.addModifier(`FU.DamageBonusType${weaponTraits.weaponType.capitalize()}`, attackTypeBonus);
 					}
 				}
 				// Weapon Category
 				if (weaponTraits.weaponCategory) {
 					const weaponCategoryBonus = actor.system.bonuses.damage[weaponTraits.weaponCategory] ?? 0;
 					if (weaponCategoryBonus) {
-						damage.modifiers.push({ label: `FU.DamageBonusCategory${weaponTraits.weaponCategory.capitalize()}`, value: weaponCategoryBonus });
+						damage.addModifier(`FU.DamageBonusCategory${weaponTraits.weaponCategory.capitalize()}`, weaponCategoryBonus);
 					}
 				}
 
 				// Damage Type
 				const damageTypeBonus = actor.system.bonuses.damage[damage.type];
 				if (damageTypeBonus) {
-					damage.modifiers.push({ label: `FU.DamageBonus${damage.type.capitalize()}`, value: damageTypeBonus });
+					damage.addModifier(`FU.DamageBonus${damage.type.capitalize()}`, damageTypeBonus);
 				}
 			}
 			return damage;
@@ -157,26 +154,9 @@ const onProcessCheck = (check, actor, item) => {
 function onRenderCheck(data, checkResult, actor, item, flags) {
 	if (checkResult.type === 'accuracy') {
 		const inspector = CheckConfiguration.inspect(checkResult);
-		const checkData = inspector.getCheck();
-		const damageData = inspector.getExtendedDamageData();
-
-		// Push combined data for accuracy and damage
-		data.push({
-			order: CHECK_ROLL,
-			partial: 'systems/projectfu/templates/chat/chat-check-container.hbs',
-			data: {
-				check: checkData,
-				damage: damageData,
-				translation: {
-					damageTypes: FU.damageTypes,
-					damageIcon: FU.affIcon,
-				},
-			},
-		});
-
 		/** @type TargetData[] */
 		const targets = inspector.getTargets();
-		CommonSections.targeted(data, actor, item, targets, flags, checkData, damageData);
+		CommonSections.actions(data, actor, item, targets, flags, inspector);
 		CommonEvents.attack(inspector, actor, item);
 		(flags[SYSTEM] ??= {})[Flags.ChatMessage.Item] ??= item.toObject();
 	}