test(recommendations): address override review comments

Harden the console.warn spy cleanup in the frontend override refresh
test, add the missing override-lookup error pass-through regression, and
align the dashboard coverage test with explicit zero-coverage semantics.

Author: cristim

frontend/src/__tests__/settings-accounts.test.ts

@@ -616,21 +616,23 @@ describe('Overrides panel — AWS payment selector', () => {
     mockLoadRecommendations.mockRejectedValueOnce(new Error('network blip'));
     const consoleWarnSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});
 
-    const panel = await openOverridesPanel('acc-1');
-    const select = panel.querySelector('select.override-payment-select') as HTMLSelectElement;
-    select.value = 'all-upfront';
-    select.dispatchEvent(new Event('change'));
-    await new Promise(r => setTimeout(r, 0));
-
-    expect(api.saveAccountServiceOverride).toHaveBeenCalledTimes(1);
-    expect(consoleWarnSpy).toHaveBeenCalled();
-    // No error toast should have been shown for the refresh failure: the
-    // success toast from the save path is what the user sees.
-    const toastCalls = mockShowToast.mock.calls.map(c => c[0]);
-    const errorToasts = toastCalls.filter(t => (t as { kind?: string }).kind === 'error');
-    expect(errorToasts).toHaveLength(0);
-
-    consoleWarnSpy.mockRestore();
+    try {
+      const panel = await openOverridesPanel('acc-1');
+      const select = panel.querySelector('select.override-payment-select') as HTMLSelectElement;
+      select.value = 'all-upfront';
+      select.dispatchEvent(new Event('change'));
+      await new Promise(r => setTimeout(r, 0));
+
+      expect(api.saveAccountServiceOverride).toHaveBeenCalledTimes(1);
+      expect(consoleWarnSpy).toHaveBeenCalled();
+      // No error toast should have been shown for the refresh failure: the
+      // success toast from the save path is what the user sees.
+      const toastCalls = mockShowToast.mock.calls.map(c => c[0]);
+      const errorToasts = toastCalls.filter(t => (t as { kind?: string }).kind === 'error');
+      expect(errorToasts).toHaveLength(0);
+    } finally {
+      consoleWarnSpy.mockRestore();
+    }
   });
 
   test('Inherit is disabled when override already has a payment set (no clear-field channel)', async () => {

internal/api/handler_dashboard.go

@@ -146,9 +146,9 @@ func summarizeRecommendationsWithCoverage(
 	return total, byService
 }
 
-// scaledSavings returns rec.Savings * min(coverage, 100) / 100 when a
-// non-zero coverage entry exists for the rec's (account, provider, service)
-// triple. Otherwise returns rec.Savings unchanged.
+// scaledSavings returns rec.Savings * min(max(coverage, 0), 100) / 100 when
+// a coverage entry exists for the rec's (account, provider, service) triple.
+// Otherwise returns rec.Savings unchanged.
 func scaledSavings(rec config.RecommendationRecord, coverageByKey map[string]float64) float64 {
 	if rec.CloudAccountID == nil || coverageByKey == nil {
 		return rec.Savings
@@ -165,7 +165,6 @@ func scaledSavings(rec config.RecommendationRecord, coverageByKey map[string]flo
 	}
 	return rec.Savings * coverage / 100
 }
-}
 
 // resolveCoverageByAccountKey returns a map of AccountConfigKey -> resolved
 // coverage% for every (account, provider, service) triple represented in

internal/api/handler_dashboard_test.go

@@ -172,10 +172,10 @@ func TestSummarizeRecommendationsWithCoverage(t *testing.T) {
 			wantTotal: 50 + 200,
 		},
 		{
-			name:      "zero coverage treated as 'no scaling configured'",
+			name:      "zero coverage scales savings to zero",
 			recs:      []config.RecommendationRecord{rec(acctA, 100)},
 			coverage:  map[string]float64{keyA: 0},
-			wantTotal: 100,
+			wantTotal: 0,
 		},
 		{
 			name:      "coverage at 100 applies no scaling",

internal/scheduler/scheduler_overrides_test.go

@@ -260,6 +260,24 @@ func TestApplyAccountOverrides_LookupError_PassesThrough(t *testing.T) {
 	assert.Len(t, recs, 1, "un-filtered list returned on lookup failure")
 }
 
+func TestApplyAccountOverrides_OverrideLookupError_PassesThrough(t *testing.T) {
+	// Mirrors the global-config lookup failure contract: if the per-account
+	// override lookup fails, the page should over-show rather than blank.
+	ctx := context.Background()
+	store := &mockOverrideStore{
+		recs: []config.RecommendationRecord{rdsRec("acct-A", "us-east-1", "mysql")},
+		globals: map[string]*config.ServiceConfig{
+			"aws|rds": {Provider: "aws", Service: "rds", Enabled: true},
+		},
+		getOverrideErr: errors.New("override lookup timeout"),
+	}
+	s := &Scheduler{config: store}
+
+	recs, err := s.ListRecommendations(ctx, config.RecommendationFilter{})
+	require.NoError(t, err, "ListRecommendations swallows the override-resolver error")
+	assert.Len(t, recs, 1, "un-filtered list returned on override lookup failure")
+}
+
 // Issue #196 acceptance criterion (mirrored from issue #111):
 //
 // Seed a global ServiceConfig + a per-account override that disables one