-
-
Notifications
You must be signed in to change notification settings - Fork 999
Expand file tree
/
Copy pathStartSession.php
More file actions
476 lines (399 loc) · 15.2 KB
/
Copy pathStartSession.php
File metadata and controls
476 lines (399 loc) · 15.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
<?php
namespace Leantime\Core\Middleware;
use Closure;
use Illuminate\Contracts\Cache\LockTimeoutException;
use Illuminate\Contracts\Session\Session;
use Illuminate\Session\SessionManager;
use Illuminate\Session\Store;
use Illuminate\Support\Carbon;
use Illuminate\Support\Facades\Cache;
use Illuminate\Support\Facades\Date;
use Illuminate\Support\Facades\Log;
use Leantime\Core\Events\DispatchesEvents;
use Leantime\Core\Http\IncomingRequest;
use Symfony\Component\HttpFoundation\Cookie;
use Symfony\Component\HttpFoundation\Response;
class StartSession
{
use DispatchesEvents;
/**
* The session manager.
*
* @var \Illuminate\Session\SessionManager
*/
protected $manager;
/**
* The callback that can resolve an instance of the cache factory.
*
* @var callable|null
*/
protected $cacheFactoryResolver;
/**
* Create a new session middleware.
*
* @return void
*/
public function __construct(SessionManager $manager, ?callable $cacheFactoryResolver = null)
{
$this->manager = $manager;
$this->cacheFactoryResolver = $cacheFactoryResolver;
}
/**
* Handle an incoming request.
*
* @return mixed
*/
public function handle(IncomingRequest $request, Closure $next)
{
if (! $this->sessionConfigured()) {
return $next($request);
}
// For API and cron requests, use in-memory array driver to prevent
// persistent session accumulation. Must run BEFORE getSession() so the
// session object is created with the array handler from the start.
// Browser AJAX requests (JS calling JSON-RPC) are excluded so they
// continue to share the user's web session.
if ($request->isApiOrCronRequest() && ! $request->ajax()) {
config(['session.driver' => 'array']);
$this->manager->setDefaultDriver('array');
}
$session = $this->getSession($request);
self::dispatchEvent('session_initialized');
// API and cron requests are stateful but non-persisting and never lock
// (unchanged behavior: their writes were never saved to begin with).
if (! $this->shouldPersistSession($request)) {
return $this->handleStatelessRequest($request, $session, $next);
}
// Web requests use optimistic concurrency: run lock-free, then persist only
// the keys that actually changed, merging them under a brief lock so parallel
// requests (e.g. dashboard widgets) can't clobber each other's writes.
return $this->handleOptimisticRequest($request, $session, $next);
}
/**
* Handle a stateful but non-persisting request (API / cron). The session is
* started so it can be read, but it is never locked and never written back —
* this preserves the pre-existing behavior for these request types.
*
* @param \Illuminate\Contracts\Session\Session $session
* @return mixed
*/
protected function handleStatelessRequest(IncomingRequest $request, $session, Closure $next)
{
$request->setLaravelSession($this->startSession($request, $session));
self::dispatchEvent('session_started');
$this->collectGarbage($session);
$response = $next($request);
$this->addCookieToResponse($response, $session);
return $response;
}
/**
* Handle a web request with optimistic session concurrency. The request runs
* without holding the session lock so concurrent requests (e.g. parallel
* dashboard widgets) are not serialized. Only when the session actually
* changed do we briefly lock, re-read the freshest persisted state, and merge
* just this request's changed keys — preventing the lost-update race that
* previously forced blanket locking.
*
* @param \Illuminate\Contracts\Session\Session $session
* @return mixed
*/
protected function handleOptimisticRequest(IncomingRequest $request, $session, Closure $next)
{
$startTime = microtime(true);
$request->setLaravelSession($this->startSession($request, $session));
self::dispatchEvent('session_started');
$this->collectGarbage($session);
$initialId = $session->getId();
$initialData = $session->all();
$response = $next($request);
$this->storeCurrentUrl($request, $session);
$this->persistSessionChanges($request, $session, $initialId, $initialData);
$duration = microtime(true) - $startTime;
if ($duration > 3.0) {
Log::warning("Long session operation detected: {$duration}s for session {$session->getId()}");
}
$this->addCookieToResponse($response, $session);
return $response;
}
/**
* Persist session changes using a lock-on-write strategy.
*
* @param \Illuminate\Contracts\Session\Session $session
*/
protected function persistSessionChanges(IncomingRequest $request, $session, string $initialId, array $initialData): void
{
// The session identity changed (login/logout regenerate or invalidate).
// Keys can't be safely merged onto a different id, so fall back to a full,
// locked save of the live session.
if ($session->getId() !== $initialId) {
$this->withSessionLock($request, $session, fn () => $session->save());
return;
}
[$changed, $removed] = $this->diffSession($initialData, $session->all());
// Pure read: nothing changed, so we never touch the lock or storage.
if ($changed === [] && $removed === []) {
return;
}
$this->withSessionLock($request, $session, fn () => $this->mergeSessionChanges($session, $changed, $removed));
}
/**
* Re-read the freshest persisted session state and apply ONLY the keys this
* request changed/removed onto it, then write it back. Merging by changed-key
* (rather than overwriting the whole blob) is what lets a concurrent writer's
* keys survive. Must be called while holding the per-session lock.
*
* @param \Illuminate\Contracts\Session\Session $session
* @param array<string, mixed> $changed
* @param array<int, string> $removed
*/
protected function mergeSessionChanges($session, array $changed, array $removed): void
{
$merged = new Store(
$session->getName(),
$session->getHandler(),
$session->getId(),
$this->manager->getSessionConfig()['serialization'] ?? 'php'
);
$merged->start();
// Keep the CSRF token consistent with what the live session (and the
// already-rendered response) used; a fresh Store would otherwise
// regenerate a different token and break the next POST.
$merged->put('_token', $session->token());
foreach ($changed as $key => $value) {
$merged->put($key, $value);
}
foreach ($removed as $key) {
$merged->forget($key);
}
$merged->save();
}
/**
* Compute the keys this request added/changed and the keys it removed,
* comparing the session state captured before the request against the
* state after it.
*
* @return array{0: array<string, mixed>, 1: array<int, string>}
*/
protected function diffSession(array $initial, array $current): array
{
$changed = [];
foreach ($current as $key => $value) {
if (! array_key_exists($key, $initial) || $initial[$key] !== $value) {
$changed[$key] = $value;
}
}
$removed = array_keys(array_diff_key($initial, $current));
return [$changed, $removed];
}
/**
* Acquire the per-session lock, run the persistence callback, and release.
* Falls back to an exponential-backoff retry if the lock can't be acquired.
*
* @param \Illuminate\Contracts\Session\Session $session
*/
protected function withSessionLock(IncomingRequest $request, $session, Closure $callback): void
{
// Dynamic lock period for different request types
$holdLockFor = $this->calculateLockDuration($request); // Hold lock for x seconds after acquiring
// Maximum time to wait for acquiring the lock if already held
$maxWaitForLock = 5; // Wait for up to y seconds to acquire the lock
$lock = $this->cache($this->manager->blockDriver())
->lock('session:'.$session->getId(), $holdLockFor)
->betweenBlockedAttemptsSleepFor(50);
try {
$lock->block($maxWaitForLock);
$callback();
} catch (LockTimeoutException $e) {
Log::warning("Session lock timeout for session {$session->getId()}: {$e->getMessage()}");
// Implement exponential backoff retry
$this->retryWithBackoff($callback, $session);
} finally {
$lock?->release();
}
}
/**
* Calculate appropriate lock duration based on request type. This is v0. We'll need to make this smarter
*/
protected function calculateLockDuration(IncomingRequest $request): int
{
if ($request->isMethod('GET')) {
return 1; // Shorter duration for GET requests
}
if ($request->ajax()) {
return 2; // Medium duration for AJAX requests
}
return 3; // Default duration for other requests
}
/**
* Implement exponential backoff retry strategy for the persistence callback.
*
* @param \Illuminate\Contracts\Session\Session $session
*/
protected function retryWithBackoff(Closure $callback, $session, int $attempts = 3): void
{
for ($i = 0; $i < $attempts; $i++) {
try {
$waitTime = min(100 * pow(2, $i), 1000); // Exponential backoff with max 1 second
$jitter = random_int(-100, 100); // Add jitter to prevent thundering herd
usleep(($waitTime + $jitter) * 1000); // Convert to microseconds
$callback();
return;
} catch (\Exception $e) {
Log::warning("Retry attempt {$i} failed for session {$session->getId()}: {$e->getMessage()}");
continue;
}
}
// If all retries fail, persist without the lock as a last resort.
Log::error("All retry attempts failed for session {$session->getId()}, persisting without lock");
$callback();
}
/**
* Start the session for the given request.
*
* @param \Illuminate\Contracts\Session\Session $session
* @return \Illuminate\Contracts\Session\Session
*/
protected function startSession(IncomingRequest $request, $session)
{
return tap($session, function ($session) use ($request) {
$session->setRequestOnHandler($request);
$session->start();
});
}
/**
* Get the session implementation from the manager.
*
* @return \Illuminate\Contracts\Session\Session
*/
public function getSession(IncomingRequest $request)
{
return tap($this->manager->driver(), function ($session) use ($request) {
$session->setId($request->cookies->get($session->getName()));
});
}
/**
* Remove the garbage from the session if necessary.
*
* @return void
*/
protected function collectGarbage(Session $session)
{
$config = $this->manager->getSessionConfig();
// Here we will see if this request hits the garbage collection lottery by hitting
// the odds needed to perform garbage collection on any given request. If we do
// hit it, we'll call this handler to let it delete all the expired sessions.
if ($this->configHitsLottery($config)) {
$session->getHandler()->gc($this->getSessionLifetimeInSeconds());
}
}
/**
* Determine if the configuration odds hit the lottery.
*
* @return bool
*/
protected function configHitsLottery(array $config)
{
return random_int(1, $config['lottery'][1]) <= $config['lottery'][0];
}
/**
* Store the current URL for the request if necessary.
*
* @param \Illuminate\Contracts\Session\Session $session
* @return void
*/
protected function storeCurrentUrl(IncomingRequest $request, $session)
{
// Only full-page navigations set the "previous URL" used for back-redirects.
// HTMX partials must not, otherwise every background widget load would dirty
// the session and force a needless lock-merge-save.
if (
$request->isMethod('GET')
&& ! $request->isHtmxRequest()
&& $this->shouldPersistSession($request)
) {
$session->setPreviousUrl($request->fullUrl());
}
}
/**
* Add the session cookie to the application response.
*
* @return void
*/
protected function addCookieToResponse(Response $response, Session $session)
{
if ($this->sessionIsPersistent($config = $this->manager->getSessionConfig())) {
$response->headers->setCookie(new Cookie(
$session->getName(),
$session->getId(),
$this->getCookieExpirationDate(),
$config['path'],
$config['domain'],
$config['secure'] ?? false,
$config['http_only'] ?? true,
false,
$config['same_site'] ?? null,
$config['partitioned'] ?? false
));
}
}
/**
* Determine whether this request should persist its session to storage.
* API and cron requests are stateful-but-throwaway and are never persisted.
*
* @return bool
*/
protected function shouldPersistSession(IncomingRequest $request)
{
return $request->isApiOrCronRequest() === false && $this->sessionConfigured();
}
/**
* Get the session lifetime in seconds.
*
* @return int
*/
protected function getSessionLifetimeInSeconds()
{
return ($this->manager->getSessionConfig()['lifetime'] ?? null) * 60;
}
/**
* Get the cookie lifetime in seconds.
*
* @return \DateTimeInterface|int
*/
protected function getCookieExpirationDate()
{
$config = $this->manager->getSessionConfig();
return $config['expire_on_close'] ? 0 : Date::instance(
Carbon::now()->addRealMinutes($config['lifetime'])
);
}
/**
* Determine if a session driver has been configured.
*
* @return bool
*/
protected function sessionConfigured()
{
return ! is_null($this->manager->getSessionConfig()['driver'] ?? null);
}
/**
* Determine if the configured session driver is persistent.
*
* @return bool
*/
protected function sessionIsPersistent(?array $config = null)
{
$config = $config ?: $this->manager->getSessionConfig();
return ! is_null($config['driver'] ?? null);
}
/**
* Resolve the given cache driver.
*
* @param string $driver
* @return \Illuminate\Contracts\Cache\Repository
*/
protected function cache($driver)
{
return Cache::store($driver);
}
}