WIP

Author: agrojean-ledger

.vscode/settings.json

@@ -1,28 +1,36 @@
 {
     "files.associations": {
-        "*.h": "c"
+        "*.h": "c",
+        "optional": "c",
+        "istream": "c",
+        "ostream": "c",
+        "ratio": "c",
+        "array": "c",
+        "functional": "c",
+        "tuple": "c",
+        "type_traits": "c",
+        "utility": "c",
+        "system_error": "c"
     },
     "ledgerDevTools.appSettings": {
-        "selectedUseCase": "release",
-        "selectedDevice": "Nano X",
+        "selectedUseCase": "debug",
+        "selectedDevice": "Stax",
         "selectedVariant": "BOL",
         "testsList": [
             "test_app_mainmenu",
             "test_app_name",
-            "test_bad_cla",
-            "test_bad_ins",
-            "test_wrong_p1p2",
-            "test_wrong_data_length",
-            "test_invalid_state",
             "test_get_app_and_version",
             "test_get_public_key_no_confirm",
             "test_get_public_key_confirm_accepted",
             "test_get_public_key_confirm_refused",
-            "test_sign_tx_short_tx",
-            "test_sign_tx_short_tx_blind_sign",
-            "test_sign_tx_long_tx",
-            "test_sign_tx_refused",
+            "test_sign_tx_hash_32",
+            "test_sign_tx_hash_34",
+            "test_sign_tx_ping",
+            "test_sign_topology_tx",
             "test_version"
+        ],
+        "selectedTests": [
+            "test_sign_tx_token_transfer"
         ]
     }
 }

src/handler/sign_tx.c

@@ -79,8 +79,19 @@ int handler_sign_tx(buffer_t *cdata, signing_type_e type, bool first, bool more,
         if (result != 0) {
             return io_send_sw(result);  // Send the error code via io_send_sw
         }
-        return (G_context.state == STATE_PARSED) ? ui_display_blind_signed_transaction()
-                                                 : io_send_sw(SW_OK);
+
+        if (G_context.state == STATE_PARSED) {
+            if (G_context.tx_info.clear_signing_available == true) {
+                return ui_display_transaction();
+            } else {
+                return ui_display_blind_signed_transaction();
+            }
+        } else {
+            return io_send_sw(SW_OK);
+        }
+
+        // return (G_context.state == STATE_PARSED) ? ui_display_blind_signed_transaction()
+        //                                          : io_send_sw(SW_OK);
     } else {
         // Invalid state
         PRINTF("Invalid state after processing chunk: %d\n", G_context.state);
@@ -98,6 +109,7 @@ static int process_tx_chunk(buffer_t *cdata,
         PRINTF("Processing first chunk of transaction\n");
         G_context.req_type = CONFIRM_TRANSACTION;
         G_context.signing_type = type;
+        G_context.tx_info.clear_signing_available = false;
         G_context.state = STATE_EXPECTING_MORE;
 
         if (type == SIGN_PREPARED_TRANSACTION) {

src/transaction/canonical_hash.c

@@ -24,50 +24,6 @@ static const uint8_t PREPARED_TRANSACTION_HASH_PURPOSE[4] = {0x00, 0x00, 0x00, 0
 #define HASHING_SCHEME_VERSION ((uint8_t) 2) /* 0x02 */
 #define NODE_ENCODING_VERSION  ((uint8_t) 1) /* 0x01 */
 
-/* -------------------------------------------------------------------------- */
-/*  Adaption layer for nanopb oneof names                                      */
-/* -------------------------------------------------------------------------- */
-#define VALUE_ONEOF_FIELD     which_sum
-#define VALUE_UNIT_TAG        com_daml_ledger_api_v2_Value_unit_tag
-#define VALUE_BOOL_TAG        com_daml_ledger_api_v2_Value_bool__tag
-#define VALUE_INT64_TAG       com_daml_ledger_api_v2_Value_int64_tag
-#define VALUE_NUMERIC_TAG     com_daml_ledger_api_v2_Value_numeric_tag
-#define VALUE_TIMESTAMP_TAG   com_daml_ledger_api_v2_Value_timestamp_tag
-#define VALUE_DATE_TAG        com_daml_ledger_api_v2_Value_date_tag
-#define VALUE_PARTY_TAG       com_daml_ledger_api_v2_Value_party_tag
-#define VALUE_TEXT_TAG        com_daml_ledger_api_v2_Value_text_tag
-#define VALUE_CONTRACT_ID_TAG com_daml_ledger_api_v2_Value_contract_id_tag
-#define VALUE_OPTIONAL_TAG    com_daml_ledger_api_v2_Value_optional_tag
-#define VALUE_LIST_TAG        com_daml_ledger_api_v2_Value_list_tag
-#define VALUE_TEXT_MAP_TAG    com_daml_ledger_api_v2_Value_text_map_tag
-#define VALUE_RECORD_TAG      com_daml_ledger_api_v2_Value_record_tag
-#define VALUE_VARIANT_TAG     com_daml_ledger_api_v2_Value_variant_tag
-#define VALUE_ENUM_TAG        com_daml_ledger_api_v2_Value_enum__tag
-#define VALUE_GEN_MAP_TAG     com_daml_ledger_api_v2_Value_gen_map_tag
-
-// Node version and kind oneofs
-#define NODE_VERSION_ONEOF_FIELD which_versioned_node
-#define NODE_V1_TAG              com_daml_ledger_api_v2_interactive_DeviceDamlTransaction_Node_v1_tag
-#define NODE_V1_KIND_ONEOF_FIELD which_node_type
-#define NODE_V1_CREATE_TAG       com_daml_ledger_api_v2_interactive_transaction_v1_Node_create_tag
-#define NODE_V1_EXERCISE_TAG     com_daml_ledger_api_v2_interactive_transaction_v1_Node_exercise_tag
-#define NODE_V1_FETCH_TAG        com_daml_ledger_api_v2_interactive_transaction_v1_Node_fetch_tag
-#define NODE_V1_ROLLBACK_TAG     com_daml_ledger_api_v2_interactive_transaction_v1_Node_rollback_tag
-
-typedef com_daml_ledger_api_v2_interactive_transaction_v1_Node Node_V1;
-typedef com_daml_ledger_api_v2_interactive_DeviceDamlTransaction_NodeSeed NodeSeed;
-
-typedef com_daml_ledger_api_v2_interactive_transaction_v1_Create Node_Create;
-typedef com_daml_ledger_api_v2_interactive_transaction_v1_Exercise Node_Exercise;
-typedef com_daml_ledger_api_v2_interactive_transaction_v1_Fetch Node_Fetch;
-typedef com_daml_ledger_api_v2_interactive_transaction_v1_Rollback Node_Rollback;
-
-typedef com_daml_ledger_api_v2_Value Value;
-typedef com_daml_ledger_api_v2_RecordField RecordField;
-typedef com_daml_ledger_api_v2_GenMap_Entry GenMapEntry;
-typedef com_daml_ledger_api_v2_TextMap_Entry TextMapEntry;
-typedef com_daml_ledger_api_v2_Identifier Identifier;
-
 /* -------------------------------------------------------------------------- */
 /*  Error handling                                                            */
 /* -------------------------------------------------------------------------- */

src/transaction/canonical_hash.h

@@ -1,7 +1,8 @@
 #pragma once
 
 #include "cx.h"
-
+#include "com/daml/ledger/api/v2/interactive/interactive_submission_service.pb.h"
+#include "bytewriter.h"
 #include "tx_types.h"
 
 typedef struct {

src/transaction/prepared_transaction.c

@@ -6,16 +6,58 @@
 #include "os.h"
 #include "cx.h"
 #include "buffer.h"
+#include "mem.h"  // for app_mem_alloc
 
 #include "sign_tx.h"
 #include "sw.h"
 #include "globals.h"
 #include "display.h"
 #include "tx_types.h"
 #include "proto_deserialize.h"
+#include "prepared_transaction.h"
 #include "validate.h"
 #include "canonical_hash.h"
 
+#define TRANSFER_CMD_DISPLAY_FIELDS 4
+
+// Configuration structures
+typedef struct {
+    const char *package_id;
+    const char *module_name;
+    const char *entity_name;
+} identifier_config_t;
+
+// Configuration constants
+static const identifier_config_t EXTERNAL_PARTY_AMULET_RULES_TEMPLATE = {
+    .package_id = "95a88ff9ffd509e097802ecf3bbd58c83a5dff408e439cca4e2105ebd2cd0760",
+    .module_name = "Splice.ExternalPartyAmuletRules",
+    .entity_name = "ExternalPartyAmuletRules"};
+
+static const char *TRANSFER_FACTORY_CHOICE_ID = "TransferFactory_Transfer";
+
+static const identifier_config_t TRANSFER_RECORD = {
+    .package_id = "55ba4deb0ad4662c4168b39859738a0e91388d252286480c7331b3f71a517281",
+    .module_name = "Splice.Api.Token.TransferInstructionV1",
+    .entity_name = "TransferFactory_Transfer"};
+
+typedef struct {
+    const char *item_name;
+    int field_index;
+} field_display_t;
+
+// const char sender_label[] = "Sender";
+// const char receiver_label[] = "Receiver";
+// const char amount_label[] = "Amount";
+// const char instrument_id_label[] = "Instrument ID";
+
+// Field display configuration
+const field_display_t SENDER_FIELD = {"Sender", 0};
+const field_display_t RECEIVER_FIELD = {"Receiver", 1};
+const field_display_t AMOUNT_FIELD = {"Amount", 2};
+const field_display_t INSTRUMENT_ID_FIELD = {"Instrument ID", 3};
+
+#define TRANSFER_CMD_DISPLAY_FIELDS 4
+
 typedef enum {
     RECEIVING_DAML_TX_PART,              /// Receiving part of DAML transaction
     RECEIVING_DAML_NODES,                /// Receiving DAML nodes
@@ -24,8 +66,8 @@ typedef enum {
 } prepared_tx_receiving_state_e;
 
 static prepared_tx_receiving_state_e tx_state = RECEIVING_DAML_TX_PART;
-
 static int process_prepared_tx_finalize();
+static void parse_node_for_display(const Node *node, transaction_ctx_t *tx_info);
 
 void process_prepared_tx_init() {
     tx_state = RECEIVING_DAML_TX_PART;
@@ -66,6 +108,9 @@ int process_prepared_tx_part(buffer_t *buf) {
                                 &G_context.tx_info.tx_parts_ctx.daml_transaction,
                                 &G_context.tx_info.tx_parts_ctx.node);
 
+            // Extract displayable fields from the node
+            parse_node_for_display(&G_context.tx_info.tx_parts_ctx.node, &G_context.tx_info);
+
             release_node(&G_context.tx_info);
 
             if (res != 0) {
@@ -176,3 +221,135 @@ static int process_prepared_tx_finalize() {
 
     return 0;
 }
+
+// Helper function to match identifiers
+static bool match_identifier(const Identifier *id, const identifier_config_t *config) {
+    return strcmp(id->package_id, (char *) PIC(config->package_id)) == 0 &&
+           strcmp(id->module_name, (char *) PIC(config->module_name)) == 0 &&
+           strcmp(id->entity_name, (char *) PIC(config->entity_name)) == 0;
+}
+
+// Helper function to initialize transaction pairs
+static bool init_transaction_pairs(transaction_ctx_t *tx_info, size_t count) {
+    // Free existing pairs if any
+    if (tx_info->pairs != NULL) {
+        app_mem_free(tx_info->pairs);
+    }
+
+    // Free existing allocated strings if any
+    if (tx_info->allocated_strings != NULL) {
+        // Free individual strings first
+        for (size_t i = 0; i < tx_info->pairs_count; i++) {
+            if (tx_info->allocated_strings[i] != NULL) {
+                app_mem_free(tx_info->allocated_strings[i]);
+            }
+        }
+        app_mem_free(tx_info->allocated_strings);
+    }
+
+    // Allocate new arrays
+    tx_info->pairs_count = count;
+    tx_info->pairs =
+        (nbgl_contentTagValue_t *) app_mem_alloc(count * sizeof(nbgl_contentTagValue_t));
+    tx_info->allocated_strings = (char **) app_mem_alloc(count * sizeof(char *));
+
+    if (tx_info->pairs == NULL || tx_info->allocated_strings == NULL) {
+        tx_info->pairs_count = 0;
+        return false;
+    }
+
+    memset(tx_info->pairs, 0, count * sizeof(nbgl_contentTagValue_t));
+    memset(tx_info->allocated_strings, 0, count * sizeof(char *));
+
+    return true;
+}
+
+// Helper function to set field value safely with context-managed memory
+static void set_field_value(transaction_ctx_t *tx_info,
+                            const field_display_t *field_config,
+                            const char *value) {
+    if (field_config->field_index < TRANSFER_CMD_DISPLAY_FIELDS && value != NULL) {
+        size_t value_len = strlen(value) + 1;
+
+        // Allocate memory in the context's allocated_strings array
+        tx_info->allocated_strings[field_config->field_index] = (char *) app_mem_alloc(value_len);
+        if (tx_info->allocated_strings[field_config->field_index] != NULL) {
+            memcpy(tx_info->allocated_strings[field_config->field_index], value, value_len);
+            tx_info->pairs[field_config->field_index].item = (char *) PIC(field_config->item_name);
+            tx_info->pairs[field_config->field_index].value =
+                tx_info->allocated_strings[field_config->field_index];
+        }
+    }
+}
+
+// Process transfer fields - maintains single-pass efficiency
+static void process_transfer_fields(const com_daml_ledger_api_v2_Record *rec,
+                                    transaction_ctx_t *tx_info) {
+    // Single pass through top-level fields
+    for (size_t i = 0; i < rec->fields_count; i++) {
+        const RecordField *field = &rec->fields[i];
+
+        if (strcmp(field->label, "transfer") == 0) {
+            const com_daml_ledger_api_v2_Record *transfer_rec = &field->value->record;
+            for (size_t j = 0; j < transfer_rec->fields_count; j++) {
+                const RecordField *transfer_field = &transfer_rec->fields[j];
+
+                if (strcmp(transfer_field->label, "sender") == 0) {
+                    set_field_value(tx_info, &SENDER_FIELD, transfer_field->value->party);
+                } else if (strcmp(transfer_field->label, "receiver") == 0) {
+                    set_field_value(tx_info, &RECEIVER_FIELD, transfer_field->value->party);
+                } else if (strcmp(transfer_field->label, "amount") == 0) {
+                    set_field_value(tx_info, &AMOUNT_FIELD, transfer_field->value->numeric);
+                } else if (strcmp(transfer_field->label, "instrumentId") == 0) {
+                    const com_daml_ledger_api_v2_Record *inst_id_rec =
+                        &transfer_field->value->record;
+                    // Single pass through instrument ID fields
+                    for (size_t k = 0; k < inst_id_rec->fields_count; k++) {
+                        const RecordField *inst_id_field = &inst_id_rec->fields[k];
+                        if (strcmp(inst_id_field->label, "id") == 0) {
+                            set_field_value(tx_info,
+                                            &INSTRUMENT_ID_FIELD,
+                                            inst_id_field->value->text);
+                        }
+                    }
+                }
+            }
+        }
+    }
+}
+
+// Helper function to process transfer command
+static void process_transfer_command(const com_daml_ledger_api_v2_Record *rec,
+                                     transaction_ctx_t *tx_info) {
+    if (!init_transaction_pairs(tx_info, TRANSFER_CMD_DISPLAY_FIELDS)) {
+        return;
+    }
+    process_transfer_fields(rec, tx_info);
+    tx_info->clear_signing_available = true;
+}
+
+// Helper function to process exercise node
+static void process_exercise_node(const Node_Exercise *exercise, transaction_ctx_t *tx_info) {
+    if (!exercise->has_template_id) {
+        return;
+    }
+
+    // Check if this is a transfer command
+    if (match_identifier(&exercise->template_id, &EXTERNAL_PARTY_AMULET_RULES_TEMPLATE) &&
+        strcmp(exercise->choice_id, TRANSFER_FACTORY_CHOICE_ID) == 0 &&
+        match_identifier(&exercise->chosen_value.record.record_id, &TRANSFER_RECORD)) {
+        process_transfer_command(&exercise->chosen_value.record, tx_info);
+    }
+}
+
+// Main parsing function
+static void parse_node_for_display(const Node *node, transaction_ctx_t *tx_info) {
+    if (node->NODE_VERSION_ONEOF_FIELD != NODE_V1_TAG) {
+        return;
+    }
+
+    const Node_V1 *v = &node->v1;
+    if (v->NODE_V1_KIND_ONEOF_FIELD == NODE_V1_EXERCISE_TAG) {
+        process_exercise_node(&v->exercise, tx_info);
+    }
+}