Merge pull request #44 from LedgerHQ/update-validators

Update validators

Author: agrojean-ledger

.pre-commit-config.yaml

@@ -13,7 +13,7 @@ exclude: |
 
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v5.0.0
+    rev: v6.0.0
     hooks:
       - id: trailing-whitespace
       - id: end-of-file-fixer
@@ -23,33 +23,44 @@ repos:
       - id: check-case-conflict
 
   - repo: https://github.com/codespell-project/codespell
-    rev: v2.4.1
+    rev: v2.4.2
     hooks:
       - id: codespell
         args:
           - --skip=tests/tx_examples/*
 
   - repo: https://github.com/pre-commit/mirrors-clang-format
-    rev: v14.0.6
+    rev: v21.1.8
     hooks:
       - id: clang-format
         types_or: [c]
 
   - repo: https://github.com/Mateusz-Grzelinski/actionlint-py
-    rev: v1.7.7.23
+    rev: v1.7.12.24
     hooks:
       - id: actionlint
         types_or: [yaml]
         args: [-shellcheck='' -pyflakes='']
 
   - repo: https://github.com/markdownlint/markdownlint
-    rev: v0.12.0
+    rev: v0.17.0
     hooks:
       - id: markdownlint
         types_or: [markdown]
 
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.15.20
+    hooks:
+    # Run the linter.
+    - id: ruff-check
+      args: [ --fix ]
+    # Run the formatter.
+    - id: ruff-format
+      args: [ --line-length=120 ]
+      files: '^tests/.*$'
+
   - repo: https://github.com/PyCQA/pylint
-    rev: v3.3.6
+    rev: v4.0.6
     hooks:
       - id: pylint
         language: system

CHANGELOG.md

@@ -5,6 +5,18 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [3.3.3] - 2026-07-10
+
+### Fixed
+
+- Various minor fixes.
+
+### Changed
+
+- Update devnet and testnet validators.
+- Remove clear signing for Featured app proxy transactions.
+- Update tests and snapshots.
+
 ## [3.3.1] - 2026-02-27
 
 ### Fixed

Makefile

@@ -30,7 +30,7 @@ APPNAME = "Canton"
 # Application version
 APPVERSION_M = 3
 APPVERSION_N = 3
-APPVERSION_P = 2
+APPVERSION_P = 3
 APPVERSION = "$(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)"
 
 # Application source files

attestations/generateCryptoData.py

@@ -63,7 +63,7 @@ def main() -> None:
     # Extract KEY parameters
     logger.debug(f"Extracting {key_file} parameters...")
     cmd = f"openssl pkey -inform pem -in {key_file} -noout -text"
-    stdout = check_exec(cmd)
+    check_exec(cmd)
 
     # Get key bytes
     private_key, public_key = get_keys_bytes(key_file)

src/handler/get_version.c

@@ -38,9 +38,9 @@ MUST_CHECK int handler_get_version() {
                    "PATCH version must be between 0 and 255!");
 
     return io_send_response_pointer(
-        (const uint8_t *) &(uint8_t[APPVERSION_LEN]){(uint8_t) MAJOR_VERSION,
-                                                     (uint8_t) MINOR_VERSION,
-                                                     (uint8_t) PATCH_VERSION},
+        (const uint8_t *) &(uint8_t[APPVERSION_LEN]) {(uint8_t) MAJOR_VERSION,
+                                                      (uint8_t) MINOR_VERSION,
+                                                      (uint8_t) PATCH_VERSION},
         APPVERSION_LEN,
         SW_OK);
 }

src/helper/send_reponse.c

@@ -45,7 +45,7 @@ MUST_CHECK int helper_send_response_sig() {
     size_t offset = 0;
 
     LEDGER_ASSERT(G_context.tx_info.signature_len == ED25519_SIG_LEN,
-                  "Invalid signature length in helper_send_response_sig");
+                  "Invalid sig length in send_response_sig");
 
     resp[offset++] = G_context.tx_info.signature_len;
     memmove(resp + offset, G_context.tx_info.signature, G_context.tx_info.signature_len);
@@ -55,7 +55,7 @@ MUST_CHECK int helper_send_response_sig() {
         PRINTF("Also sending challenge signature\n");
         resp[offset++] = G_context.tx_info.challenge_signature_len;
         LEDGER_ASSERT(G_context.tx_info.challenge_signature_len == ED25519_SIG_LEN,
-                      "Invalid challenge signature length in helper_send_response_sig");
+                      "Invalid challenge sig length in send_response");
         memmove(resp + offset,
                 G_context.tx_info.challenge_signature,
                 G_context.tx_info.challenge_signature_len);

src/transaction/canonical_hash.c

@@ -126,7 +126,7 @@ void hw_init(HashWriter *hw) {
 
 void hw_put(HashWriter *hw, const void *p, size_t n) {
     LEDGER_ASSERT(hw != NULL, "Null HashWriter passed to hw_put");
-    LEDGER_ASSERT(p == NULL ? n == 0 : true, "Null pointer with non-zero length passed to hw_put");
+    LEDGER_ASSERT(p == NULL ? n == 0 : true, "Null ptr with non-zero length in hw_put");
     CX_ASSERT(cx_hash_update((cx_hash_t *) &hw->ctx, p, n));
 }
 
@@ -300,7 +300,7 @@ void encode_create_end(HashWriter *hw, const Node_CreateCb *c) {
 
 void encode_exercise_start(HashWriter *hw, const Node_ExerciseCb *e, const uint8_t *seed) {
     LEDGER_ASSERT(hw != NULL, "Null HashWriter passed to encode_exercise_start");
-    LEDGER_ASSERT(e != NULL, "Null exercise node passed to encode_exercise_start");
+    LEDGER_ASSERT(e != NULL, "Null exercise node in encode_exercise_start");
 
     hw_put_byte(hw, NODE_ENCODING_VERSION);
     encode_string(hw, e->lf_version);
@@ -326,7 +326,7 @@ void encode_exercise_start(HashWriter *hw, const Node_ExerciseCb *e, const uint8
 
 void encode_exercise_middle(HashWriter *hw, const Node_ExerciseCb *e) {
     LEDGER_ASSERT(hw != NULL, "Null HashWriter passed to encode_exercise_middle");
-    LEDGER_ASSERT(e != NULL, "Null exercise node passed to encode_exercise_middle");
+    LEDGER_ASSERT(e != NULL, "Null exercise node in encode_exercise_middle");
 
     encode_bool(hw, e->consuming);
 }
@@ -425,8 +425,8 @@ void hash_transaction(HashWriter *hw, const DamlTransaction *tx) {
 }
 
 void finalize_hash_transaction(HashWriter *hw, uint8_t out[SHA256_HASH_LEN]) {
-    LEDGER_ASSERT(hw != NULL, "Null HashWriter passed to finalize_hash_transaction");
-    LEDGER_ASSERT(out != NULL, "Null output buffer passed to finalize_hash_transaction");
+    LEDGER_ASSERT(hw != NULL, "Null HashWriter in finalize_hash_transaction");
+    LEDGER_ASSERT(out != NULL, "Null out buffer in finalize_hash_transaction");
 
     hw_finalize(hw, out);
 

src/transaction/pb_hashing_parser.c

@@ -268,7 +268,7 @@ MUST_CHECK static bool count_record_field_helper(pb_istream_t *stream) {
 /* -------------------------------------------------------------------------- */
 
 static void decode_value_primitive_variants(cbValue *v) {
-    LEDGER_ASSERT(v != NULL, "NULL cbValue pointer passed to decode_value_primitive_variants");
+    LEDGER_ASSERT(v != NULL, "NULL cbValue in decode_value_primitive_variants");
 
     switch (v->which_sum) {
         case com_daml_ledger_api_v2_cb_Value_unit_tag: {
@@ -1000,7 +1000,7 @@ MUST_CHECK static bool versioned_node_decode_callback(pb_istream_t *stream,
                                                       void **arg) {
     (void) stream;
     (void) arg;
-    LEDGER_ASSERT(field != NULL, "NULL field passed to versioned_node_decode_callback");
+    LEDGER_ASSERT(field != NULL, "NULL field in versioned_node_decode_callback");
 
     com_daml_ledger_api_v2_interactive_DeviceDamlTransaction_Node *node = field->message;
 
@@ -1017,7 +1017,7 @@ MUST_CHECK static bool versioned_node_decode_callback(pb_istream_t *stream,
 
 parser_status_e proto_deserialize_node(buffer_t *buf, transaction_ctx_t *tx_ctx) {
     LEDGER_ASSERT(buf != NULL, "NULL buffer passed to proto_deserialize_node");
-    LEDGER_ASSERT(tx_ctx != NULL, "NULL transaction context passed to proto_deserialize_node");
+    LEDGER_ASSERT(tx_ctx != NULL, "NULL tx_ctx in proto_deserialize_node");
 
     pb_istream_t stream = pb_istream_from_buffer(buf->ptr, buf->size);
 
@@ -1059,9 +1059,8 @@ parser_status_e proto_deserialize_node(buffer_t *buf, transaction_ctx_t *tx_ctx)
 }
 
 parser_status_e proto_deserialize_input_contract(buffer_t *buf, transaction_ctx_t *tx_ctx) {
-    LEDGER_ASSERT(buf != NULL, "NULL buffer passed to proto_deserialize_input_contract");
-    LEDGER_ASSERT(tx_ctx != NULL,
-                  "NULL transaction context passed to proto_deserialize_input_contract");
+    LEDGER_ASSERT(buf != NULL, "NULL buf in proto_deserialize_input_contract");
+    LEDGER_ASSERT(tx_ctx != NULL, "NULL tx_ctx in proto_deserialize_input_contract");
 
     pb_istream_t stream = pb_istream_from_buffer(buf->ptr, buf->size);
 

src/transaction/pb_node_display_config.c

@@ -6,10 +6,8 @@
 /* -------------------------------------------------------------------------- */
 
 // Use distinct argument names (_p, _n) to avoid any potential macro expansion conflicts
-#define FLD(_p, _n, _f, _m) \
-    { .path = _p, .item_name = _n, .format_callback = _f, .mandatory = _m }
-#define ID(_mod, _ent) \
-    { .module_name = _mod, .entity_name = _ent }
+#define FLD(_p, _n, _f, _m) {.path = _p, .item_name = _n, .format_callback = _f, .mandatory = _m}
+#define ID(_mod, _ent)      {.module_name = _mod, .entity_name = _ent}
 
 /* -------------------------------------------------------------------------- */
 /* Global Constants / Mappings                                                */
@@ -149,17 +147,6 @@ static const field_config_t PREAPPROVAL_PROPOSAL_FIELDS[] = {
     FLD("asset", "For asset", NULL, true),
     FLD("provider", "By validator", NULL, true)};
 
-static const field_config_t PROXY_TRANSFER_FIELDS[] = {
-    FLD("proxyArg.choiceArg.transfer.sender", "From", NULL, true),
-    FLD("proxyArg.choiceArg.transfer.amount", "Amount", format_token_amount_field, true),
-    FLD("proxyArg.choiceArg.transfer.receiver", "To", NULL, true),
-    FLD("proxyArg.choiceArg.transfer.instrumentId.id", "Token", NULL, true),
-    FLD("proxyArg.choiceArg.transfer.instrumentId.admin", NULL, NULL, true),
-    FLD("proxyArg.choiceArg.transfer.meta.values.splice\\.lfdecentralizedtrust\\.org/reason",
-        "Memo",
-        NULL,
-        false)};
-
 /* -------------------------------------------------------------------------- */
 /* Metadata identifiers lists                                                 */
 /* -------------------------------------------------------------------------- */
@@ -173,13 +160,14 @@ static const identifier_config_t *META_EMPTY[] = {};
 /* Main Display Configuration                                                 */
 /* -------------------------------------------------------------------------- */
 
-#define CFG_ENTRY(_id, _fields, _title, _finish, _meta)                               \
-    {                                                                                 \
-        .identifier = _id, .fields = _fields,                                         \
-        .fields_count = sizeof(_fields) / sizeof(_fields[0]), .review_title = _title, \
-        .review_finish = _finish, .metadata_contract_identifiers = _meta,             \
-        .metadata_contract_identifiers_count = sizeof(_meta) / sizeof(_meta[0])       \
-    }
+#define CFG_ENTRY(_id, _fields, _title, _finish, _meta)    \
+    {.identifier = _id,                                    \
+     .fields = _fields,                                    \
+     .fields_count = sizeof(_fields) / sizeof(_fields[0]), \
+     .review_title = _title,                               \
+     .review_finish = _finish,                             \
+     .metadata_contract_identifiers = _meta,               \
+     .metadata_contract_identifiers_count = sizeof(_meta) / sizeof(_meta[0])}
 
 const display_config_t DISPLAY_CONFIGS[] = {
     CFG_ENTRY(ID("Splice.Api.Token.TransferInstructionV1", "TransferFactory_Transfer"),
@@ -201,52 +189,24 @@ const display_config_t DISPLAY_CONFIGS[] = {
               PREAPPROVAL_PROPOSAL_REVIEW_FINISH,
               META_EMPTY),
 
-    CFG_ENTRY(
-        ID("Splice.Util.FeaturedApp.WalletUserProxy", "WalletUserProxy_TransferFactory_Transfer"),
-        PROXY_TRANSFER_FIELDS,
-        TOKEN_TRANSFER_REVIEW_TITLE,
-        TOKEN_TRANSFER_REVIEW_FINISH,
-        META_EMPTY),
-
     CFG_ENTRY(ID("Splice.Api.Token.TransferInstructionV1", "TransferInstruction_Accept"),
               TOKEN_TRANSFER_ACCEPT_FIELDS,
               TOKEN_TRANSFER_ACCEPT_REVIEW_TITLE,
               TOKEN_TRANSFER_ACCEPT_REVIEW_FINISH,
               TRANSFER_OFFER_META_ID_LIST),
 
-    CFG_ENTRY(
-        ID("Splice.Util.FeaturedApp.WalletUserProxy", "WalletUserProxy_TransferInstruction_Accept"),
-        TOKEN_TRANSFER_ACCEPT_FIELDS,
-        TOKEN_TRANSFER_ACCEPT_REVIEW_TITLE,
-        TOKEN_TRANSFER_ACCEPT_REVIEW_FINISH,
-        TRANSFER_OFFER_META_ID_LIST),
-
     CFG_ENTRY(ID("Splice.Api.Token.TransferInstructionV1", "TransferInstruction_Reject"),
               TOKEN_TRANSFER_ACCEPT_FIELDS,
               TOKEN_TRANSFER_REJECT_REVIEW_TITLE,
               TOKEN_TRANSFER_REJECT_REVIEW_FINISH,
               TRANSFER_OFFER_META_ID_LIST),
 
-    CFG_ENTRY(
-        ID("Splice.Util.FeaturedApp.WalletUserProxy", "WalletUserProxy_TransferInstruction_Reject"),
-        TOKEN_TRANSFER_ACCEPT_FIELDS,
-        TOKEN_TRANSFER_REJECT_REVIEW_TITLE,
-        TOKEN_TRANSFER_REJECT_REVIEW_FINISH,
-        TRANSFER_OFFER_META_ID_LIST),
-
     CFG_ENTRY(ID("Splice.Api.Token.TransferInstructionV1", "TransferInstruction_Withdraw"),
               TOKEN_TRANSFER_WITHDRAW_FIELDS,
               TOKEN_TRANSFER_WITHDRAW_REVIEW_TITLE,
               TOKEN_TRANSFER_WITHDRAW_REVIEW_FINISH,
               TRANSFER_OFFER_META_ID_LIST),
 
-    CFG_ENTRY(ID("Splice.Util.FeaturedApp.WalletUserProxy",
-                 "WalletUserProxy_TransferInstruction_Withdraw"),
-              TOKEN_TRANSFER_WITHDRAW_FIELDS,
-              TOKEN_TRANSFER_WITHDRAW_REVIEW_TITLE,
-              TOKEN_TRANSFER_WITHDRAW_REVIEW_FINISH,
-              TRANSFER_OFFER_META_ID_LIST),
-
 };
 
 const size_t DISPLAY_CONFIGS_NB = sizeof(DISPLAY_CONFIGS) / sizeof(DISPLAY_CONFIGS[0]);

src/transaction/pb_node_display_parser.c

@@ -311,7 +311,7 @@ static void set_field_value(tx_field_t *field_state, const void *value, pb_size_
     if (value_type == VALUE_TIMESTAMP_TAG) {
         ByteWriter bw;
         bw_init(&bw, ts_buf, sizeof(ts_buf));
-        bw_put_u64_be(&bw, (uint64_t) * ((int64_t *) PIC(value)));
+        bw_put_u64_be(&bw, (uint64_t) *((int64_t *) PIC(value)));
         src = ts_buf;
         len = sizeof(ts_buf);
     } else {
@@ -784,7 +784,7 @@ MUST_CHECK static bool versioned_node_decode_callback(pb_istream_t *stream,
                                                       const pb_field_t *field,
                                                       void **arg) {
     UNUSED(stream);
-    LEDGER_ASSERT(field != NULL, "NULL field passed to versioned_node_decode_callback");
+    LEDGER_ASSERT(field != NULL, "NULL field in versioned_node_decode_callback");
     LEDGER_ASSERT(arg != NULL, "NULL arg passed to versioned_node_decode_callback");
 
     pb_callback_context_t *ctx = (pb_callback_context_t *) (*arg);
@@ -804,7 +804,7 @@ MUST_CHECK static bool versioned_node_decode_callback(pb_istream_t *stream,
 /* -------------------------------------------------------------------------- */
 
 MUST_CHECK int format_and_populate_display_items(pb_callback_context_t *ctx) {
-    LEDGER_ASSERT(ctx != NULL, "NULL context passed to format_and_populate_display_items");
+    LEDGER_ASSERT(ctx != NULL, "NULL ctx in format_and_populate_display_items");
 
     int ret = 0;
 
@@ -979,7 +979,7 @@ MUST_CHECK int parse_node_for_display(buffer_t *buf) {
 }
 
 MUST_CHECK int parse_input_contract_for_display(buffer_t *buf) {
-    LEDGER_ASSERT(buf != NULL, "NULL buffer passed to parse_input_contract_for_display");
+    LEDGER_ASSERT(buf != NULL, "NULL buf in parse_input_contract_for_display");
 
     if (G_context.tx_info.clear_signing_available ||
         global_tx_metadata_contract_identifiers == NULL) {