Fix other memory leaks

Author: agrojean-ledger

src/transaction/pb_node_display_parser.c

@@ -331,6 +331,7 @@ bool init_transaction_pairs(transaction_ctx_t *tx_info, size_t count) {
     tx_info->pairs_count = 0;
     tx_info->pairs =
         (nbgl_contentTagValue_t *) app_mem_alloc(count * sizeof(nbgl_contentTagValue_t));
+    memset(tx_info->pairs, 0, count * sizeof(nbgl_contentTagValue_t));
     tx_info->display_items_strings = (char **) app_mem_alloc(count * sizeof(char *));
 
     if (tx_info->pairs == NULL || tx_info->display_items_strings == NULL) {
@@ -809,6 +810,13 @@ int parse_node_for_display(buffer_t *buf) {
                 idx++;
                 ctx.tx_info->pairs_count++;
 
+                app_mem_free(state->value);
+                state->value = NULL;
+                state->value_len = 0;
+            }
+        } else {
+            // Free any allocated value
+            if (state->value != NULL) {
                 app_mem_free(state->value);
                 state->value = NULL;
                 state->value_len = 0;

src/ui/nbgl_display_transaction.c

@@ -36,7 +36,6 @@
 #include "menu.h"
 #include "utils.h"
 
-static nbgl_contentTagValue_t pairs[1];
 static nbgl_contentTagValueList_t pairList;
 
 // called when long press button on 3rd page is long-touched or when reject footer is touched
@@ -65,10 +64,14 @@ int ui_display_transaction_bs_choice(bool is_blind_signed) {
         PRINTF("Hash: %.*H\n", sizeof(G_context.tx_info.m_hash), G_context.tx_info.m_hash);
         // Setup data to display
         size_t hex_hash_length = 2 * G_context.tx_info.m_hash_len + 1;
-        pairs[0].value = (char *) app_mem_alloc(hex_hash_length);
-        LEDGER_ASSERT(pairs[0].value != NULL, "Memory full");
-        pairs[0].item = "Transaction hash";
-        SNPRINTF((char *) pairs[0].value,
+        G_context.tx_info.pairs =
+            (nbgl_contentTagValue_t *) app_mem_alloc(sizeof(nbgl_contentTagValue_t));
+        LEDGER_ASSERT(G_context.tx_info.pairs != NULL, "Memory full");
+        memset(G_context.tx_info.pairs, 0, sizeof(nbgl_contentTagValue_t));
+        G_context.tx_info.pairs[0].item = "Transaction hash";
+        G_context.tx_info.pairs[0].value = (char *) app_mem_alloc(hex_hash_length);
+        LEDGER_ASSERT(G_context.tx_info.pairs[0].value != NULL, "Memory full");
+        SNPRINTF((char *) G_context.tx_info.pairs[0].value,
                  hex_hash_length,
                  "%.*H",
                  G_context.tx_info.m_hash_len,
@@ -77,7 +80,7 @@ int ui_display_transaction_bs_choice(bool is_blind_signed) {
         // Setup list
         pairList.nbMaxLinesForValue = 0;
         pairList.nbPairs = 1;
-        pairList.pairs = pairs;
+        pairList.pairs = G_context.tx_info.pairs;
 
         // Start blind-signing review flow
         nbgl_useCaseReviewBlindSigning(TYPE_TRANSACTION,