|
24 | 24 | * - parameter 8 happy path leaves valid=1, mismatch flips it, |
25 | 25 | * - eth2WithdrawalIndex > INDEX_MAX (2^16) is rejected as a |
26 | 26 | * derivation-path-attack guard, |
27 | | - * - FINALIZE: valid=1 -> OK + 2 screens, valid=0 -> FALLBACK, |
| 27 | + * - FINALIZE: valid=1 -> OK + 2 screens, valid=0 -> ERROR, |
28 | 28 | * - QUERY_CONTRACT_ID writes "ETH2"/"Deposit", |
29 | 29 | * - QUERY_CONTRACT_UI screen 0 is the amount (using |
30 | 30 | * g_chain_config->ticker), screen 1 is "0x" + 96 hex chars |
@@ -279,15 +279,15 @@ static void test_finalize_valid_returns_two_screens(void **state) { |
279 | 279 | assert_int_equal(msg.uiType, ETH_UI_TYPE_GENERIC); |
280 | 280 | } |
281 | 281 |
|
282 | | -static void test_finalize_invalid_falls_back(void **state) { |
| 282 | +static void test_finalize_invalid_returns_error(void **state) { |
283 | 283 | (void) state; |
284 | 284 | eth2_deposit_parameters_t ctx = {.valid = 0}; |
285 | 285 | txContent_t tx = {0}; |
286 | 286 | ethPluginFinalize_t msg = {0}; |
287 | 287 | msg.pluginContext = (uint8_t *) &ctx; |
288 | 288 | msg.txContent = &tx; |
289 | 289 | eth2_plugin_call(ETH_PLUGIN_FINALIZE, &msg); |
290 | | - assert_int_equal(msg.result, ETH_PLUGIN_RESULT_FALLBACK); |
| 290 | + assert_int_equal(msg.result, ETH_PLUGIN_RESULT_ERROR); |
291 | 291 | } |
292 | 292 |
|
293 | 293 | static void test_query_contract_id_eth2_deposit(void **state) { |
@@ -479,7 +479,7 @@ int main(void) { |
479 | 479 | cmocka_unit_test_setup(test_withdrawal_credentials_mismatch_flips_valid, reset), |
480 | 480 | cmocka_unit_test_setup(test_withdrawal_index_above_max_rejected, reset), |
481 | 481 | cmocka_unit_test_setup(test_finalize_valid_returns_two_screens, reset), |
482 | | - cmocka_unit_test_setup(test_finalize_invalid_falls_back, reset), |
| 482 | + cmocka_unit_test_setup(test_finalize_invalid_returns_error, reset), |
483 | 483 | cmocka_unit_test_setup(test_query_contract_id_eth2_deposit, reset), |
484 | 484 | cmocka_unit_test_setup(test_ui_amount_screen_uses_chain_ticker, reset), |
485 | 485 | cmocka_unit_test_setup(test_ui_validator_screen_renders_pubkey_hex, reset), |
|
0 commit comments