Removed const-qualifier on pointers arguments in function

Author: apaillier-ledger

src_features/signMessageEIP712/encode_field.c

@@ -13,7 +13,7 @@ typedef enum { MSB, LSB } e_padding_type;
  * @param[in] pval value used for padding
  * @return encoded field value
  */
-static void *field_encode(const uint8_t *const value,
+static void *field_encode(const uint8_t *value,
                           uint8_t length,
                           e_padding_type ptype,
                           uint8_t pval) {
@@ -53,7 +53,7 @@ static void *field_encode(const uint8_t *const value,
  * @param[in] length its byte-length
  * @return the encoded value
  */
-void *encode_uint(const uint8_t *const value, uint8_t length) {
+void *encode_uint(const uint8_t *value, uint8_t length) {
     // no length check here since it will be checked by field_encode
     return field_encode(value, length, MSB, 0x00);
 }
@@ -66,7 +66,7 @@ void *encode_uint(const uint8_t *const value, uint8_t length) {
  * @param[in] typesize the type size in bytes
  * @return the encoded value
  */
-void *encode_int(const uint8_t *const value, uint8_t length, uint8_t typesize) {
+void *encode_int(const uint8_t *value, uint8_t length, uint8_t typesize) {
     uint8_t padding_value;
 
     if (length < 1) {
@@ -91,7 +91,7 @@ void *encode_int(const uint8_t *const value, uint8_t length, uint8_t typesize) {
  * @param[in] length its byte-length
  * @return the encoded value
  */
-void *encode_bytes(const uint8_t *const value, uint8_t length) {
+void *encode_bytes(const uint8_t *value, uint8_t length) {
     // no length check here since it will be checked by field_encode
     return field_encode(value, length, LSB, 0x00);
 }
@@ -103,7 +103,7 @@ void *encode_bytes(const uint8_t *const value, uint8_t length) {
  * @param[in] length its byte-length
  * @return the encoded value
  */
-void *encode_boolean(const bool *const value, uint8_t length) {
+void *encode_boolean(const bool *value, uint8_t length) {
     if (length != 1)  // sanity check
     {
         apdu_response_code = APDU_RESPONSE_INVALID_DATA;
@@ -119,7 +119,7 @@ void *encode_boolean(const bool *const value, uint8_t length) {
  * @param[in] length its byte-length
  * @return the encoded value
  */
-void *encode_address(const uint8_t *const value, uint8_t length) {
+void *encode_address(const uint8_t *value, uint8_t length) {
     if (length != ADDRESS_LENGTH)  // sanity check
     {
         apdu_response_code = APDU_RESPONSE_INVALID_DATA;

src_features/signMessageEIP712/encode_field.h

@@ -5,8 +5,8 @@
 
 #define EIP_712_ENCODED_FIELD_LENGTH 32
 
-void *encode_uint(const uint8_t *const value, uint8_t length);
-void *encode_int(const uint8_t *const value, uint8_t length, uint8_t typesize);
-void *encode_boolean(const bool *const value, uint8_t length);
-void *encode_address(const uint8_t *const value, uint8_t length);
-void *encode_bytes(const uint8_t *const value, uint8_t length);
+void *encode_uint(const uint8_t *value, uint8_t length);
+void *encode_int(const uint8_t *value, uint8_t length, uint8_t typesize);
+void *encode_boolean(const bool *value, uint8_t length);
+void *encode_address(const uint8_t *value, uint8_t length);
+void *encode_bytes(const uint8_t *value, uint8_t length);

src_features/signMessageEIP712/field_hash.c

@@ -77,7 +77,7 @@ static const uint8_t *field_hash_prepare(const s_struct_712_field *field_ptr,
  * @return pointer to the encoded value
  */
 static const uint8_t *field_hash_finalize_static(const s_struct_712_field *field_ptr,
-                                                 const uint8_t *const data,
+                                                 const uint8_t *data,
                                                  uint8_t data_length) {
     uint8_t *value = NULL;
 
@@ -167,7 +167,7 @@ static void field_hash_feed_parent(e_type field_type, const uint8_t *hash) {
  * @return whether an error occurred or not
  */
 static bool field_hash_domain_special_fields(const s_struct_712_field *field_ptr,
-                                             const uint8_t *const data,
+                                             const uint8_t *data,
                                              uint8_t data_length) {
     const char *key;
     const char *ethermint_vc = "cosmos";
@@ -215,7 +215,7 @@ static bool field_hash_domain_special_fields(const s_struct_712_field *field_ptr
  * @return whether an error occurred or not
  */
 static bool field_hash_finalize(const s_struct_712_field *field_ptr,
-                                const uint8_t *const data,
+                                const uint8_t *data,
                                 uint8_t data_length) {
     const uint8_t *value = NULL;
 

src_features/signMessageEIP712/path.c

@@ -79,7 +79,7 @@ static const void *get_nth_field(uint8_t *fields_count_ptr, uint8_t n) {
  * @param[out] the number of fields in the depth of the returned field
  * @return the field which the path points to
  */
-static inline const void *get_field(uint8_t *const fields_count) {
+static inline const void *get_field(uint8_t *fields_count) {
     return get_nth_field(fields_count, path_struct->depth_count);
 }
 
@@ -187,7 +187,7 @@ static bool finalize_hash_depth(uint8_t *hash) {
  *
  * @param[in] hash pointer to given hash
  */
-static bool feed_last_hash_depth(const uint8_t *const hash) {
+static bool feed_last_hash_depth(const uint8_t *hash) {
     const cx_sha3_t *hash_ctx;
 
     hash_ctx = get_last_hash_ctx();
@@ -386,7 +386,7 @@ static bool path_update(bool skip_if_array, bool stop_at_array, bool do_typehash
  * @param[in] name_length the root struct name length
  * @return boolean indicating if it was successful or not
  */
-bool path_set_root(const char *const struct_name, uint8_t name_length) {
+bool path_set_root(const char *struct_name, uint8_t name_length) {
     uint8_t hash[KECCAK256_HASH_BYTESIZE];
 
     if (path_struct == NULL) {

src_features/signMessageEIP712/path.h

@@ -24,7 +24,7 @@ typedef struct {
     e_root_type root_type;
 } s_path;
 
-bool path_set_root(const char *const struct_name, uint8_t length);
+bool path_set_root(const char *struct_name, uint8_t length);
 const void *path_get_field(void);
 bool path_advance(bool do_typehash);
 bool path_init(void);

src_features/signMessageEIP712/type_hash.c

@@ -147,7 +147,7 @@ static bool compare_struct_deps(const s_struct_dep *a, const s_struct_dep *b) {
  * @param[out] hash_buf buffer containing the resulting type_hash
  * @return whether the type_hash was successful or not
  */
-bool type_hash(const char *const struct_name, const uint8_t struct_name_length, uint8_t *hash_buf) {
+bool type_hash(const char *struct_name, const uint8_t struct_name_length, uint8_t *hash_buf) {
     const void *struct_ptr;
     s_struct_dep *deps;
     cx_err_t error = CX_INTERNAL_ERROR;

src_features/signMessageEIP712/type_hash.h

@@ -3,4 +3,4 @@
 #include <stdint.h>
 #include <stdbool.h>
 
-bool type_hash(const char *const struct_name, const uint8_t struct_name_length, uint8_t *hash_buf);
+bool type_hash(const char *struct_name, const uint8_t struct_name_length, uint8_t *hash_buf);

src_features/signMessageEIP712/typed_data.c

@@ -78,7 +78,7 @@ const s_struct_712 *get_structn(const char *name, uint8_t length) {
  * @param[in] name name
  * @return whether it was successful
  */
-bool set_struct_name(uint8_t length, const uint8_t *const name) {
+bool set_struct_name(uint8_t length, const uint8_t *name) {
     s_struct_712 *new_struct;
 
     if (name == NULL) {
@@ -112,7 +112,7 @@ bool set_struct_name(uint8_t length, const uint8_t *const name) {
  * @return whether it was successful or not
  */
 static bool set_struct_field_typedesc(s_struct_712_field *field,
-                                      const uint8_t *const data,
+                                      const uint8_t *data,
                                       uint8_t *data_idx,
                                       uint8_t length) {
     uint8_t typedesc;
@@ -138,7 +138,7 @@ static bool set_struct_field_typedesc(s_struct_712_field *field,
  * @return whether it was successful
  */
 static bool set_struct_field_custom_typename(s_struct_712_field *field,
-                                             const uint8_t *const data,
+                                             const uint8_t *data,
                                              uint8_t *data_idx,
                                              uint8_t length) {
     uint8_t typename_len;
@@ -176,7 +176,7 @@ static bool set_struct_field_custom_typename(s_struct_712_field *field,
  * @return whether it was successful
  */
 static bool set_struct_field_array(s_struct_712_field *field,
-                                   const uint8_t *const data,
+                                   const uint8_t *data,
                                    uint8_t *data_idx,
                                    uint8_t length) {
     if ((*data_idx + sizeof(field->array_level_count)) > length)  // check buffer bound
@@ -225,7 +225,7 @@ static bool set_struct_field_array(s_struct_712_field *field,
  * @return whether it was successful
  */
 static bool set_struct_field_typesize(s_struct_712_field *field,
-                                      const uint8_t *const data,
+                                      const uint8_t *data,
                                       uint8_t *data_idx,
                                       uint8_t length) {
     // copy TypeSize
@@ -246,7 +246,7 @@ static bool set_struct_field_typesize(s_struct_712_field *field,
  * @return whether it was successful
  */
 static bool set_struct_field_keyname(s_struct_712_field *field,
-                                     const uint8_t *const data,
+                                     const uint8_t *data,
                                      uint8_t *data_idx,
                                      uint8_t length) {
     uint8_t keyname_len;
@@ -283,7 +283,7 @@ static bool set_struct_field_keyname(s_struct_712_field *field,
  * @param[in] data the field data
  * @return whether it was successful
  */
-bool set_struct_field(uint8_t length, const uint8_t *const data) {
+bool set_struct_field(uint8_t length, const uint8_t *data) {
     uint8_t data_idx = 0;
 
     if ((data == NULL) || (length == 0)) {

src_features/signMessageEIP712/typed_data.h

@@ -57,14 +57,14 @@ typedef struct struct_712 {
     s_struct_712_field *fields;
 } s_struct_712;
 
-const void *get_array_in_mem(const void *ptr, uint8_t *const array_size);
-const char *get_string_in_mem(const uint8_t *ptr, uint8_t *const string_length);
+const void *get_array_in_mem(const void *ptr, uint8_t *array_size);
+const char *get_string_in_mem(const uint8_t *ptr, uint8_t *string_length);
 const char *get_struct_field_custom_typename(const s_struct_712_field *field_ptr);
 const char *get_struct_field_typename(const s_struct_712_field *ptr);
-e_array_type struct_field_array_depth(const uint8_t *ptr, uint8_t *const array_size);
+e_array_type struct_field_array_depth(const uint8_t *ptr, uint8_t *array_size);
 const s_struct_712 *get_struct_list(void);
 const s_struct_712 *get_structn(const char *name_ptr, uint8_t name_length);
-bool set_struct_name(uint8_t length, const uint8_t *const name);
-bool set_struct_field(uint8_t length, const uint8_t *const data);
+bool set_struct_name(uint8_t length, const uint8_t *name);
+bool set_struct_field(uint8_t length, const uint8_t *data);
 bool typed_data_init(void);
 void typed_data_deinit(void);