FEAT

Author: cedelavergne-ledger

src/features/address_book/handle_identity.c

@@ -367,12 +367,12 @@ nbgl_contentTagValue_t *get_edit_identifier_tagValue(uint8_t pairIndex) {
             break;
 
         case 2:
-            g_ctx.current_pair.item = "Old address name";
+            g_ctx.current_pair.item = "Old address";
             g_ctx.current_pair.value = g_ctx.edit_identifier.old_identifier;
             break;
 
         case 3:
-            g_ctx.current_pair.item = "New address name";
+            g_ctx.current_pair.item = "New address";
             g_ctx.current_pair.value = g_ctx.edit_identifier.new_identifier;
             break;
 

src/features/address_book/handle_ledger_account.c

@@ -43,6 +43,11 @@
 
 /* Private defines -----------------------------------------------------------*/
 
+/** Number of hex chars shown on each side of the middle-truncated address */
+#define ADDR_SHORT_HEX_LEN 4
+/** "0x" + ADDR_SHORT_HEX_LEN + "..." + ADDR_SHORT_HEX_LEN + '\0' */
+#define ADDR_DISPLAY_SHORT_SIZE (2 + ADDR_SHORT_HEX_LEN + 3 + ADDR_SHORT_HEX_LEN + 1)
+
 /* Private types -------------------------------------------------------------*/
 
 /**
@@ -51,6 +56,7 @@
 typedef struct {
     char *address_display;
     char *network_display;
+    char address_display_short[ADDR_DISPLAY_SHORT_SIZE];  ///< "0x1234...5678"
     const char *texts[1];
     const char *subTexts[1];
     nbgl_warningDetails_t details;
@@ -158,6 +164,7 @@ void display_register_ledger_account_review(nbgl_choiceCallback_t choice_callbac
         get_network_icon_from_chain_id(&g_ctx.ledger_account->chain_id);
     register_ledger_account_ctx_t *ra = &g_ctx.register_account;
 
+    // Full address kept for the details modal (accessible via detail header icon)
     ra->texts[0] = "Address";
     ra->subTexts[0] = ra->address_display;
     ra->details.title = g_ctx.ledger_account->account_name;
@@ -166,13 +173,27 @@ void display_register_ledger_account_review(nbgl_choiceCallback_t choice_callbac
     ra->details.barList.texts = ra->texts;
     ra->details.barList.subTexts = ra->subTexts;
 
-    nbgl_useCaseChoiceWithDetails(icon,
-                                  "Confirm name?",
-                                  g_ctx.ledger_account->account_name,
-                                  "Confirm",
-                                  "Cancel",
-                                  &ra->details,
-                                  choice_callback);
+    // Middle-truncated address for the subMessage line: "0x1234...5678"
+    snprintf(ra->address_display_short,
+             sizeof(ra->address_display_short),
+             "0x%.*s...%s",
+             ADDR_SHORT_HEX_LEN,
+             ra->address_display + 2,
+             ra->address_display + 2 + ADDRESS_LENGTH_HEX - ADDR_SHORT_HEX_LEN);
+
+    nbgl_useCaseAdvancedChoiceWithDetails(icon,
+#ifdef SCREEN_SIZE_WALLET
+                                          &INFO_I_ICON,
+#else
+                                          NULL,
+#endif
+                                          "Confirm name?",
+                                          g_ctx.ledger_account->account_name,
+                                          ra->address_display_short,
+                                          "Confirm",
+                                          "Cancel",
+                                          &ra->details,
+                                          choice_callback);
 }
 
 /* =========================================================================