Merge pull request #1012 from LedgerHQ/feat/clickable_gcs_fields_of_unknown_token

Clickable GCS fields of unknown token

Author: apaillier-ledger

src/features/generic_tx_parser/gtp_param_token.c

@@ -72,7 +72,11 @@ bool format_param_token(const s_param_token *param, const char *name) {
             buf_shrink_expand(collec.value[i].ptr, collec.value[i].length, addr, sizeof(addr));
             if (match_native(addr, param)) {
                 ticker = get_displayable_ticker(&chain_id, g_chain_config, true);
-            } else if ((token_info = get_matching_token_info(&chain_id, addr))) {
+            } else {
+                if ((token_info = get_matching_token_info_or_dummy(&chain_id, addr)) == NULL) {
+                    ret = false;
+                    break;
+                }
                 ticker = token_info->ticker;
             }
             if (ticker == NULL) {

src/features/generic_tx_parser/gtp_param_token_amount.c

@@ -109,10 +109,11 @@ static bool process_token_amount(const s_param_token_amount *param,
             ticker = get_displayable_ticker(&chain_id, g_chain_config, true);
             decimals = WEI_TO_ETHER;
         } else {
-            if ((token_info = get_matching_token_info(&chain_id, addr_buf)) != NULL) {
-                ticker = token_info->ticker;
-                decimals = token_info->decimals;
+            if ((token_info = get_matching_token_info_or_dummy(&chain_id, addr_buf)) == NULL) {
+                return false;
             }
+            ticker = token_info->ticker;
+            decimals = token_info->decimals;
         }
     }
 

src/features/provide_erc20_token_information/token_info.c

@@ -2,6 +2,7 @@
 #include "lists.h"
 #include "app_mem_utils.h"
 #include "token_info.h"
+#include "network.h"
 
 typedef struct {
     flist_node_t _list;
@@ -59,3 +60,24 @@ const s_token_info *get_matching_token_info(const uint64_t *chain_id, const uint
     }
     return NULL;
 }
+
+const s_token_info *get_matching_token_info_or_dummy(const uint64_t *chain_id,
+                                                     const uint8_t *address) {
+    const s_token_info *info_ptr;
+    s_token_info info;
+
+    if ((chain_id == NULL) || (address == NULL)) {
+        return NULL;
+    }
+    if ((info_ptr = get_matching_token_info(chain_id, address)) != NULL) {
+        return info_ptr;
+    }
+    info.chain_id = *chain_id;
+    memcpy(info.address, address, ADDRESS_LENGTH);
+    strlcpy(info.ticker, g_unknown_ticker, sizeof(info.ticker));
+    info.decimals = 0;
+    if (set_token_info(&info) == -1) {
+        return NULL;
+    }
+    return get_matching_token_info(chain_id, address);
+}

src/features/provide_erc20_token_information/token_info.h

@@ -15,3 +15,5 @@ typedef struct {
 int set_token_info(const s_token_info *info);
 void clear_token_infos(void);
 const s_token_info *get_matching_token_info(const uint64_t *chain_id, const uint8_t *address);
+const s_token_info *get_matching_token_info_or_dummy(const uint64_t *chain_id,
+                                                     const uint8_t *address);