WIP - TO BE REMOVED

Author: cedelavergne-ledger

src/features/address_book/handle_identity.c

@@ -137,6 +137,9 @@ bool handle_check_register_identity(identity_t *params) {
     memmove(g_ctx.register_identity.identity, params, sizeof(identity_t));
     return true;
 }
+bool handle_check_identity(identity_t *params) {
+    return handle_check_register_identity(params);
+}
 
 /**
  * @brief Callback to retrieve a tag-value pair for the Register Identity UI
@@ -364,12 +367,12 @@ nbgl_contentTagValue_t *get_edit_identifier_tagValue(uint8_t pairIndex) {
             break;
 
         case 2:
-            g_ctx.current_pair.item = "Old address";
+            g_ctx.current_pair.item = "Old address name";
             g_ctx.current_pair.value = g_ctx.edit_identifier.old_identifier;
             break;
 
         case 3:
-            g_ctx.current_pair.item = "New address";
+            g_ctx.current_pair.item = "New address name";
             g_ctx.current_pair.value = g_ctx.edit_identifier.new_identifier;
             break;
 

src/features/address_book/handle_ledger_account.c

@@ -43,11 +43,6 @@
 
 /* Private defines -----------------------------------------------------------*/
 
-/** Number of hex chars shown on each side of the middle-truncated address */
-#define ADDR_SHORT_HEX_LEN 4
-/** "0x" + ADDR_SHORT_HEX_LEN + "..." + ADDR_SHORT_HEX_LEN + '\0' */
-#define ADDR_DISPLAY_SHORT_SIZE (2 + ADDR_SHORT_HEX_LEN + 3 + ADDR_SHORT_HEX_LEN + 1)
-
 /* Private types -------------------------------------------------------------*/
 
 /**
@@ -56,7 +51,6 @@
 typedef struct {
     char *address_display;
     char *network_display;
-    char address_display_short[ADDR_DISPLAY_SHORT_SIZE];  ///< "0x1234...5678"
     const char *texts[1];
     const char *subTexts[1];
     nbgl_warningDetails_t details;
@@ -152,6 +146,9 @@ bool handle_check_register_ledger_account(ledger_account_t *params) {
     memmove(g_ctx.ledger_account, params, sizeof(ledger_account_t));
     return true;
 }
+bool handle_check_ledger_account(ledger_account_t *account) {
+    return handle_check_register_ledger_account(account);
+}
 
 /**
  * @brief Handle called to display the Ledger Account review UI
@@ -161,7 +158,6 @@ void display_register_ledger_account_review(nbgl_choiceCallback_t choice_callbac
         get_network_icon_from_chain_id(&g_ctx.ledger_account->chain_id);
     register_ledger_account_ctx_t *ra = &g_ctx.register_account;
 
-    // Full address kept for the details modal (accessible via detail header icon)
     ra->texts[0] = "Address";
     ra->subTexts[0] = ra->address_display;
     ra->details.title = g_ctx.ledger_account->account_name;
@@ -170,27 +166,13 @@ void display_register_ledger_account_review(nbgl_choiceCallback_t choice_callbac
     ra->details.barList.texts = ra->texts;
     ra->details.barList.subTexts = ra->subTexts;
 
-    // Middle-truncated address for the subMessage line: "0x1234...5678"
-    snprintf(ra->address_display_short,
-             sizeof(ra->address_display_short),
-             "0x%.*s...%s",
-             ADDR_SHORT_HEX_LEN,
-             ra->address_display + 2,
-             ra->address_display + 2 + ADDRESS_LENGTH_HEX - ADDR_SHORT_HEX_LEN);
-
-    nbgl_useCaseAdvancedChoiceWithDetails(icon,
-#ifdef SCREEN_SIZE_WALLET
-                                          &INFO_I_ICON,
-#else
-                                          NULL,
-#endif
-                                          "Confirm name?",
-                                          g_ctx.ledger_account->account_name,
-                                          ra->address_display_short,
-                                          "Confirm",
-                                          "Cancel",
-                                          &ra->details,
-                                          choice_callback);
+    nbgl_useCaseChoiceWithDetails(icon,
+                                  "Confirm name?",
+                                  g_ctx.ledger_account->account_name,
+                                  "Confirm",
+                                  "Cancel",
+                                  &ra->details,
+                                  choice_callback);
 }
 
 /* =========================================================================
@@ -363,5 +345,8 @@ bool handle_provide_ledger_account(const ledger_account_t *account) {
     PRINTF("Stored '%s' (chain %llu)\n", node->contact_name, node->chain_id);
     return true;
 }
+bool handle_provide_ledger_account_contact(const ledger_account_t *account) {
+    return handle_provide_ledger_account(account);
+}
 
 #endif  // HAVE_ADDRESS_BOOK && HAVE_ADDRESS_BOOK_LEDGER_ACCOUNT

src/features/address_book/handle_provide_contact.c

@@ -214,5 +214,8 @@ bool handle_provide_identity(const identity_t *contact) {
     PRINTF("Stored '%s' (chain %llu)\n", node->contact_name, node->chain_id);
     return true;
 }
+bool handle_provide_contact(const identity_t *contact) {
+    return handle_provide_identity(contact);
+}
 
 #endif  // HAVE_ADDRESS_BOOK