Fixed dead condition in EIP-712 calldata filtering code

apaillier-ledger · apaillier-ledger · commit d61639cb3e8f · 2026-03-25T14:56:01.000+01:00
diff --git a/src/features/sign_message_eip712/ui_logic.c b/src/features/sign_message_eip712/ui_logic.c
@@ -788,7 +788,7 @@ static bool update_calldata_value(const uint8_t *data,
                 data += CALLDATA_SELECTOR_SIZE;
                 length -= CALLDATA_SELECTOR_SIZE;
                 calldata_size -= CALLDATA_SELECTOR_SIZE;
-            } else if (calldata_info->selector_state == CALLDATA_INFO_PARAM_NONE) {
+            } else if (calldata_info->selector_state == CALLDATA_INFO_PARAM_SET) {
                 selector = calldata_info->selector;
             }
             if ((g_parked_calldata = calldata_init(calldata_size, selector)) == NULL) {

Original file line number	Diff line number	Diff line change
`@@ -788,7 +788,7 @@ static bool update_calldata_value(const uint8_t *data,`
`788`	`788`	`data += CALLDATA_SELECTOR_SIZE;`
`789`	`789`	`length -= CALLDATA_SELECTOR_SIZE;`
`790`	`790`	`calldata_size -= CALLDATA_SELECTOR_SIZE;`
`791`		`- } else if (calldata_info->selector_state == CALLDATA_INFO_PARAM_NONE) {`
	`791`	`+ } else if (calldata_info->selector_state == CALLDATA_INFO_PARAM_SET) {`
`792`	`792`	`selector = calldata_info->selector;`
`793`	`793`	`}`
`794`	`794`	`if ((g_parked_calldata = calldata_init(calldata_size, selector)) == NULL) {`