Change selector argument type in calldata_init

Also now check return value of calldata_set_selector in EIP-712

Author: apaillier-ledger

src/features/generic_tx_parser/calldata.c

@@ -6,14 +6,17 @@
 #include "mem_utils.h"
 #include "lists.h"
 
-s_calldata *calldata_init(size_t size, const uint8_t selector[CALLDATA_SELECTOR_SIZE]) {
+s_calldata *calldata_init(size_t size, const uint8_t *selector) {
     s_calldata *calldata;
 
     if (APP_MEM_CALLOC((void **) &calldata, sizeof(*calldata)) == false) {
         return NULL;
     }
     calldata->expected_size = size;
-    calldata_set_selector(calldata, selector);
+    if (selector != NULL) {
+        // ignore return value since it cannot fail with valid arguments
+        calldata_set_selector(calldata, selector);
+    }
     return calldata;
 }
 

src/features/generic_tx_parser/calldata.h

@@ -31,7 +31,7 @@ typedef struct {
     size_t chunk_size;
 } s_calldata;
 
-s_calldata *calldata_init(size_t size, const uint8_t selector[CALLDATA_SELECTOR_SIZE]);
+s_calldata *calldata_init(size_t size, const uint8_t *selector);
 bool calldata_set_selector(s_calldata *calldata, const uint8_t selector[CALLDATA_SELECTOR_SIZE]);
 bool calldata_append(s_calldata *calldata, const uint8_t *buffer, size_t size);
 void calldata_delete(s_calldata *node);

src/features/sign_message_eip712/ui_logic.c

@@ -780,7 +780,9 @@ static bool update_calldata_selector(const uint8_t *data,
     buf_shrink_expand(data, length, calldata_info->selector, sizeof(calldata_info->selector));
     calldata_info->selector_state = CALLDATA_INFO_PARAM_SET;
     if (calldata_info->value_state == CALLDATA_INFO_PARAM_SET) {
-        calldata_set_selector(g_parked_calldata, calldata_info->selector);
+        if (!calldata_set_selector(g_parked_calldata, calldata_info->selector)) {
+            return false;
+        }
     }
     return true;
 }