Remove useless flag 'HAVE_GATING_SUPPORT'

Author: cedelavergne-ledger

makefile_conf/features.mk

@@ -47,8 +47,6 @@ ifeq ($(TARGET_NAME),$(filter $(TARGET_NAME),TARGET_STAX TARGET_FLEX TARGET_APEX
     DEFINES	+= HAVE_TRANSACTION_CHECKS
 endif
 
-# Gating signing - TODO: Reactivate this once the feature is fully available E2E
-DEFINES	+= HAVE_GATING_SUPPORT
 
 EIP7702_TEST_WHITELIST ?= 0
 ifneq ($(EIP7702_TEST_WHITELIST),0)

src/features/provide_gating/cmd_get_gating.c

@@ -16,8 +16,6 @@
  *
  ********************************************************************************/
 
-#ifdef HAVE_GATING_SUPPORT
-
 #include "cmd_get_gating.h"
 #include "app_mem_utils.h"
 #include "apdu_constants.h"
@@ -673,5 +671,3 @@ bool set_gating_warning(void) {
     set_gating_ui_screen();
     return true;
 }
-
-#endif  // HAVE_GATING_SUPPORT

src/features/provide_gating/cmd_get_gating.h

@@ -18,14 +18,10 @@
 
 #pragma once
 
-#ifdef HAVE_GATING_SUPPORT
-
 #include <stdint.h>
 #include <stdbool.h>
 
 uint16_t handle_gating(uint8_t p1, uint8_t p2, const uint8_t *data, uint8_t length);
 
 void clear_gating(void);
 bool set_gating_warning(void);
-
-#endif  // HAVE_GATING_SUPPORT

src/features/sign_message_eip712_common/common_712.c

@@ -99,9 +99,7 @@ uint16_t ui_712_start(e_eip712_filtering_mode filtering) {
     if (filtering == EIP712_FILTERING_BASIC) {
         // If the user has requested a filtered view, we will not show the warning
         warning.predefinedSet |= SET_BIT(BLIND_SIGNING_WARN);
-#ifdef HAVE_GATING_SUPPORT
         warning.predefinedSet |= SET_BIT(GATED_SIGNING_WARN);
-#endif
     }
     return SWO_SUCCESS;
 }

src/main.c

@@ -100,9 +100,7 @@ void reset_app_context(void) {
     clear_safe_account();
     ui_all_cleanup();
     proxy_cleanup();
-#ifdef HAVE_GATING_SUPPORT
     clear_gating();
-#endif
 }
 
 void app_quit(void) {
@@ -289,11 +287,9 @@ static uint16_t handleApdu(command_t *cmd, uint32_t *tx) {
             sw = handle_safe_account(cmd->p1, cmd->p2, cmd->data, cmd->lc);
             break;
 
-#ifdef HAVE_GATING_SUPPORT
         case INS_PROVIDE_GATING:
             sw = handle_gating(cmd->p1, cmd->p2, cmd->data, cmd->lc);
             break;
-#endif
 
         default:
             sw = SWO_INVALID_INS;

src/nbgl/ui_approve_tx.c

@@ -40,9 +40,7 @@ static void _cleanup(void) {
 #ifdef HAVE_TRANSACTION_CHECKS
     clear_tx_simulation();
 #endif
-#ifdef HAVE_GATING_SUPPORT
     clear_gating();
-#endif
 }
 
 // Review callback function to handle user confirmation or cancellation
@@ -404,12 +402,10 @@ uint16_t ux_approve_tx(bool fromPlugin) {
     explicit_bzero(&warning, sizeof(nbgl_warning_t));
     if (tmpContent.txContent.dataPresent) {
         warning.predefinedSet |= SET_BIT(BLIND_SIGNING_WARN);
-#ifdef HAVE_GATING_SUPPORT
         warning.predefinedSet |= SET_BIT(GATED_SIGNING_WARN);
         if (set_gating_warning() == false) {
             return SWO_INCORRECT_DATA;
         }
-#endif
     }
 #ifdef HAVE_TRANSACTION_CHECKS
     set_tx_simulation_warning();

src/nbgl/ui_sign_712.c

@@ -75,11 +75,9 @@ uint16_t ui_sign_712(e_eip712_filtering_mode filtering_mode) {
     ui_712_push_pairs();
 
     if (filtering_mode == EIP712_FILTERING_BASIC) {
-#ifdef HAVE_GATING_SUPPORT
         if (set_gating_warning() == false) {
             return SWO_INCORRECT_DATA;
         }
-#endif
     }
 
     ui_712_start_review(filtering_mode, TYPE_MESSAGE, ui_typed_message_review_choice);

src/shared_context.h

@@ -40,9 +40,7 @@ typedef struct internalStorage_t {
     // hidden setting (not shown in the UI)
     bool tx_check_opt_in;
 #endif
-#ifdef HAVE_GATING_SUPPORT
     uint8_t gating_counter;
-#endif
     bool eip7702_enable;
     bool displayHash;
     bool initialized;

tests/fuzzing/macros/add_macros.txt

@@ -3,5 +3,4 @@ HAVE_CHALLENGE_NO_CHECK
 HAVE_ETH2
 HAVE_TRANSACTION_CHECKS
 HAVE_SWAP
-HAVE_GATING_SUPPORT
 HAVE_BYPASS_SIGNATURES