Improved RLP elements parsing

Author: apaillier-ledger

src/features/signTx/ethUstream.c

@@ -97,7 +97,7 @@ bool copyTxData(txContext_t *context, uint8_t *out, uint32_t length) {
         return false;
     }
     if (out != NULL) {
-        memmove(out, context->workBuffer, length);
+        memmove(out + context->currentFieldPos, context->workBuffer, length);
     }
     if (!(context->processingField && context->fieldSingleByte)) {
         if (cx_hash_no_throw((cx_hash_t *) context->sha3,
@@ -215,9 +215,7 @@ static bool processStartGas(txContext_t *context) {
     if (context->currentFieldPos < context->currentFieldLength) {
         uint32_t copySize =
             MIN(context->commandLength, context->currentFieldLength - context->currentFieldPos);
-        if (copyTxData(context,
-                       context->content->startgas.value + context->currentFieldPos,
-                       copySize) == false) {
+        if (copyTxData(context, context->content->startgas.value, copySize) == false) {
             return false;
         }
     }
@@ -242,9 +240,7 @@ static bool processGasprice(txContext_t *context) {
     if (context->currentFieldPos < context->currentFieldLength) {
         uint32_t copySize =
             MIN(context->commandLength, context->currentFieldLength - context->currentFieldPos);
-        if (copyTxData(context,
-                       context->content->gasprice.value + context->currentFieldPos,
-                       copySize) == false) {
+        if (copyTxData(context, context->content->gasprice.value, copySize) == false) {
             return false;
         }
     }
@@ -264,9 +260,7 @@ static bool processValue(txContext_t *context) {
     if (context->currentFieldPos < context->currentFieldLength) {
         uint32_t copySize =
             MIN(context->commandLength, context->currentFieldLength - context->currentFieldPos);
-        if (copyTxData(context,
-                       context->content->value.value + context->currentFieldPos,
-                       copySize) == false) {
+        if (copyTxData(context, context->content->value.value, copySize) == false) {
             return false;
         }
     }
@@ -286,9 +280,7 @@ static bool processTo(txContext_t *context) {
     if (context->currentFieldPos < context->currentFieldLength) {
         uint32_t copySize =
             MIN(context->commandLength, context->currentFieldLength - context->currentFieldPos);
-        if (copyTxData(context,
-                       context->content->destination + context->currentFieldPos,
-                       copySize) == false) {
+        if (copyTxData(context, context->content->destination, copySize) == false) {
             return false;
         }
     }
@@ -381,8 +373,7 @@ static bool processV(txContext_t *context) {
             MIN(context->commandLength, context->currentFieldLength - context->currentFieldPos);
         // Make sure we do not copy more than the size of v.
         copySize = MIN(copySize, sizeof(context->content->v));
-        if (copyTxData(context, context->content->v + context->currentFieldPos, copySize) ==
-            false) {
+        if (copyTxData(context, context->content->v, copySize) == false) {
             return false;
         }
     }