On second thoughts, adding a dependency on pyscard was a bad idea

Author: yrichard-ledger

ledgerblue/comm.py

@@ -24,8 +24,6 @@
 
 import hid
 import nfc
-from smartcard.System import readers
-from smartcard.util import toBytes
 
 from .BleComm import BleDevice
 from .commException import CommException
@@ -66,10 +64,15 @@
 if "LEDGER_BLE_PROXY" in os.environ:
     BLE_PROXY = True
 
-# Force use of MCUPROXY if required
 PCSC = None
 if "PCSC" in os.environ and len(os.environ["PCSC"]) != 0:
     PCSC = os.environ["PCSC"]
+    try:
+        # Don't force all users to install pyscard
+        from smartcard.System import readers
+    except ImportError:
+        PCSC = None
+
 
 def get_possible_error_cause(sw):
     cause_map = {
@@ -295,7 +298,7 @@ def getDongle(debug=False):
         return DongleNFC(debug)
     elif BLE_PROXY:
         return DongleBLE(debug)
-    elif PCSC:
+    elif PCSC is not None:
         # Use the first pcsc reader with a card inserted
         connection = None
         for reader in readers():

pyproject.toml

@@ -43,8 +43,7 @@ dependencies = [
     "nfcpy>=1.0.4",
     "bleak>=0.20.1",
     "pycryptodome>=3.18.0",
-    "python-gnupg>=0.5.0",
-    "pyscard>=2.2.2"
+    "python-gnupg>=0.5.0"
 ]
 
 [tool.setuptools]