🔖 (release) [NO-ISSUE]: Release Signer ETH 1.6.0, Hyperliquid 1.0.2 (#1388)

Author: mbertin-ledger

.changeset/all-humans-relate.md

@@ -0,0 +1,5 @@
+---
+"@ledgerhq/device-signer-kit-zcash": minor
+---
+
+Scaffold for Zcash signer

.changeset/heavy-apple-write.md .changeset/heavy-mangos-write.md.changeset/heavy-apple-write.md renamed to .changeset/heavy-mangos-write.md

@@ -1,5 +1,5 @@
 ---
-"@ledgerhq/device-signer-kit-ethereum": patch
+"@ledgerhq/device-signer-kit-solana": patch
 ---
 
 Extract hardcoded appName string literals into shared APP_NAME constants

apps/clear-signing-tester/src/application/usecases/TestBatchContractFromFileUseCase.ts

@@ -3,6 +3,7 @@ import { inject, injectable } from "inversify";
 
 import { TYPES } from "@root/src/di/types";
 import { type ContractInput } from "@root/src/domain/models/ContractInput";
+import { SignableInputKind } from "@root/src/domain/models/SignableInputKind";
 import { type DataFileRepository } from "@root/src/domain/repositories/DataFileRepository";
 import { type TestResult } from "@root/src/domain/types/TestStatus";
 import {
@@ -100,6 +101,7 @@ export class TestBatchContractFromFileUseCase {
           const enhancedResults = batchResult.resultsTable.map((row) => {
             const testResult: TestResult = {
               input: {
+                kind: SignableInputKind.Transaction,
                 rawTx: "",
                 description: `[${contract.name}/${contract.owner}/Chain ${chainId}] ${row.Description}`,
               },
@@ -120,6 +122,7 @@ export class TestBatchContractFromFileUseCase {
           // Create error result
           const errorResult: TestResult = {
             input: {
+              kind: SignableInputKind.Transaction,
               rawTx: "",
               description: `${contract.name} (${contract.owner}) on chain ${chainId}`,
             },

apps/clear-signing-tester/src/application/usecases/TestBatchFromFileUseCase.ts

@@ -2,8 +2,7 @@ import { LoggerPublisherService } from "@ledgerhq/device-management-kit";
 import { inject, injectable } from "inversify";
 
 import { TYPES } from "@root/src/di/types";
-import { TransactionInput } from "@root/src/domain/models/TransactionInput";
-import { TypedDataInput } from "@root/src/domain/models/TypedDataInput";
+import { type SignableInput } from "@root/src/domain/models/SignableInput";
 import { type DataFileRepository } from "@root/src/domain/repositories/DataFileRepository";
 import { type DeviceRepository } from "@root/src/domain/repositories/DeviceRepository";
 import { TestResult } from "@root/src/domain/types/TestStatus";
@@ -33,9 +32,7 @@ export type TestFormattingConfig = {
  * Works with any data type T through the DataFileRepository interface
  */
 @injectable()
-export class TestBatchFromFileUseCase<
-  T extends TransactionInput | TypedDataInput,
-> {
+export class TestBatchFromFileUseCase<T extends SignableInput> {
   private readonly logger: LoggerPublisherService;
 
   constructor(

apps/clear-signing-tester/src/application/usecases/TestBatchTransactionFromFileUseCase.ts

@@ -32,7 +32,7 @@ export class TestBatchTransactionFromFileUseCase extends TestBatchFromFileUseCas
       transactionFileRepository,
       deviceRepository,
       (deviceRepo, input, derivationPath) =>
-        deviceRepo.performSignTransaction(input, derivationPath),
+        deviceRepo.performSign(input, derivationPath),
       {
         title: "📋 TRANSACTION TEST RESULTS",
         summaryTitle: "📊 TRANSACTION BATCH SUMMARY",

apps/clear-signing-tester/src/application/usecases/TestBatchTypedDataFromFileUseCase.ts

@@ -32,7 +32,7 @@ export class TestBatchTypedDataFromFileUseCase extends TestBatchFromFileUseCase<
       typedDataFileRepository,
       deviceRepository,
       (deviceRepo, input, derivationPath) =>
-        deviceRepo.performSignTypedData(input, derivationPath),
+        deviceRepo.performSign(input, derivationPath),
       {
         title: "📋 TYPED DATA TEST RESULTS",
         summaryTitle: "📊 TYPED DATA BATCH SUMMARY",

apps/clear-signing-tester/src/application/usecases/TestContractUseCase.ts

@@ -2,6 +2,8 @@ import { LoggerPublisherService } from "@ledgerhq/device-management-kit";
 import { inject, injectable } from "inversify";
 
 import { TYPES } from "@root/src/di/types";
+import { SignableInputKind } from "@root/src/domain/models/SignableInputKind";
+import { type TransactionInput } from "@root/src/domain/models/TransactionInput";
 import { type DeviceRepository } from "@root/src/domain/repositories/DeviceRepository";
 import { type TransactionContractRepository } from "@root/src/domain/repositories/TransactionContractRepository";
 import { TestResult } from "@root/src/domain/types/TestStatus";
@@ -49,15 +51,16 @@ export class TestContractUseCase {
     // Test each transaction
     for (const [index, tx] of txs.entries()) {
       const { selector, hash } = tx.transactionData;
-      const transaction = {
+      const transaction: TransactionInput = {
+        kind: SignableInputKind.Transaction,
         rawTx: tx.rawTx!,
         description: selector,
       };
 
       this.logger.info(`Testing transaction ${index + 1}/${txs.length}`);
 
       try {
-        const result = await this.deviceRepository.performSignTransaction(
+        const result = await this.deviceRepository.performSign(
           transaction,
           config.derivationPath,
         );

apps/clear-signing-tester/src/application/usecases/TestTransactionUseCase.ts

@@ -43,7 +43,7 @@ export class TestTransactionUseCase {
       data: { description: transaction.description },
     });
 
-    const result = await this.deviceRepository.performSignTransaction(
+    const result = await this.deviceRepository.performSign(
       transaction,
       config.derivationPath,
     );

apps/clear-signing-tester/src/application/usecases/TestTypedDataUseCase.ts

@@ -43,7 +43,7 @@ export class TestTypedDataUseCase {
       data: { typedData, description: "single typed data" },
     });
 
-    const result = await this.deviceRepository.performSignTypedData(
+    const result = await this.deviceRepository.performSign(
       typedData,
       config.derivationPath,
     );

apps/clear-signing-tester/src/cli/EthereumTransactionTesterCli.ts

@@ -18,6 +18,7 @@ import {
   type CliLogLevel,
 } from "@root/src/domain/models/config/LoggerConfig";
 import { type SpeculosConfig } from "@root/src/domain/models/config/SpeculosConfig";
+import { SignableInputKind } from "@root/src/domain/models/SignableInputKind";
 import { type ServiceController } from "@root/src/domain/services/ServiceController";
 import { ERC7730InterceptorService } from "@root/src/infrastructure/services/ERC7730InterceptorService";
 
@@ -35,6 +36,7 @@ export type CliConfig = {
   screenshotFolderPath?: string;
   customApp?: string;
   forcePull?: boolean;
+  externalSpeculos?: boolean;
 
   // config.signer
   skipCal?: boolean;
@@ -91,6 +93,7 @@ export class EthereumTransactionTesterCli {
         screenshotPath: config.screenshotFolderPath,
         customAppPath: config.customApp,
         forcePull: config.forcePull,
+        externalSpeculos: config.externalSpeculos,
       },
       signer: {
         originToken: process.env["GATING_TOKEN"] || "test-origin-token",
@@ -291,6 +294,11 @@ export class EthereumTransactionTesterCli {
         "Force pulling the Docker image even if it already exists locally",
         false,
       )
+      .option(
+        "--external-speculos",
+        "Skip Docker Speculos lifecycle and connect to an already-running Speculos instance on the configured --speculos-port.",
+        false,
+      )
       .option(
         "--log-level <level>",
         `Console log level: ${CLI_LOG_LEVELS.join(", ")} (default: info)`,
@@ -330,8 +338,16 @@ export class EthereumTransactionTesterCli {
 
     program.hook("preAction", async (_, command) => {
       const config = command.parent!.opts() as CliConfig;
-      // Set onlySpeculos flag when running start-speculos command
       config.onlySpeculos = command.name() === "start-speculos";
+
+      if (config.onlySpeculos && config.externalSpeculos) {
+        throw new Error(
+          "--external-speculos cannot be used with start-speculos. " +
+            "Use start-speculos to let cs-tester manage Speculos, " +
+            "or use other commands with --external-speculos to connect to an already-running instance.",
+        );
+      }
+
       cli = new EthereumTransactionTesterCli(config);
       await cli.initialize();
     });
@@ -433,6 +449,7 @@ export class EthereumTransactionTesterCli {
 
     const result = await testTransactionUseCase.execute(
       {
+        kind: SignableInputKind.Transaction,
         rawTx: transaction,
         description: "Single transaction test",
       },
@@ -475,7 +492,11 @@ export class EthereumTransactionTesterCli {
     );
 
     const result = await testTypedDataUseCase.execute(
-      { data, description: "single typed data" },
+      {
+        kind: SignableInputKind.TypedData,
+        data,
+        description: "single typed data",
+      },
       { derivationPath: this.config.derivationPath },
     );