🔖 (release) [NO-ISSUE]: New release incoming: DMK 1.4.1, Signer ETH 1.15.1, Signer Zcash 0.2.0 (#1485)

Author: aussedatlo

.changeset/afraid-banks-sort.md

@@ -0,0 +1,5 @@
+---
+"@ledgerhq/device-signer-kit-aleo": minor
+---
+
+Add support for signing nested calls

.changeset/all-humans-relate.md

@@ -69,7 +69,7 @@ git commit -m "🔧 (release): Reset private packages after release"
 
 ```bash
 git push -u origin chore/backmerge
-gh pr create -B develop --title "🔀 (release) [NO-ISSUE]: Backmerge release into develop" -T .github/pull_request_backmerge_template.md
+gh pr create -B develop --title "🔀 (release) [NO-ISSUE]: Backmerge release into develop" -F .github/pull_request_backmerge_template.md
 ```
 
 - Report the PR URL to the user.

.changeset/bright-moles-fetch.md

@@ -39,11 +39,11 @@ Here you can find a summary of all the libraries that compose the DMK.
 
 | Device Management Kit (DMK) | NPM                                                                                              | Version |
 | --------------------------- | ------------------------------------------------------------------------------------------------ | ------- |
-| Device Management Kit       | [@ledgerhq/device-management-kit](https://www.npmjs.com/package/@ledgerhq/device-management-kit) | 1.4.0   |
+| Device Management Kit       | [@ledgerhq/device-management-kit](https://www.npmjs.com/package/@ledgerhq/device-management-kit) | 1.4.1   |
 
 | Signers & Trusted App Kit | NPM                                                                                                                                                | Version |
 | ------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------- | ------- |
-| Device Signer Ethereum    | [@ledgerhq/device-signer-kit-ethereum](https://www.npmjs.com/package/@ledgerhq/device-signer-kit-ethereum)                                         | 1.15.0  |
+| Device Signer Ethereum    | [@ledgerhq/device-signer-kit-ethereum](https://www.npmjs.com/package/@ledgerhq/device-signer-kit-ethereum)                                         | 1.15.1  |
 | Device Signer Bitcoin     | [@ledgerhq/device-signer-kit-bitcoin](https://www.npmjs.com/package/@ledgerhq/device-signer-kit-bitcoin)                                           | 1.3.0   |
 | Device Signer Solana      | [@ledgerhq/device-signer-kit-solana](https://www.npmjs.com/package/@ledgerhq/device-signer-kit-solana)                                             | 1.8.0   |
 | Device Signer Cosmos      | [@ledgerhq/device-signer-kit-cosmos](https://www.npmjs.com/package/@ledgerhq/device-signer-kit-cosmos)                                             | 1.0.0   |

.changeset/crazy-pigs-rhyme.md

@@ -3,6 +3,7 @@
 This module provides the implementation of the Ledger zcash signer of the Device Management Kit. It enables interaction with the zcash application on a Ledger device including:
 
 - Retrieving the zcash address using a given derivation path
+- Retrieving the zcash full viewing key (UFVK or Orchard FVK)
 - Signing a zcash transaction
 - Signing a message displayed on a Ledger device
 - Retrieving the app configuration
@@ -15,8 +16,9 @@ This module provides the implementation of the Ledger zcash signer of the Device
 4. [Use Cases](#-use-cases)
    - [Get App Configuration](#use-case-1-get-app-configuration)
    - [Get Address](#use-case-2-get-address)
-   - [Sign Transaction](#use-case-3-sign-transaction)
-   - [Sign Message](#use-case-4-sign-message)
+   - [Get Full Viewing Key](#use-case-3-get-full-viewing-key)
+   - [Sign Transaction](#use-case-4-sign-transaction)
+   - [Sign Message](#use-case-5-sign-message)
 5. [Observable Behavior](#-observable-behavior)
 6. [Example](#-example)
 
@@ -44,7 +46,7 @@ const signerZcash = new SignerZcashBuilder({ dmk, sessionId }).build();
 
 ## 🔹 Use Cases
 
-The `SignerZcashBuilder.build()` method will return a `SignerZcash` instance that exposes 4 dedicated methods, each of which calls an independent use case. Each use case will return an object that contains an observable and a method called `cancel`.
+The `SignerZcashBuilder.build()` method will return a `SignerZcash` instance that exposes 5 dedicated methods, each of which calls an independent use case. Each use case will return an object that contains an observable and a method called `cancel`.
 
 ---
 
@@ -119,7 +121,63 @@ type GetAddressCommandResponse = {
 
 ---
 
-### Use Case 3: Sign Transaction
+### Use Case 3: Get Full Viewing Key
+
+This method allows users to retrieve the zcash full viewing key based on a given ZIP-32 account `derivationPath`.
+
+```typescript
+const { observable, cancel } = signerZcash.getFullViewingKey(
+  derivationPath,
+  options,
+);
+```
+
+#### **Parameters**
+
+- `derivationPath`
+
+  - **Required**
+  - **Type:** `string` (e.g., `"32'/133'/0'"`)
+  - The account-level ZIP-32 derivation path used for the zcash full viewing key.
+
+- `options`
+
+  - Optional
+  - Type: `FullViewingKeyOptions`
+
+    ```typescript
+    type FullViewingKeyOptions = {
+      mode?: "ufvk" | "orchardFvk";
+      skipOpenApp?: boolean;
+    };
+    ```
+
+  - `mode`: Optional export mode. Defaults to `"ufvk"`.
+    - `"ufvk"` returns the Unified Full Viewing Key as a UTF-8 string.
+    - `"orchardFvk"` returns the raw Orchard Full Viewing Key bytes (`Uint8Array`).
+  - `skipOpenApp`: An optional boolean indicating whether to skip opening the zcash app automatically (`true`) or not (`false`).
+
+#### **Returns**
+
+- `observable` Emits DeviceActionState updates, including the following details:
+
+```typescript
+type GetFullViewingKeyResult =
+  | {
+      mode: "ufvk";
+      fullViewingKey: string;
+    }
+  | {
+      mode: "orchardFvk";
+      fullViewingKey: Uint8Array;
+    };
+```
+
+- `cancel` A function to cancel the action on the Ledger device.
+
+---
+
+### Use Case 4: Sign Transaction
 
 This method allows users to sign a zcash transaction.
 
@@ -174,7 +232,7 @@ type Signature = {
 
 ---
 
-### Use Case 4: Sign Message
+### Use Case 5: Sign Message
 
 This method allows users to sign a text string that is displayed on Ledger devices.
 

.changeset/salty-pumas-rush.md

@@ -12,6 +12,9 @@ import {
   type SignFeeIntentDAError,
   type SignFeeIntentDAIntermediateValue,
   type SignFeeIntentDAOutput,
+  type SignNestedCallDAError,
+  type SignNestedCallDAIntermediateValue,
+  type SignNestedCallDAOutput,
   type SignRootIntentDAError,
   type SignRootIntentDAIntermediateValue,
   type SignRootIntentDAOutput,
@@ -69,7 +72,7 @@ export const SignerAleoView: React.FC<{ sessionId: string }> = ({
           });
         },
         initialValues: {
-          derivationPath: "44'/683'/0",
+          derivationPath: "44'/683'/0'/0'",
           checkOnDevice: false,
           skipOpenApp: false,
         },
@@ -134,7 +137,7 @@ export const SignerAleoView: React.FC<{ sessionId: string }> = ({
           });
         },
         initialValues: {
-          derivationPath: "44'/683'/0",
+          derivationPath: "44'/683'/0'/0'",
           rootIntent: "",
           skipOpenApp: false,
         },
@@ -186,6 +189,44 @@ export const SignerAleoView: React.FC<{ sessionId: string }> = ({
         SignFeeIntentDAError,
         SignFeeIntentDAIntermediateValue
       >,
+      {
+        title: "Sign Nested Call",
+        description: "Sign a nested call with the device",
+        executeDeviceAction: ({ nestedCallRequest, skipOpenApp }) => {
+          if (!signer) {
+            throw new Error("Signer not initialized");
+          }
+          // Convert hex string to Uint8Array
+          const nestedCallRequestBytes = nestedCallRequest.startsWith("0x")
+            ? new Uint8Array(
+                nestedCallRequest
+                  .slice(2)
+                  .match(/.{1,2}/g)
+                  ?.map((byte) => Number.parseInt(byte, 16)) ?? [],
+              )
+            : new Uint8Array(
+                nestedCallRequest
+                  .match(/.{1,2}/g)
+                  ?.map((byte) => Number.parseInt(byte, 16)) ?? [],
+              );
+          return signer.signNestedCall(nestedCallRequestBytes, {
+            skipOpenApp,
+          });
+        },
+        initialValues: {
+          nestedCallRequest: "",
+          skipOpenApp: false,
+        },
+        deviceModelId,
+      } satisfies DeviceActionProps<
+        SignNestedCallDAOutput,
+        {
+          nestedCallRequest: string;
+          skipOpenApp?: boolean;
+        },
+        SignNestedCallDAError,
+        SignNestedCallDAIntermediateValue
+      >,
     ],
     [deviceModelId, signer],
   );

.cursor/skills/backmerge/SKILL.md

@@ -7,6 +7,9 @@ import {
   type GetAppConfigDAError,
   type GetAppConfigDAIntermediateValue,
   type GetAppConfigDAOutput,
+  type GetFullViewingKeyDAError,
+  type GetFullViewingKeyDAIntermediateValue,
+  type GetFullViewingKeyDAOutput,
   type GetTrustedInputDAError,
   type GetTrustedInputDAIntermediateValue,
   type GetTrustedInputDAOutput,
@@ -16,13 +19,21 @@ import {
   type SignTransactionDAError,
   type SignTransactionDAIntermediateValue,
   type SignTransactionDAOutput,
+  type ZcashFullViewingKeyMode,
 } from "@ledgerhq/device-signer-kit-zcash";
 
 import { DeviceActionsList } from "@/components/DeviceActionsView/DeviceActionsList";
 import { type DeviceActionProps } from "@/components/DeviceActionsView/DeviceActionTester";
+import { type ValueSelector } from "@/components/Form";
+import { type FieldType } from "@/hooks/useForm";
 import { useDmk } from "@/providers/DeviceManagementKitProvider";
 import { useSignerZcash } from "@/providers/SignerZcashProvider";
 
+const fullViewingKeyModeOptions: ValueSelector<FieldType>["mode"] = [
+  { label: "UFVK (string, P2=0x00)", value: "ufvk" },
+  { label: "Orchard FVK (96 raw bytes, P2=0x01)", value: "orchardFvk" },
+];
+
 export const SignerZcashView: React.FC<{ sessionId: string }> = ({
   sessionId,
 }) => {
@@ -85,6 +96,43 @@ export const SignerZcashView: React.FC<{ sessionId: string }> = ({
         GetAddressDAError,
         GetAddressDAIntermediateValue
       >,
+      {
+        title: "Get Full Viewing Key",
+        description:
+          "Exports a full viewing key (UFVK/FVK) from the device. It does not spend funds, but it allows watching shielded balance and activity for this derivation — treat it as highly sensitive secret material. Do not share, log, or commit sample output; use only for local SDK testing.",
+        executeDeviceAction: ({ derivationPath, mode, skipOpenApp }) => {
+          if (!signer) {
+            throw new Error("Signer not initialized");
+          }
+          const resolvedMode: ZcashFullViewingKeyMode =
+            mode === "orchardFvk" ? "orchardFvk" : "ufvk";
+          return signer.getFullViewingKey(derivationPath, {
+            mode: resolvedMode,
+            skipOpenApp,
+          });
+        },
+        initialValues: {
+          derivationPath: "32'/133'/0'",
+          mode: "ufvk",
+          skipOpenApp: false,
+        },
+        valueSelector: { mode: fullViewingKeyModeOptions },
+        labelSelector: {
+          mode: "Export mode (GET_VK P2)",
+          derivationPath: "Derivation path",
+          skipOpenApp: "Skip open app",
+        },
+        deviceModelId,
+      } satisfies DeviceActionProps<
+        GetFullViewingKeyDAOutput,
+        {
+          derivationPath: string;
+          mode: ZcashFullViewingKeyMode;
+          skipOpenApp?: boolean;
+        },
+        GetFullViewingKeyDAError,
+        GetFullViewingKeyDAIntermediateValue
+      >,
       {
         title: "Sign Transaction",
         description: "Sign a transaction with the device",