✨ (ledger-button): Use Fiat detailed endpoint (#440)

Author: pvautherin-ledger

.nx/version-plans/version-plan-1778583950636.md

@@ -0,0 +1,6 @@
+---
+"@ledgerhq/ledger-wallet-provider-core": minor
+"@ledgerhq/ledger-wallet-provider": minor
+---
+
+Use Fiat detailed endpoint

packages/ledger-button-core/src/api/LedgerButtonCore.ts

@@ -15,10 +15,6 @@ import { SignTransactionParams } from "./model/signing/SignTransactionParams.js"
 import { SignTypedMessageParams } from "./model/signing/SignTypedMessageParams.js";
 import { getChainIdFromCurrencyId } from "./utils/index.js";
 import { accountModuleTypes } from "../internal/account/accountModuleTypes.js";
-import {
-  DEFAULT_FIAT_CURRENCY,
-  SUPPORTED_FIAT_CURRENCIES,
-} from "../internal/account/model/constant.js";
 import {
   Account,
   type AccountService,
@@ -40,6 +36,10 @@ import { consentModuleTypes } from "../internal/consent/consentModuleTypes.js";
 import { type ConsentService } from "../internal/consent/ConsentService.js";
 import { contextModuleTypes } from "../internal/context/contextModuleTypes.js";
 import { ContextService } from "../internal/context/ContextService.js";
+import { DEFAULT_FIAT_CURRENCY } from "../internal/currency/constant.js";
+import { currencyModuleTypes } from "../internal/currency/currencyModuleTypes.js";
+import type { FiatCurrency } from "../internal/currency/datasource/fiatCurrencyTypes.js";
+import type { CurrencyService } from "../internal/currency/service/CurrencyService.js";
 import { dAppConfigModuleTypes } from "../internal/dAppConfig/di/dAppConfigModuleTypes.js";
 import { type DAppConfigService } from "../internal/dAppConfig/service/DAppConfigService.js";
 import { deviceModuleTypes } from "../internal/device/deviceModuleTypes.js";
@@ -170,19 +170,9 @@ export class LedgerButtonCore {
       .get<IsMobileUseCase>(platformModuleTypes.IsMobileUseCase)
       .execute();
 
-    const storedFiatCurrencyMaybe = await this.container
-      .get<StorageService>(storageModuleTypes.StorageService)
-      .getPreferredFiatCurrency();
-
-    const storedFiatCurrency = storedFiatCurrencyMaybe.orDefault(
-      DEFAULT_FIAT_CURRENCY,
-    );
-    const preferredFiatCurrency = (
-      SUPPORTED_FIAT_CURRENCIES as readonly string[]
-    ).includes(storedFiatCurrency)
-      ? storedFiatCurrency
-      : DEFAULT_FIAT_CURRENCY;
-
+    const preferredFiatCurrency = await this.container
+      .get<CurrencyService>(currencyModuleTypes.CurrencyService)
+      .initialize();
     this._contextService.onEvent({
       type: "initialize_context",
       context: {
@@ -526,10 +516,16 @@ export class LedgerButtonCore {
     );
   }
 
+  getSupportedFiatCurrencies(): FiatCurrency[] {
+    return this.container
+      .get<CurrencyService>(currencyModuleTypes.CurrencyService)
+      .getSupportedFiatCurrencies();
+  }
+
   async savePreferredFiatCurrency(currency: string): Promise<void> {
     this._logger.debug("Saving preferred fiat currency", { currency });
     await this.container
-      .get<StorageService>(storageModuleTypes.StorageService)
+      .get<CurrencyService>(currencyModuleTypes.CurrencyService)
       .savePreferredFiatCurrency(currency);
     this._contextService.onEvent({
       type: "preferred_fiat_currency_changed",

packages/ledger-button-core/src/api/model/index.ts

@@ -8,6 +8,7 @@ export type {
   Network,
   Token,
 } from "../../internal/account/service/AccountService.js";
+export type { FiatCurrency } from "../../internal/currency/datasource/fiatCurrencyTypes.js";
 export type { PendingTransaction } from "../../internal/pending-transaction/model/PendingTransaction.js";
 export type {
   TransactionHistoryItem,

packages/ledger-button-core/src/internal/account/model/constant.ts

@@ -8,7 +8,7 @@ import {
   type TokenBalance,
 } from "../../balance/model/types.js";
 import type { BalanceService } from "../../balance/service/BalanceService.js";
-import { formatBalance } from "../../currency/formatCurrency.js";
+import { formatBalance } from "../../currency/currencyUtils.js";
 import { getChainIdFromCurrencyId } from "../../evm-provider/utils/chainUtils.js";
 import { loggerModuleTypes } from "../../logger/loggerModuleTypes.js";
 import type { LoggerPublisher } from "../../logger/service/LoggerPublisher.js";

packages/ledger-button-core/src/internal/account/use-case/HydrateAccountWithBalanceUseCase.ts

@@ -36,7 +36,7 @@ function createMockContext(
     welcomeScreenCompleted: false,
     hasTrackingConsent: undefined,
     isMobilePlatform: false,
-    preferredFiatCurrency: "usd",
+    preferredFiatCurrency: "USD",
     ...overrides,
   };
 }
@@ -99,7 +99,7 @@ describe("HydrateAccountWithFiatUseCase", () => {
       getContext: vi.fn(),
       onEvent: vi.fn(),
     };
-    setPreferredFiatCurrency("usd");
+    setPreferredFiatCurrency("USD");
 
     useCase = new HydrateAccountWithFiatUseCase(
       createMockLoggerFactory(),
@@ -108,7 +108,7 @@ describe("HydrateAccountWithFiatUseCase", () => {
     );
 
     vi.clearAllMocks();
-    setPreferredFiatCurrency("usd");
+    setPreferredFiatCurrency("USD");
   });
 
   describe("execute", () => {
@@ -167,7 +167,7 @@ describe("HydrateAccountWithFiatUseCase", () => {
         });
         expect(
           mockCounterValueDataSource.getCounterValues,
-        ).toHaveBeenCalledWith(["ethereum"], "usd");
+        ).toHaveBeenCalledWith(["ethereum"], "USD");
       });
     });
 
@@ -212,7 +212,7 @@ describe("HydrateAccountWithFiatUseCase", () => {
         });
         expect(
           mockCounterValueDataSource.getCounterValues,
-        ).toHaveBeenCalledWith(["ethereum"], "usd");
+        ).toHaveBeenCalledWith(["ethereum"], "USD");
       });
 
       it("should use the preferred fiat currency from context", async () => {
@@ -222,7 +222,7 @@ describe("HydrateAccountWithFiatUseCase", () => {
         mockCounterValueDataSource.getCounterValues.mockResolvedValue(
           Right(counterValueResult),
         );
-        setPreferredFiatCurrency("eur");
+        setPreferredFiatCurrency("EUR");
 
         const result = await useCase.execute(baseAccount);
 
@@ -232,7 +232,7 @@ describe("HydrateAccountWithFiatUseCase", () => {
         });
         expect(
           mockCounterValueDataSource.getCounterValues,
-        ).toHaveBeenCalledWith(["ethereum"], "eur");
+        ).toHaveBeenCalledWith(["ethereum"], "EUR");
       });
 
       it("should handle decimal balance values", async () => {
@@ -275,7 +275,7 @@ describe("HydrateAccountWithFiatUseCase", () => {
         });
         expect(
           mockCounterValueDataSource.getCounterValues,
-        ).toHaveBeenCalledWith(["ethereum", "ethereum/erc20/usdc"], "usd");
+        ).toHaveBeenCalledWith(["ethereum", "ethereum/erc20/usdc"], "USD");
       });
     });
   });

packages/ledger-button-core/src/internal/account/use-case/hydrateAccountWithFiatUseCase.test.ts

@@ -32,14 +32,12 @@ export class HydrateAccountWithFiatUseCase {
   }
 
   async execute(account: Account): Promise<AccountWithFiat> {
-    const targetCurrency =
-      this.contextService.getContext().preferredFiatCurrency;
+    const currency = this.contextService.getContext().preferredFiatCurrency;
     this.logHydrationStart(account);
 
     const balance = account.balance ?? "0";
     const balanceNum = this.parseBalance(balance);
     if (Number.isNaN(balanceNum) || balanceNum === 0) {
-      const currency = targetCurrency.toUpperCase();
       return enrichWithLoadingStates({
         ...account,
         fiatBalance: { value: "0.00", currency },
@@ -49,7 +47,7 @@ export class HydrateAccountWithFiatUseCase {
 
     const counterValuesResult = await this.fetchCounterValues(
       account,
-      targetCurrency,
+      currency,
     );
 
     return counterValuesResult.caseOf<AccountWithFiat>({
@@ -62,8 +60,6 @@ export class HydrateAccountWithFiatUseCase {
         });
       },
       Right: (counterValues) => {
-        const currency = targetCurrency.toUpperCase();
-
         const accountFiatBalance = this.calculateAccountFiat(
           balance,
           counterValues[0]?.rate,

packages/ledger-button-core/src/internal/account/use-case/hydrateAccountWithFiatUseCase.ts

@@ -1,4 +1,4 @@
-import { formatBalance } from "../../currency/formatCurrency.js";
+import { formatBalance } from "../../currency/currencyUtils.js";
 
 export type AccountBalance = {
   nativeBalance: NativeBalance;

packages/ledger-button-core/src/internal/balance/model/types.ts

@@ -1,7 +1,7 @@
 import { beforeEach, describe, expect, it, test, vi } from "vitest";
 
-import { DEFAULT_FIAT_CURRENCY } from "../account/model/constant.js";
 import type { Account } from "../account/service/AccountService.js";
+import { DEFAULT_FIAT_CURRENCY } from "../currency/constant.js";
 import type { Device } from "../device/model/Device.js";
 import * as chainUtils from "../evm-provider/utils/chainUtils.js";
 import type { LoggerPublisher } from "../logger/service/LoggerPublisher.js";
@@ -319,7 +319,9 @@ describe("DefaultContextService", () => {
 
     describe("preferred_fiat_currency_changed event", () => {
       it("should set preferredFiatCurrency to the given currency", () => {
-        expect(service.getContext().preferredFiatCurrency).toBe(DEFAULT_FIAT_CURRENCY);
+        expect(service.getContext().preferredFiatCurrency).toBe(
+          DEFAULT_FIAT_CURRENCY,
+        );
 
         service.onEvent({
           type: "preferred_fiat_currency_changed",

packages/ledger-button-core/src/internal/context/DefaultContextService.test.ts

@@ -3,11 +3,11 @@ import { BehaviorSubject, Observable } from "rxjs";
 
 import { type ContextEvent } from "./model/ContextEvent.js";
 import type { ButtonCoreContext } from "../../api/model/ButtonCoreContext.js";
-import { DEFAULT_FIAT_CURRENCY } from "../account/model/constant.js";
 import {
   type Account,
   type DetailedAccount,
 } from "../account/service/AccountService.js";
+import { DEFAULT_FIAT_CURRENCY } from "../currency/constant.js";
 import {
   getChainIdFromCurrencyId,
   getCurrencyIdFromChainId,