Merge pull request #14922 from LedgerHQ/bugfix/market-currency-id-resilience

fix(common): improve resilience when market API returns no data for currency

Author: gre-ledger

.changeset/market-currency-id-resilience.md

@@ -0,0 +1,5 @@
+---
+"@ledgerhq/live-common": minor
+---
+
+Improve resilience when market API returns no data for a currency id (e.g. unknown or unsupported coin). Prevents "Cannot read property 'id' of undefined" crash in getCurrencyData; query now returns undefined instead of throwing.

libs/ledger-live-common/src/market/hooks/__tests__/useCurrencyData.test.ts

@@ -4,6 +4,7 @@
  */
 
 import { renderHook, waitFor } from "@testing-library/react";
+import { http, HttpResponse } from "msw";
 import { useCurrencyData } from "../useMarketDataProvider";
 import { countervaluesApi } from "../../state-manager/countervaluesApi";
 import { server } from "@tests/server";
@@ -96,4 +97,19 @@ describe("useCurrencyData", () => {
 
     unmount();
   });
+
+  it("should return undefined data when API returns empty array (id not resolving to a currency)", async () => {
+    server.use(http.get("*/v3/markets", () => HttpResponse.json([])));
+    const wrapper = createWrapper(store);
+    const { result, unmount } = renderHook(
+      () => useCurrencyData({ id: "unknown-currency", counterCurrency: "usd" }),
+      { wrapper },
+    );
+
+    await waitFor(() => expect(result.current.isSuccess).toBe(true));
+    expect(result.current.data).toBeUndefined();
+    expect(result.current.isError).toBe(false);
+
+    unmount();
+  });
 });

libs/ledger-live-common/src/market/state-manager/countervaluesApi.ts

@@ -37,7 +37,7 @@ export const countervaluesApi = createApi({
       transformResponse: (response: MarketItemResponse[]) => response.map(formatPerformer),
       keepUnusedDataFor: REFETCH_TIME_ONE_MINUTE / 1000,
     }),
-    getCurrencyData: build.query<MarketCurrencyData, MarketCurrencyRequestParams>({
+    getCurrencyData: build.query<MarketCurrencyData | undefined, MarketCurrencyRequestParams>({
       query: ({ id, counterCurrency }) => ({
         url: "/v3/markets",
         params: {
@@ -48,7 +48,8 @@ export const countervaluesApi = createApi({
         },
       }),
       providesTags: [MarketDataTags.CurrencyData],
-      transformResponse: (response: MarketItemResponse[]) => format(response[0]),
+      transformResponse: (response: MarketItemResponse[]) =>
+        response?.[0] ? format(response[0]) : undefined,
       keepUnusedDataFor: (REFETCH_TIME_ONE_MINUTE * BASIC_REFETCH) / 1000,
     }),
   }),