Merge pull request #14107 from LedgerHQ/feat/concordium-onboarding

feat(concordium): desktop onboarding ui

Author: lysyi3m

.changeset/kind-hotels-attack.md

@@ -0,0 +1,7 @@
+---
+"ledger-live-desktop": minor
+"@ledgerhq/live-common": minor
+"@ledgerhq/live-countervalues": minor
+---
+
+Concordium integration with account onboarding UI

apps/ledger-live-desktop/jest.polyfills.js

@@ -40,8 +40,20 @@ Object.defineProperties(globalThis, {
   MessagePort: { value: MessagePort },
   BroadcastChannel: {
     value: class {
-      postMessage() {}
+      _listeners = {};
+      postMessage(data) {
+        const event = { data };
+        (this._listeners["message"] || []).forEach(fn => fn(event));
+      }
       close() {}
+      addEventListener(type, fn) {
+        if (!this._listeners[type]) this._listeners[type] = [];
+        this._listeners[type].push(fn);
+      }
+      removeEventListener(type, fn) {
+        if (!this._listeners[type]) return;
+        this._listeners[type] = this._listeners[type].filter(l => l !== fn);
+      }
       onmessage = null;
       onmessageerror = null;
     },

apps/ledger-live-desktop/package.json

@@ -62,6 +62,7 @@
     "@ledgerhq/client-ids": "workspace:*",
     "@ledgerhq/coin-bitcoin": "workspace:^",
     "@ledgerhq/coin-canton": "workspace:^",
+    "@ledgerhq/coin-concordium": "workspace:^",
     "@ledgerhq/coin-cosmos": "workspace:^",
     "@ledgerhq/coin-evm": "workspace:^",
     "@ledgerhq/coin-filecoin": "workspace:^",

apps/ledger-live-desktop/src/config/urls.ts

@@ -223,6 +223,11 @@ export const urls = {
   aleo: {
     viewKeyLearnMore: "", // TODO: waiting for https://ledgerhq.atlassian.net/browse/LIVE-26269
   },
+  concordium: {
+    learnMore: "https://support.ledger.com/article/Concordium-CCD",
+    appStore: "https://apps.apple.com/app/concordium-id/id6746754485",
+    playStore: "https://play.google.com/store/apps/details?id=com.idwallet.app",
+  },
 };
 
 export const vaultSigner = {

apps/ledger-live-desktop/src/mvvm/features/AddAccountDrawer/screens/ScanAccounts/hooks/concordium/useConcordiumCreatableAccounts.test.ts

@@ -0,0 +1,186 @@
+import { ConcordiumAccount } from "@ledgerhq/coin-concordium/types";
+import { createEmptyHistoryCache } from "@ledgerhq/coin-framework/account/balanceHistoryCache";
+import {
+  getDerivationModesForCurrency,
+  getDerivationScheme,
+  runDerivationScheme,
+} from "@ledgerhq/coin-framework/derivation";
+import { getCryptoCurrencyById } from "@ledgerhq/cryptoassets";
+import { Account } from "@ledgerhq/types-live";
+import BigNumber from "bignumber.js";
+import { renderHook } from "tests/testSetup";
+import { useConcordiumCreatableAccounts } from "./useConcordiumCreatableAccounts";
+
+const createMockAccount = (
+  id: string,
+  currencyId: string,
+  used: boolean = false,
+  isOnboarded: boolean = false,
+): Account => {
+  const currency = getCryptoCurrencyById(currencyId);
+  const derivationMode = getDerivationModesForCurrency(currency)[0];
+  const scheme = getDerivationScheme({ derivationMode, currency });
+  const baseAccount: Account = {
+    id,
+    type: "Account",
+    used,
+    currency,
+    derivationMode,
+    index: 0,
+    freshAddress: "test_address",
+    freshAddressPath: runDerivationScheme(scheme, currency, {
+      account: 0,
+      node: 0,
+      address: 0,
+    }),
+    creationDate: new Date(),
+    lastSyncDate: new Date(),
+    balance: new BigNumber(0),
+    spendableBalance: new BigNumber(0),
+    seedIdentifier: "test_seed",
+    blockHeight: 0,
+    operationsCount: 0,
+    operations: [],
+    pendingOperations: [],
+    balanceHistoryCache: createEmptyHistoryCache(),
+    swapHistory: [],
+    subAccounts: [],
+  };
+
+  if (currency.family === "concordium") {
+    return {
+      ...baseAccount,
+      concordiumResources: {
+        isOnboarded,
+        credId: "test_cred_id",
+        publicKey: "test_public_key",
+        identityIndex: 0,
+        credNumber: 0,
+        ipIdentity: 0,
+      },
+    } as ConcordiumAccount;
+  }
+
+  return baseAccount;
+};
+
+describe("useConcordiumCreatableAccounts", () => {
+  it("should return false when no Concordium accounts are present", () => {
+    const scannedAccounts: Account[] = [createMockAccount("1", "bitcoin", false)];
+    const selectedIds = ["1"];
+
+    const { result } = renderHook(() =>
+      useConcordiumCreatableAccounts({ scannedAccounts, selectedIds }),
+    );
+
+    expect(result.current.hasConcordiumCreatableAccounts).toBe(false);
+    expect(result.current.selectedConcordiumAccounts).toEqual([]);
+  });
+
+  it("should return false when Concordium accounts are onboarded", () => {
+    const scannedAccounts: Account[] = [createMockAccount("1", "concordium", false, true)];
+    const selectedIds = ["1"];
+
+    const { result } = renderHook(() =>
+      useConcordiumCreatableAccounts({ scannedAccounts, selectedIds }),
+    );
+
+    expect(result.current.hasConcordiumCreatableAccounts).toBe(false);
+    expect(result.current.selectedConcordiumAccounts).toHaveLength(1);
+  });
+
+  it("should return false when Concordium accounts are not selected", () => {
+    const scannedAccounts: Account[] = [createMockAccount("1", "concordium", false)];
+    const selectedIds: string[] = [];
+
+    const { result } = renderHook(() =>
+      useConcordiumCreatableAccounts({ scannedAccounts, selectedIds }),
+    );
+
+    expect(result.current.hasConcordiumCreatableAccounts).toBe(false);
+    expect(result.current.selectedConcordiumAccounts).toEqual([]);
+  });
+
+  it("should return true when Concordium creatable accounts are selected", () => {
+    const scannedAccounts: Account[] = [createMockAccount("1", "concordium", false, false)];
+    const selectedIds = ["1"];
+
+    const { result } = renderHook(() =>
+      useConcordiumCreatableAccounts({ scannedAccounts, selectedIds }),
+    );
+
+    expect(result.current.hasConcordiumCreatableAccounts).toBe(true);
+    expect(result.current.selectedConcordiumAccounts).toHaveLength(1);
+    expect(result.current.selectedConcordiumAccounts.map(a => a.id)).toEqual(["1"]);
+  });
+
+  it("should handle empty scanned accounts array", () => {
+    const scannedAccounts: Account[] = [];
+    const selectedIds: string[] = [];
+
+    const { result } = renderHook(() =>
+      useConcordiumCreatableAccounts({ scannedAccounts, selectedIds }),
+    );
+
+    expect(result.current.hasConcordiumCreatableAccounts).toBe(false);
+    expect(result.current.selectedConcordiumAccounts).toEqual([]);
+  });
+
+  it("should update results when props change", () => {
+    const initialScannedAccounts: Account[] = [createMockAccount("1", "concordium", false, false)];
+    const initialSelectedIds = ["1"];
+
+    const { result, rerender } = renderHook(
+      ({ scannedAccounts, selectedIds }) =>
+        useConcordiumCreatableAccounts({ scannedAccounts, selectedIds }),
+      {
+        initialProps: {
+          scannedAccounts: initialScannedAccounts,
+          selectedIds: initialSelectedIds,
+        },
+      },
+    );
+
+    expect(result.current.hasConcordiumCreatableAccounts).toBe(true);
+
+    // Update to deselect the account
+    rerender({
+      scannedAccounts: initialScannedAccounts,
+      selectedIds: [],
+    });
+
+    expect(result.current.hasConcordiumCreatableAccounts).toBe(false);
+    expect(result.current.selectedConcordiumAccounts).toEqual([]);
+  });
+
+  it("should include both onboarded and creatable accounts in selectedConcordiumAccounts", () => {
+    const scannedAccounts: Account[] = [
+      createMockAccount("1", "concordium", false, true), // onboarded
+      createMockAccount("2", "concordium", false, false), // creatable
+    ];
+    const selectedIds = ["1", "2"];
+
+    const { result } = renderHook(() =>
+      useConcordiumCreatableAccounts({ scannedAccounts, selectedIds }),
+    );
+
+    expect(result.current.hasConcordiumCreatableAccounts).toBe(true);
+    expect(result.current.selectedConcordiumAccounts).toHaveLength(2);
+  });
+
+  it("should filter out non-Concordium accounts from selectedConcordiumAccounts", () => {
+    const scannedAccounts: Account[] = [
+      createMockAccount("1", "concordium", false, false),
+      createMockAccount("2", "bitcoin", false),
+    ];
+    const selectedIds = ["1", "2"];
+
+    const { result } = renderHook(() =>
+      useConcordiumCreatableAccounts({ scannedAccounts, selectedIds }),
+    );
+
+    expect(result.current.hasConcordiumCreatableAccounts).toBe(true);
+    expect(result.current.selectedConcordiumAccounts).toHaveLength(1);
+    expect(result.current.selectedConcordiumAccounts[0].id).toBe("1");
+  });
+});

apps/ledger-live-desktop/src/mvvm/features/AddAccountDrawer/screens/ScanAccounts/hooks/concordium/useConcordiumCreatableAccounts.ts

@@ -0,0 +1,49 @@
+import { isConcordiumAccount } from "@ledgerhq/coin-concordium/bridge/serialization";
+import { Account } from "@ledgerhq/types-live";
+import { useMemo } from "react";
+
+export interface UseConcordiumCreatableAccountsProps {
+  scannedAccounts: Account[];
+  selectedIds: string[];
+}
+
+export interface UseConcordiumCreatableAccountsReturn {
+  hasConcordiumCreatableAccounts: boolean;
+  selectedConcordiumAccounts: Account[];
+}
+
+/**
+ * Hook to check if there are any Concordium creatable accounts among the scanned accounts
+ * and return all selected Concordium accounts (both creatable and importable).
+ *
+ * @param scannedAccounts - Array of all scanned accounts
+ * @param selectedIds - Array of selected account IDs
+ * @returns Object containing whether there are creatable accounts and all selected Concordium accounts
+ */
+export function useConcordiumCreatableAccounts({
+  scannedAccounts,
+  selectedIds,
+}: UseConcordiumCreatableAccountsProps): UseConcordiumCreatableAccountsReturn {
+  return useMemo(() => {
+    const selectedIdsSet = new Set(selectedIds);
+    const selectedConcordiumAccounts: Account[] = [];
+    let hasCreatableAccounts = false;
+
+    for (const account of scannedAccounts) {
+      if (!isConcordiumAccount(account)) continue;
+
+      if (!selectedIdsSet.has(account.id)) continue;
+
+      selectedConcordiumAccounts.push(account);
+
+      if (account.concordiumResources.isOnboarded) continue;
+
+      hasCreatableAccounts = true;
+    }
+
+    return {
+      hasConcordiumCreatableAccounts: hasCreatableAccounts,
+      selectedConcordiumAccounts,
+    };
+  }, [scannedAccounts, selectedIds]);
+}

apps/ledger-live-desktop/src/mvvm/features/AddAccountDrawer/screens/ScanAccounts/useScanAccounts.ts

@@ -26,6 +26,7 @@ import {
   getUnimportedAccounts,
 } from "./utils/processAccounts";
 import { useCantonCreatableAccounts } from "./hooks/useCantonCreatableAccounts";
+import { useConcordiumCreatableAccounts } from "./hooks/concordium/useConcordiumCreatableAccounts";
 
 const selectImportable = (importable: Account[]) => (selected: string[]) => {
   const importableIds = importable.map(a => a.id);
@@ -168,6 +169,12 @@ export function useScanAccounts({
       selectedIds: filteredSelectedIds,
     });
 
+  const { hasConcordiumCreatableAccounts, selectedConcordiumAccounts } =
+    useConcordiumCreatableAccounts({
+      scannedAccounts,
+      selectedIds: filteredSelectedIds,
+    });
+
   const handleConfirm = useCallback(() => {
     trackAddAccountEvent(ADD_ACCOUNT_EVENTS_NAME.ADD_ACCOUNT_BUTTON_CLICKED, {
       button: "Confirm",
@@ -191,6 +198,20 @@ export function useScanAccounts({
       return;
     }
 
+    if (hasConcordiumCreatableAccounts) {
+      setDrawer();
+
+      dispatch(
+        openModal("MODAL_CONCORDIUM_ONBOARD_ACCOUNT", {
+          currency,
+          selectedAccounts: selectedConcordiumAccounts,
+          editedNames: {},
+        }),
+      );
+
+      return;
+    }
+
     if (accountsToImport.length > 0) {
       setHasImportedAccounts(true);
     }
@@ -217,6 +238,8 @@ export function useScanAccounts({
     device,
     hasCantonCreatableAccounts,
     selectedCantonCreatableAccounts,
+    hasConcordiumCreatableAccounts,
+    selectedConcordiumAccounts,
     filteredSelectedIds,
     scannedAccounts,
     deferAccountAddition,