Merge pull request #14454 from LedgerHQ/feat/LIVE-26222_remove-lock-button

Author: claudiiafg

.changeset/fresh-pens-occur.md

@@ -0,0 +1,5 @@
+---
+"ledger-live-desktop": minor
+---
+
+feat(lwd): remove lock button in wallet40

apps/ledger-live-desktop/src/mvvm/components/TopBar/TopBarView.tsx

@@ -1,13 +1,10 @@
-import React, { useState, useCallback } from "react";
-import { useDispatch, useSelector } from "LLD/hooks/redux";
+import React, { useState } from "react";
 import { useTranslation } from "react-i18next";
-import { lock } from "~/renderer/actions/application";
 import { ItemContainer } from "~/renderer/components/TopBar/shared";
 import Tooltip from "~/renderer/components/Tooltip";
 import Breadcrumb from "~/renderer/components/Breadcrumb";
 import HelpSideBar from "~/renderer/modals/Help";
 
-import { hasPasswordSelector } from "~/renderer/reducers/application";
 import { LiveAppDrawer } from "~/renderer/components/LiveAppDrawer";
 import { IconsLegacy } from "@ledgerhq/react-ui";
 import { NavBar, NavBarTrailing, NavBarTitle } from "@ledgerhq/lumen-ui-react";
@@ -16,10 +13,7 @@ import { TopBarActionsList } from "./components/ActionsList";
 
 const TopBarView = ({ slots }: TopBarViewProps) => {
   const { t } = useTranslation();
-  const dispatch = useDispatch();
-  const hasPassword = useSelector(hasPasswordSelector);
   const [helpSideBarVisible, setHelpSideBarVisible] = useState(false);
-  const handleLock = useCallback(() => dispatch(lock()), [dispatch]);
 
   return (
     <NavBar className="items-center px-32 pt-32 pb-24">
@@ -41,20 +35,6 @@ const TopBarView = ({ slots }: TopBarViewProps) => {
           </ItemContainer>
         </Tooltip>
         <HelpSideBar isOpened={helpSideBarVisible} onClose={() => setHelpSideBarVisible(false)} />
-        {hasPassword && (
-          <>
-            <Tooltip content={t("common.lock")}>
-              <ItemContainer
-                data-testid="topbar-password-lock-button"
-                isInteractive
-                justifyContent="center"
-                onClick={handleLock}
-              >
-                <IconsLegacy.LockAltMedium size={18} />
-              </ItemContainer>
-            </Tooltip>
-          </>
-        )}
       </NavBarTrailing>
     </NavBar>
   );

apps/ledger-live-desktop/src/mvvm/components/TopBar/__tests__/index.test.tsx

@@ -75,36 +75,16 @@ describe("TopBar", () => {
     expect(screen.queryByTestId("topbar-action-button-synchronize")).toBeNull();
   });
 
-  it("renders lock button when hasPassword is true", () => {
+  it("renders all slot actions and help when hasAccounts is true", () => {
     render(<TopBar />, {
       initialState: getDefaultInitialState({
-        application: { hasPassword: true },
-      }),
-    });
-
-    expect(screen.getByTestId("topbar-password-lock-button")).toBeVisible();
-  });
-
-  it("does not render lock button when hasPassword is false", () => {
-    render(<TopBar />, {
-      initialState: getDefaultInitialState(),
-    });
-
-    expect(screen.queryByTestId("topbar-password-lock-button")).toBeNull();
-  });
-
-  it("renders all elements when hasAccounts and hasPassword are true", () => {
-    render(<TopBar />, {
-      initialState: getDefaultInitialState({
-        application: { hasPassword: true },
         accounts: [mockAccount],
       }),
     });
 
     expect(screen.getByTestId("topbar-action-button-synchronize")).toBeVisible();
     expect(screen.getByTestId("topbar-action-button-notifications")).toBeVisible();
     expect(screen.getByTestId("topbar-action-button-discreet")).toBeVisible();
-    expect(screen.getByTestId("topbar-password-lock-button")).toBeVisible();
     expect(screen.getByTestId("topbar-help-button")).toBeVisible();
     expect(screen.getByTestId("topbar-action-button-settings")).toBeVisible();
   });