feat(evm): pr reviews

Author: Moustafa-Koterba

libs/coin-modules/coin-evm/src/logic/common.test.ts

@@ -14,46 +14,41 @@ describe("common", () => {
           ),
         },
       } as unknown as TransactionIntent<MemoNotSupported, BufferTxData>;
+      const expectedResult = Buffer.from(intent.data.value);
 
       const result = getCallData(intent);
-      expect(result).toEqual(intent.data.value);
+      expect(result).toEqual(expectedResult);
     });
 
-    it("should return empty buffer for native asset", () => {
-      const intent = {
+    it.each([
+      {
         asset: {
           type: "native",
         },
-      } as unknown as TransactionIntent<MemoNotSupported, BufferTxData>;
-
-      const result = getCallData(intent);
-      expect(result).toEqual(Buffer.from([]));
-    });
-
-    it("should return empty buffer for non native asset and no recipient", () => {
-      const intent = {
+      } as unknown as TransactionIntent<MemoNotSupported, BufferTxData>,
+      {
         asset: {
           type: "erc20",
         },
-      } as unknown as TransactionIntent<MemoNotSupported, BufferTxData>;
-
-      const result = getCallData(intent);
-      expect(result).toEqual(Buffer.from([]));
-    });
-
-    it("should return empty buffer for non native asset with recipient and no amount", () => {
-      const intent = {
+      } as unknown as TransactionIntent<MemoNotSupported, BufferTxData>,
+      {
         asset: {
           type: "erc20",
         },
         recipient: "0x66c4371aE8FFeD2ec1c2EBbbcCfb7E494181E1E3",
-      } as unknown as TransactionIntent<MemoNotSupported, BufferTxData>;
-
+      } as unknown as TransactionIntent<MemoNotSupported, BufferTxData>,
+      {
+        asset: {
+          type: "erc20",
+        },
+        amount: 1n,
+      } as unknown as TransactionIntent<MemoNotSupported, BufferTxData>,
+    ])("should return empty buffer for invalid intent", intent => {
       const result = getCallData(intent);
       expect(result).toEqual(Buffer.from([]));
     });
 
-    it("should return calldata from contract for non native asset with a recipient", () => {
+    it("should return calldata from contract for non native asset with a recipient and an amount", () => {
       const intent = {
         asset: {
           type: "erc20",

libs/coin-modules/coin-evm/src/logic/common.ts

@@ -99,7 +99,10 @@ export function getErc20Data(recipient: string, amount: bigint): Buffer {
 export function getCallData(intent: TransactionIntent<MemoNotSupported, BufferTxData>): Buffer {
   const data = intent.data?.value;
   if (Buffer.isBuffer(data) && data.length) return data;
-  return isNative(intent.asset) || !intent.recipient || !intent.amount
+  return isNative(intent.asset) ||
+    !intent.recipient ||
+    intent.amount === undefined ||
+    intent.amount === null
     ? Buffer.from([])
     : getErc20Data(intent.recipient, intent.amount);
 }

libs/coin-modules/coin-evm/src/logic/validateIntent.test.ts

@@ -321,6 +321,13 @@ describe("validateIntent", () => {
 
   describe("gas", () => {
     describe("common", () => {
+      beforeEach(() => {
+        (computeGasLimitModule.computeIntrinsicGasLimit as jest.Mock).mockImplementation(
+          jest.requireActual("./computeGasLimit").computeIntrinsicGasLimit,
+        );
+        // ... other setup
+      });
+
       describe.each([
         ["a legacy intent", legacyIntent],
         ["an eip1559 intent", eip1559Intent],