fix: lwm walletv4tour post onboarding

Author: RobinVncnt

.changeset/lemon-parrots-reply.md

@@ -0,0 +1,5 @@
+---
+"live-mobile": minor
+---
+
+fix: lwm walletv4tour post onboarding

apps/ledger-live-mobile/src/mvvm/features/WalletV4Tour/Drawer/__integrations__/walletV4TourDrawer.test.tsx

@@ -55,7 +55,6 @@ describe("WalletV4TourDrawer integration", () => {
         ...state,
         settings: {
           ...state.settings,
-          hasCompletedOnboarding: true,
           hasSeenWalletV4Tour: hasSeenTour,
         },
       }),

apps/ledger-live-mobile/src/mvvm/features/WalletV4Tour/Drawer/hooks/useWalletV4TourDrawerViewModel.ts

@@ -2,7 +2,7 @@ import { useState, useCallback, useMemo, useRef } from "react";
 import { useDispatch, useSelector } from "~/context/hooks";
 import { useFeature } from "@ledgerhq/live-common/featureFlags/index";
 import { setHasSeenWalletV4Tour } from "~/actions/settings";
-import { hasCompletedOnboardingSelector, hasSeenWalletV4TourSelector } from "~/reducers/settings";
+import { hasSeenWalletV4TourSelector } from "~/reducers/settings";
 import type { WalletV4TourDrawerViewModel } from "../types";
 import { useTranslation } from "~/context/Locale";
 import animation01 from "../animations/01.lottie";
@@ -15,19 +15,16 @@ export const useWalletV4TourDrawerViewModel = (): WalletV4TourDrawerViewModel =>
   const dispatch = useDispatch();
   const currentIndexRef = useRef(0);
   const hasSeenTour = useSelector(hasSeenWalletV4TourSelector);
-  const hasCompletedOnboarding = useSelector(hasCompletedOnboardingSelector);
   const lwmWallet40 = useFeature("lwmWallet40");
   const isTourEnabled = (lwmWallet40?.enabled && lwmWallet40?.params?.tour) ?? false;
 
   const [isDrawerOpen, setIsDrawerOpen] = useState(isTourEnabled && !hasSeenTour);
 
   const handleOpenDrawer = useCallback(() => {
-    if (!hasCompletedOnboarding) {
-      dispatch(setHasSeenWalletV4Tour(true));
-    } else if (!hasSeenTour) {
+    if (!hasSeenTour) {
       setIsDrawerOpen(true);
     }
-  }, [hasCompletedOnboarding, hasSeenTour, dispatch]);
+  }, [hasSeenTour]);
 
   const handleCloseDrawer = useCallback(() => {
     setIsDrawerOpen(false);

apps/ledger-live-mobile/src/mvvm/features/WalletV4Tour/hooks/useMarkWalletV4TourSeenAtOnboardingStart.ts

@@ -0,0 +1,15 @@
+import { useEffect } from "react";
+import { useDispatch } from "~/context/hooks";
+import { setHasSeenWalletV4Tour } from "~/actions/settings";
+
+/**
+ * Call on the first screen of the onboarding flow (Welcome).
+ * Marks the Wallet V4 tour as "seen" so the tour drawer does not open after onboarding.
+ */
+export function useMarkWalletV4TourSeenAtOnboardingStart(): void {
+  const dispatch = useDispatch();
+
+  useEffect(() => {
+    dispatch(setHasSeenWalletV4Tour(true));
+  }, [dispatch]);
+}

apps/ledger-live-mobile/src/mvvm/features/WelcomePage/index.tsx

@@ -11,13 +11,16 @@ import { StoryProgressBar } from "./components/StoryProgressBar";
 import { TappableMask } from "./components/TappableMask";
 import { useWelcomeNavigation } from "./hooks/useWelcomeNavigation";
 import { useWelcomeStories } from "./hooks/useWelcomeStories";
+import { useMarkWalletV4TourSeenAtOnboardingStart } from "LLM/features/WalletV4Tour/hooks/useMarkWalletV4TourSeenAtOnboardingStart";
 import SafeAreaView from "~/components/SafeAreaView";
 
 export default function WelcomePage() {
   const { colors } = useTheme();
   const isAppActive = !useIsAppInBackground();
   const isFocused = useIsFocused();
 
+  useMarkWalletV4TourSeenAtOnboardingStart();
+
   const { welcomeVideos, currentVideoIndex, videoDurations, onLoad, onPrevious, onNext } =
     useWelcomeStories();
   const { onLogoTouchStart, onLogoTouchEnd } = useWelcomeNavigation();

apps/ledger-live-mobile/src/screens/Onboarding/steps/welcome.tsx

@@ -18,6 +18,7 @@ import ForceTheme from "~/components/theme/ForceTheme";
 import Button from "~/components/wrappedUi/Button";
 import { OnboardingNavigatorParamList } from "~/components/RootNavigator/types/OnboardingNavigator";
 import { BaseComposite, StackNavigatorProps } from "~/components/RootNavigator/types/helpers";
+import { useMarkWalletV4TourSeenAtOnboardingStart } from "LLM/features/WalletV4Tour/hooks/useMarkWalletV4TourSeenAtOnboardingStart";
 
 import videoSources from "../../../../assets/videos";
 import LanguageSelect from "../../SyncOnboarding/LanguageSelect";
@@ -44,6 +45,8 @@ function OnboardingStepWelcome({ navigation }: NavigationProps) {
   const acceptTerms = useAcceptGeneralTerms();
   const llmAnalyticsOptInPromptFeature = useFeature("llmAnalyticsOptInPrompt");
 
+  useMarkWalletV4TourSeenAtOnboardingStart();
+
   const {
     i18n: { language: locale },
   } = useTranslation();