Merge pull request #14494 from LedgerHQ/fix/sui-batch-multi-get-objects-limit

fix(coin-sui): batch multiGetObjects calls to respect 50-object RPC limit

Author: amaslakov

.changeset/sharp-impalas-bake.md

@@ -0,0 +1,5 @@
+---
+"@ledgerhq/coin-sui": patch
+---
+
+Batch multiGetObjects calls in chunks of 50 to fix "Input exceeds limit of 50" error on fragmented accounts

libs/coin-modules/coin-sui/src/network/sdk.test.ts

@@ -5,6 +5,7 @@ import type {
   SuiTransactionBlockResponse,
   SuiTransactionBlockKind,
   PaginatedTransactionResponse,
+  SuiObjectResponse,
 } from "@mysten/sui/client";
 import { BigNumber } from "bignumber.js";
 import coinConfig from "../config";
@@ -2273,3 +2274,96 @@ describe("getCoinsForAmount", () => {
     });
   });
 });
+
+describe("withBatchedMultiGetObjects", () => {
+  const createMockClient = () => {
+    const multiGetObjects = jest.fn(
+      async (params: { ids: string[]; options?: Record<string, boolean> }) => {
+        if (params.ids.length > 50) {
+          throw new Error("Input exceeds limit of 50");
+        }
+        return params.ids.map(
+          id =>
+            ({
+              data: {
+                objectId: id,
+                version: "1",
+                digest: `digest-${id}`,
+              },
+            }) as SuiObjectResponse,
+        );
+      },
+    );
+    return { client: { multiGetObjects } as unknown as SuiClient, multiGetObjects };
+  };
+
+  it("should pass through when <= 50 objects", async () => {
+    // GIVEN
+    const { client, multiGetObjects } = createMockClient();
+    const ids = Array.from({ length: 30 }, (_, i) => `0xobj${i}`);
+
+    // WHEN
+    const batched = sdk.withBatchedMultiGetObjects(client);
+    const result = await batched.multiGetObjects({ ids, options: { showBcs: true } });
+
+    // THEN
+    expect(multiGetObjects).toHaveBeenCalledTimes(1);
+    expect(result).toHaveLength(30);
+  });
+
+  it("should batch when > 50 objects", async () => {
+    // GIVEN
+    const { client, multiGetObjects } = createMockClient();
+    const ids = Array.from({ length: 120 }, (_, i) => `0xobj${i}`);
+
+    // WHEN
+    const batched = sdk.withBatchedMultiGetObjects(client);
+    const result = await batched.multiGetObjects({ ids, options: { showBcs: true } });
+
+    // THEN
+    expect(multiGetObjects).toHaveBeenCalledTimes(3);
+    expect(multiGetObjects).toHaveBeenNthCalledWith(1, {
+      ids: ids.slice(0, 50),
+      options: { showBcs: true },
+    });
+    expect(multiGetObjects).toHaveBeenNthCalledWith(2, {
+      ids: ids.slice(50, 100),
+      options: { showBcs: true },
+    });
+    expect(multiGetObjects).toHaveBeenNthCalledWith(3, {
+      ids: ids.slice(100, 120),
+      options: { showBcs: true },
+    });
+    expect(result).toHaveLength(120);
+    expect(result[0].data?.objectId).toBe("0xobj0");
+    expect(result[119].data?.objectId).toBe("0xobj119");
+  });
+
+  it("should handle exactly 50 objects without batching", async () => {
+    // GIVEN
+    const { client, multiGetObjects } = createMockClient();
+    const ids = Array.from({ length: 50 }, (_, i) => `0xobj${i}`);
+
+    // WHEN
+    const batched = sdk.withBatchedMultiGetObjects(client);
+    const result = await batched.multiGetObjects({ ids });
+
+    // THEN
+    expect(multiGetObjects).toHaveBeenCalledTimes(1);
+    expect(result).toHaveLength(50);
+  });
+
+  it("should handle exactly 51 objects with batching", async () => {
+    // GIVEN
+    const { client, multiGetObjects } = createMockClient();
+    const ids = Array.from({ length: 51 }, (_, i) => `0xobj${i}`);
+
+    // WHEN
+    const batched = sdk.withBatchedMultiGetObjects(client);
+    const result = await batched.multiGetObjects({ ids });
+
+    // THEN
+    expect(multiGetObjects).toHaveBeenCalledTimes(2);
+    expect(result).toHaveLength(51);
+  });
+});

libs/coin-modules/coin-sui/src/network/sdk.ts

@@ -54,6 +54,7 @@ type AsyncApiFunction<T> = (api: SuiClient) => Promise<T>;
 
 export const TRANSACTIONS_LIMIT_PER_QUERY = 50;
 export const TRANSACTIONS_LIMIT = 300;
+const MULTI_GET_OBJECTS_LIMIT = 50;
 const BLOCK_HEIGHT = 5; // sui has no block height metainfo, we use it simulate proper icon statuses in apps
 
 export const DEFAULT_COIN_TYPE = "0x2::sui::SUI";
@@ -98,6 +99,39 @@ export async function withApi<T>(execute: AsyncApiFunction<T>) {
   return result;
 }
 
+/**
+ * Wraps a SuiClient to batch multiGetObjects calls in chunks of 50,
+ * working around the SUI RPC limit.
+ */
+export function withBatchedMultiGetObjects(client: SuiClient): SuiClient {
+  return new Proxy(client, {
+    get(target, prop, _receiver) {
+      if (prop === "multiGetObjects") {
+        return async (params: Parameters<SuiClient["multiGetObjects"]>[0]) => {
+          const { ids } = params;
+          if (ids.length <= MULTI_GET_OBJECTS_LIMIT) {
+            return target.multiGetObjects(params);
+          }
+          const results = [];
+          for (let i = 0; i < ids.length; i += MULTI_GET_OBJECTS_LIMIT) {
+            const chunk = await target.multiGetObjects({
+              ...params,
+              ids: ids.slice(i, i + MULTI_GET_OBJECTS_LIMIT),
+            });
+            results.push(...chunk);
+          }
+          return results;
+        };
+      }
+      const value = Reflect.get(target, prop, target);
+      if (typeof value === "function") {
+        return value.bind(target);
+      }
+      return value;
+    },
+  });
+}
+
 export const getAllBalancesCached = makeLRUCache(
   async (owner: string) =>
     withApi(
@@ -950,7 +984,7 @@ const createTransactionForDelegate = async (address: string, transaction: Create
     tx.setGasBudgetIfNotSet(ONE_SUI / 10);
 
     const serialized = await tx.build({ client: api });
-    const { bcsObjects } = await getInputObjects(tx, api);
+    const { bcsObjects } = await getInputObjects(tx, withBatchedMultiGetObjects(api));
 
     return { serialized, bcsObjects };
   });
@@ -981,7 +1015,7 @@ const createTransactionForUndelegate = async (address: string, transaction: Crea
     tx.setGasBudgetIfNotSet(ONE_SUI / 10);
 
     const serialized = await tx.build({ client: api });
-    const { bcsObjects } = await getInputObjects(tx, api);
+    const { bcsObjects } = await getInputObjects(tx, withBatchedMultiGetObjects(api));
 
     return { serialized, bcsObjects };
   });
@@ -1015,7 +1049,7 @@ const createTransactionForOthers = async (address: string, transaction: CreateEx
     }
 
     const serialized = await tx.build({ client: api });
-    const { bcsObjects } = await getInputObjects(tx, api);
+    const { bcsObjects } = await getInputObjects(tx, withBatchedMultiGetObjects(api));
 
     return { serialized, bcsObjects };
   });