feat(LIVE-24415): add formatting to wallet quotes

add flexible formatting to swap wallet quote fetching

Author: philipptpunkt

.changeset/tough-pumas-repeat.md

@@ -0,0 +1,10 @@
+---
+"@ledgerhq/wallet-api-exchange-module": minor
+"@ledgerhq/live-common": minor
+"ledger-live-desktop": minor
+"live-mobile": minor
+---
+
+Centralize swap-quote formatting on the wallet side of `custom.exchange.getQuotes`. Each returned `Quote` now carries an optional `formatted: FormattedQuoteValues`, where every field is a `FormattedNumber` triplet (`numberValue` / `withPrefix` / `withSuffix`) — letting live-app consumers display locale-aware crypto, fiat, rate, and slippage values without owning the formatting logic.
+
+Breaking wire change: `QuotesInput.counterValueCurrency` has been removed. The wallet now sources locale and counter-value currency from its Redux store and threads them into `getQuotes` via the `handlers({ locale, counterValueCurrency, ... })` factory, so the live app no longer needs to pass them on the wire.

apps/ledger-live-desktop/src/renderer/components/WebPTXPlayer/CustomHandlers.ts

@@ -35,6 +35,10 @@ import { useStake } from "LLD/hooks/useStake";
 import { StakeFlowProps } from "~/renderer/screens/stake";
 import { useNavigate } from "react-router";
 import { walletSelector } from "~/renderer/reducers/wallet";
+import {
+  counterValueCurrencySelector,
+  localeSelector,
+} from "~/renderer/reducers/settings";
 import { objectToURLSearchParams } from "@ledgerhq/live-common/wallet-api/helpers";
 import { useRemoteLiveAppContext } from "@ledgerhq/live-common/platform/providers/RemoteLiveAppProvider/index";
 import { useLocalLiveAppContext } from "@ledgerhq/live-common/wallet-api/LocalLiveAppProvider/index";
@@ -52,6 +56,8 @@ export function usePTXCustomHandlers(manifest: WebviewProps["manifest"], account
   const navigate = useNavigate();
   const { isEnabled } = useWalletFeaturesConfig("desktop");
   const walletState = useSelector(walletSelector);
+  const locale = useSelector(localeSelector);
+  const counterValueCurrency = useSelector(counterValueCurrencySelector);
   const { state: liveAppRegistryState } = useRemoteLiveAppContext();
   const { state: localLiveAppState } = useLocalLiveAppContext();
   const syncAccountsById = useSyncAccountsById();
@@ -171,6 +177,8 @@ export function usePTXCustomHandlers(manifest: WebviewProps["manifest"], account
         tracking,
         manifest,
         flags,
+        locale,
+        counterValueCurrency: counterValueCurrency.ticker,
         uiHooks: {
           "custom.exchange.start": ({ exchangeParams, onSuccess, onCancel }) => {
             dispatch(
@@ -392,6 +400,8 @@ export function usePTXCustomHandlers(manifest: WebviewProps["manifest"], account
     tracking,
     manifest,
     flags,
+    locale,
+    counterValueCurrency,
     dispatch,
     setDrawer,
     navigate,

apps/ledger-live-mobile/src/components/WebPTXPlayer/CustomHandlers.ts

@@ -45,7 +45,8 @@ import type { InfoDialogParams } from "@ledgerhq/live-common/wallet-api/validati
 import { makeSetEarnInfoBottomSheetAction, makeSetEarnMenuBottomSheetAction } from "~/actions/earn";
 import { createOpenActionDialogHandler } from "./actionDialogStore";
 import type { Dispatch } from "redux";
-import { useDispatch } from "~/context/hooks";
+import { useDispatch, useSelector } from "~/context/hooks";
+import { counterValueCurrencySelector, localeSelector } from "~/reducers/settings";
 import { ExchangeSwap } from "@ledgerhq/live-common/exchange/swap/types";
 import { useWalletFeaturesConfig } from "@ledgerhq/live-common/featureFlags/index";
 
@@ -78,6 +79,8 @@ export function useCustomExchangeHandlers({
   const dispatch = useDispatch();
   const { isEnabled } = useWalletFeaturesConfig("mobile");
   const flags = useMemo(() => ({ wallet40Ux: isEnabled }), [isEnabled]);
+  const locale = useSelector(localeSelector);
+  const counterValueCurrency = useSelector(counterValueCurrencySelector);
   const { state: liveAppRegistryState } = useRemoteLiveAppContext();
   const { state: localLiveAppState } = useLocalLiveAppContext();
 
@@ -302,6 +305,8 @@ export function useCustomExchangeHandlers({
         tracking,
         manifest,
         flags,
+        locale,
+        counterValueCurrency: counterValueCurrency.ticker,
         uiHooks: {
           "custom.exchange.start": ({ exchangeParams, onSuccess, onCancel }) => {
             const promiseId = `start-${Date.now()}`;
@@ -494,6 +499,8 @@ export function useCustomExchangeHandlers({
     onCompleteResult,
     handleLoaderDrawer,
     flags,
+    locale,
+    counterValueCurrency,
     sendAppReady,
     syncAccountById,
     tracking,

apps/wallet-cli/src/commands/swap/quote.ts

@@ -107,7 +107,6 @@ export default defineCommand({
           providers: DEFAULT_PROVIDERS,
           data: {
             amount: flags.amount,
-            counterValueCurrency: "USD",
             uniswapOrderType: "classic",
             sendCurrencyId: flags.from,
             receiveCurrencyId: flags.to,
@@ -117,7 +116,7 @@ export default defineCommand({
             receiveAccountId: "",
           },
         },
-        { accounts: [], spotPrices: {} },
+        { accounts: [], spotPrices: {}, locale: "en", counterValueCurrency: "USD" },
       );
 
       if (result.quotes.length === 0 && result.errors.length > 0) {

libs/exchange-module/src/types.ts

@@ -122,7 +122,6 @@ export type QuotesInput = {
   receiveAddress: string;
   sendCurrencyId: string;
   receiveCurrencyId: string;
-  counterValueCurrency: string;
   networkFeesCurrencyId?: string;
   slippage?: number;
   uniswapOrderType?: UniswapOrderType;
@@ -286,6 +285,23 @@ export type QuoteDetails = {
   approvalNetworkFee?: QuoteApprovalNetworkFee;
 };
 
+export type FormattedNumber = {
+  numberValue: string;
+  withPrefix: string;
+  withSuffix: string;
+};
+
+export type FormattedQuoteValues = {
+  sendAmount: FormattedNumber;
+  sendAmountCountervalue: FormattedNumber;
+  receiveAmount: FormattedNumber;
+  receiveAmountCountervalue: FormattedNumber;
+  networkFee: FormattedNumber;
+  networkFeeCountervalue: FormattedNumber;
+  rate: FormattedNumber;
+  slippage: FormattedNumber;
+};
+
 export type Quote = {
   id?: string;
   key: string;
@@ -294,6 +310,12 @@ export type Quote = {
   quoteDetails: QuoteDetails;
   warning: QuoteWarning | null;
   error: QuoteError | null;
+  /**
+   * Optional wallet-formatted display strings. Additive field:
+   * producers that cannot format (no locale / counter-value fiat context)
+   * omit it, and consumers must handle `undefined`.
+   */
+  formatted?: FormattedQuoteValues;
 };
 
 /** Error rows returned next to quotes (swap API error objects). */

libs/ledger-live-common/src/wallet-api/Exchange/quotes/format/constants.ts

@@ -0,0 +1,3 @@
+export const DEFAULT_MAX_DECIMALS = 8;
+
+export const COUNTERVALUE_MAX_DECIMALS = 7;