test(e2e): enhance detox video options patch

Author: cunhabruno

apps/ledger-live-mobile/detox.config.js

@@ -12,7 +12,7 @@ module.exports = {
     jest: {
       setupTimeout: 500000,
     },
-    retries: process.env.CI ? 2 : 0,
+    retries: 0,
   },
   logger: {
     level: process.env.DEBUG_DETOX ? "trace" : "info",

apps/ledger-live-mobile/scripts/e2e-ci.mjs

@@ -74,6 +74,7 @@ const test_ios = async () => {
       --take-screenshots failing \
       --forceExit \
       --headless \
+      --retries 2 \
       --cleanup \
       ${filteredArgs}`.nothrow();
   process.exitCode = result.exitCode;
@@ -91,6 +92,7 @@ const test_android = async () => {
       --take-screenshots failing \\
       --forceExit \\
       --headless \\
+      --retries 2 \\
       --cleanup \\
       ${filteredArgs}`.nothrow();
   process.exitCode = result.exitCode;

e2e/mobile/detox.config.js

@@ -30,7 +30,7 @@ module.exports = {
       teardownTimeout: 120000,
     },
     noRetryArgs: ["json", "outputFile"],
-    retries: process.env.CI ? 2 : 0,
+    retries: 0,
     forwardEnv: true, // Used to forward DETOX_CONFIGURATION to Jest workers
   },
   logger: {

e2e/mobile/jest.globalSetup.ts

@@ -8,7 +8,7 @@ register({
 
 import { globalSetup } from "detox/runners/jest";
 import { log } from "detox";
-import { session as detoxSession } from "detox/internals";
+import { session as detoxSession, config as detoxConfig } from "detox/internals";
 import * as fs from "fs/promises";
 import * as path from "path";
 import { exec } from "child_process";
@@ -35,8 +35,6 @@ export default async function setup(): Promise<void> {
   await globalSetup();
 
   const testSessionIndex = detoxSession.testSessionIndex ?? 0;
-  // eslint-disable-next-line @typescript-eslint/no-require-imports
-  const detoxConfig = require("./detox.config.js");
   const maxRetries = detoxConfig.testRunner?.retries ?? 0;
   const isLastRetry = maxRetries > 0 && testSessionIndex >= maxRetries;
 

patches/detox-allure2-adapter@1.0.0-alpha.42.patch

@@ -1,6 +1,6 @@
 --- a/dist/listener.js
 +++ b/dist/listener.js
-@@ -75,8 +75,20 @@
+@@ -75,8 +75,21 @@
                  onError,
              });
          }
@@ -15,11 +15,21 @@
 +            // If enabled via env var, check for JSON options or use defaults
 +            if (enableVideoFromEnv) {
 +                try {
-+                    baseOptions = process.env.DETOX_VIDEO_OPTIONS ? JSON.parse(process.env.DETOX_VIDEO_OPTIONS) : { android: { recording: { bitRate: 1000000, maxSize: 720, codec: 'h264' }, audio: false, window: false }, ios: { codec: 'hevc' } };
++                    baseOptions = process.env.DETOX_VIDEO_OPTIONS ? JSON.parse(process.env.DETOX_VIDEO_OPTIONS) : {};
 +                } catch (e) {
++                    console.warn('Failed to parse DETOX_VIDEO_OPTIONS:', e instanceof Error ? e.message : String(e));
 +                    baseOptions = {};
 +                }
 +            }
              videoManager = new video_1.VideoManager({ device, options: baseOptions, onError });
          }
          if (deviceViewHierarchy && viewHierarchyFactory) {
+@@ -152,7 +165,7 @@
+     })
+         .on('test_fn_failure', async () => {
+         failing = true;
+-        await Promise.all([logs?.attachAfterFailure(api_1.allure), screenshots?.attachFailure(api_1.allure)]);
++        await Promise.all([logs?.attachAfterFailure(api_1.allure), screenshots?.attachFailure(api_1.allure), videoManager?.stopAndAttach($test, failing)]);
+     })
+         .on('test_fn_success', async () => {
+         await Promise.all([logs?.attachAfterSuccess(api_1.allure), screenshots?.attachSuccess(api_1.allure)]);

pnpm-lock.yaml

@@ -42,25 +42,7 @@ runs:
         echo "path=${PATH_VALUE}" >> "$GITHUB_OUTPUT"
     - name: Compress PNG files
       shell: bash
-      run: |
-        if command -v pngquant &> /dev/null; then
-          echo "pngquant already installed"
-        else
-          echo "Installing pngquant..."
-          if [[ "$OSTYPE" == "darwin"* ]]; then
-            brew install pngquant
-          else
-            sudo apt-get update && sudo apt-get install -y pngquant
-          fi
-        fi
-        
-        PNG_COUNT=$(find "${{ inputs.path }}" -type f -name "*.png" 2>/dev/null | wc -l)
-        echo "Found $PNG_COUNT PNG files to compress"
-        
-        if [ "$PNG_COUNT" -gt 0 ]; then
-          find "${{ inputs.path }}" -type f -name "*.png" -exec pngquant --quality=65-80 --skip-if-larger --ext .png --force {} \;
-          echo "PNG compression completed"
-        fi
+      run: ${{ github.action_path }}/compress-pngs.sh "${{ inputs.path }}"
     - name: Publish report on Allure Server
       id: publish-report
       uses: LedgerHQ/send-to-allure-server-action@2.1.2

tools/actions/composites/upload-allure-report/action.yml

@@ -0,0 +1,37 @@
+#!/bin/bash
+set -euo pipefail
+
+# Compress PNG files in a directory using pngquant
+# Usage: compress-pngs.sh <directory>
+
+TARGET_DIR="${1:-}"
+
+if [ -z "$TARGET_DIR" ]; then
+  echo "::error::No directory specified"
+  exit 1
+fi
+
+if [ ! -d "$TARGET_DIR" ]; then
+  echo "::warning::Directory '$TARGET_DIR' not found. Skipping PNG compression."
+  exit 0
+fi
+
+# Install pngquant if not available
+if command -v pngquant &> /dev/null; then
+  echo "pngquant already installed"
+else
+  echo "Installing pngquant..."
+  if [[ "$OSTYPE" == "darwin"* ]]; then
+    brew install pngquant
+  else
+    sudo apt-get update && sudo apt-get install -y pngquant
+  fi
+fi
+
+PNG_COUNT=$(find "$TARGET_DIR" -type f -name "*.png" 2>/dev/null | wc -l | tr -d ' ')
+echo "Found $PNG_COUNT PNG files to compress"
+
+if [ "$PNG_COUNT" -gt 0 ]; then
+  find "$TARGET_DIR" -type f -name "*.png" -exec pngquant --quality=65-80 --skip-if-larger --ext .png --force {} \;
+  echo "PNG compression completed"
+fi