Skip to content

Commit 17fb54e

Browse files
maks-rafalkoclaude
andauthored
ci(MSP-5160): add PHP 8.6 to the CI matrix (#703)
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
1 parent f0bab9d commit 17fb54e

4 files changed

Lines changed: 9 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,11 @@ jobs:
1212
ci:
1313
name: "Execute"
1414
runs-on: ${{ matrix.operating-system }}
15+
# PHP 8.6 is a nightly/pre-release build until GA, so its legs must not block merges.
16+
continue-on-error: ${{ matrix.php-version == '8.6' }}
1517

1618
strategy:
19+
fail-fast: false
1720
matrix:
1821
dependencies:
1922
- "lowest"
@@ -22,6 +25,7 @@ jobs:
2225
php-version:
2326
- "8.4"
2427
- "8.5"
28+
- "8.6"
2529
operating-system:
2630
- "ubuntu-latest"
2731

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@
3131
"phpstan/phpstan-phpunit": "^2.0.18",
3232
"phpstan/phpstan-strict-rules": "^2.0.12",
3333
"phpunit/phpunit": "^13.2.6",
34-
"rector/rector": "^2.5.8"
34+
"rector/rector": "^2.5.8",
35+
"thecodingmachine/safe": "^3.4.0"
3536
},
3637
"config": {
3738
"bin-dir": "bin",

composer.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/unit/SerializerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public static function provideEmptyStructures(): iterable
101101
public function it_throws_when_deserializing_if_an_error_encountered(): void
102102
{
103103
$this->expectException(DeserializationFailed::class);
104-
$this->expectExceptionMessageIs('Failed to deserialize data from JSON. Error code: 4, error message: Syntax error.');
104+
$this->expectExceptionMessageMatches('/^Failed to deserialize data from JSON\. Error code: 4, error message: Syntax error(?: near location \d+:\d+)?\.$/');
105105

106106
$this->serializer->deserialize('{"unclosed":"bad","object":"json"');
107107
}
@@ -118,7 +118,7 @@ public function it_can_deserialize_json_nested_to_the_maximum_supported_depth():
118118
public function it_throws_when_deserializing_json_nested_beyond_the_maximum_supported_depth(): void
119119
{
120120
$this->expectException(DeserializationFailed::class);
121-
$this->expectExceptionMessageIs('Failed to deserialize data from JSON. Error code: 1, error message: Maximum stack depth exceeded.');
121+
$this->expectExceptionMessageMatches('/^Failed to deserialize data from JSON\. Error code: 1, error message: Maximum stack depth exceeded(?: near location \d+:\d+)?\.$/');
122122

123123
$this->serializer->deserialize($this->nestedArrays(self::MAX_NESTING_DEPTH + 1));
124124
}

0 commit comments

Comments
 (0)