Use lendable/phpunit-extensions (#52)

Author: ben-challis

composer.json

@@ -17,6 +17,7 @@
         "ergebnis/composer-normalize": "^2.42.0",
         "ergebnis/phpstan-rules": "^2.2.0",
         "lendable/composer-license-checker": "^1.2.0",
+        "lendable/phpunit-extensions": "^0.3",
         "php-cs-fixer/shim": "^3.54.0",
         "phpstan/phpstan": "^1.10.67",
         "phpstan/phpstan-deprecation-rules": "^1.1.4",

composer.lock

@@ -1,4 +1,5 @@
 includes:
+  - vendor/lendable/phpunit-extensions/phpstan/rules.neon
   - vendor/phpstan/phpstan-deprecation-rules/rules.neon
   - vendor/phpstan/phpstan-phpunit/extension.neon
   - vendor/phpstan/phpstan-phpunit/rules.neon

phpstan.neon

@@ -2,6 +2,7 @@
 
 declare(strict_types=1);
 
+use Lendable\PHPUnitExtensions\Rector\EnforceDisableReturnValueGenerationForTestDoublesRector;
 use Rector\Caching\ValueObject\Storage\FileCacheStorage;
 use Rector\CodeQuality\Rector\Array_\CallableThisArrayToAnonymousFunctionRector;
 use Rector\CodeQuality\Rector\ClassMethod\LocallyCalledStaticMethodToNonStaticRector;
@@ -28,4 +29,6 @@
         LevelSetList::UP_TO_PHP_82,
         PHPUnitSetList::PHPUNIT_100,
     ]);
+
+    $rectorConfig->rule(EnforceDisableReturnValueGenerationForTestDoublesRector::class);
 };

rector.php

@@ -7,11 +7,13 @@
 use Lendable\Message\BinaryStringUuidConverter;
 use Lendable\Message\MessageId;
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DisableReturnValueGenerationForTestDoubles;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 use Tests\Fixtures\Lendable\Message\UuidGenerator;
 
 #[CoversClass(BinaryStringUuidConverter::class)]
+#[DisableReturnValueGenerationForTestDoubles]
 final class BinaryStringUuidConverterTest extends TestCase
 {
     #[Test]

tests/unit/BinaryStringUuidConverterTest.php

@@ -7,12 +7,14 @@
 use Lendable\Message\CorrelationId;
 use Lendable\Message\InvalidUuidString;
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DisableReturnValueGenerationForTestDoubles;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 use Ramsey\Uuid\Uuid;
 use Tests\Fixtures\Lendable\Message\UuidGenerator;
 
 #[CoversClass(CorrelationId::class)]
+#[DisableReturnValueGenerationForTestDoubles]
 final class CorrelationIdTest extends TestCase
 {
     #[Test]

tests/unit/CorrelationIdTest.php

@@ -8,11 +8,13 @@
 use Lendable\Message\Event\Event;
 use Lendable\Message\Event\Naming\EventNameNotResolvable;
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DisableReturnValueGenerationForTestDoubles;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 use Tests\Fixtures\Lendable\Message\Event\ExampleFooEvent;
 
 #[CoversClass(EventNameNotResolvable::class)]
+#[DisableReturnValueGenerationForTestDoubles]
 final class EventNameNotResolvableTest extends TestCase
 {
     #[Test]

tests/unit/Event/Naming/EventNameNotResolvableTest.php

@@ -6,10 +6,12 @@
 
 use Lendable\Message\InvalidMessageName;
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DisableReturnValueGenerationForTestDoubles;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 
 #[CoversClass(InvalidMessageName::class)]
+#[DisableReturnValueGenerationForTestDoubles]
 final class InvalidMessageNameTest extends TestCase
 {
     #[Test]

tests/unit/InvalidMessageNameTest.php

@@ -6,10 +6,12 @@
 
 use Lendable\Message\InvalidUuidString;
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DisableReturnValueGenerationForTestDoubles;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 
 #[CoversClass(InvalidUuidString::class)]
+#[DisableReturnValueGenerationForTestDoubles]
 final class InvalidUuidStringTest extends TestCase
 {
     #[Test]

tests/unit/InvalidUuidStringTest.php

@@ -7,12 +7,14 @@
 use Lendable\Message\InvalidUuidString;
 use Lendable\Message\MessageId;
 use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DisableReturnValueGenerationForTestDoubles;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 use Ramsey\Uuid\Uuid;
 use Tests\Fixtures\Lendable\Message\UuidGenerator;
 
 #[CoversClass(MessageId::class)]
+#[DisableReturnValueGenerationForTestDoubles]
 final class MessageIdTest extends TestCase
 {
     #[Test]