Skip to content

Commit 59f2fd2

Browse files
committed
fix(scripts): bench-cross-runtime — address PR #145 review nits
Two comment-only corrections inside scripts/bench-cross-runtime.sh caught by the agentic PR reviewer; no functional change. 1. Header `Prerequisites` block still listed `Java 21`. The same PR bumped pom + CI + READMEs to 25, so the file-internal comment was the last stale "Java 21" reference. Updated to `Java 25`. 2. The new `JAVA_BENCH_OPTS` example showed `-XX:+UseZGC -XX:+ZGenerational`. Generational ZGC is the default since JDK 24 and the non-generational mode is removed in 25, so the `-XX:+ZGenerational` flag is now obsolete — passing it emits a warning on every server startup. Reduced the example to just `-XX:+UseZGC` and noted that generational mode is default since JDK 24.
1 parent 54ef70a commit 59f2fd2

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

scripts/bench-cross-runtime.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#
77
# Prerequisites:
88
# - hey: go install github.com/rakyll/hey@latest
9-
# - Go, Java 21, cmake + build-essential + libluajit
9+
# - Go, Java 25, cmake + build-essential + libluajit
1010
#
1111
# Usage:
1212
# ./scripts/bench-cross-runtime.sh [--skip go] [--modes "row,column"]
@@ -172,9 +172,10 @@ start_server() {
172172
# Set BENCH_VERBOSE=1 to capture server logs for debugging startup failures
173173
[[ "${BENCH_VERBOSE:-}" == "1" ]] && sink="$WORK_DIR/${runtime}.log"
174174
local -a cmd=()
175-
# JAVA_BENCH_OPTS lets the caller inject JVM flags (e.g. `-XX:+UseZGC
176-
# -XX:+ZGenerational`) for the java leg without touching the script.
177-
# Word-split via $JAVA_BENCH_OPTS expansion; empty default = no flags.
175+
# JAVA_BENCH_OPTS lets the caller inject JVM flags (e.g. `-XX:+UseZGC`
176+
# for generational ZGC, default since JDK 24) for the java leg without
177+
# touching the script. Word-split via $JAVA_BENCH_OPTS expansion; empty
178+
# default = no flags.
178179
local -a java_opts=()
179180
if [[ -n "${JAVA_BENCH_OPTS:-}" ]]; then
180181
# shellcheck disable=SC2206 # intentional word-splitting for env-supplied flags

0 commit comments

Comments
 (0)