Commit 59f2fd2
committed
fix(scripts): bench-cross-runtime — address PR #145 review nits
Two comment-only corrections inside scripts/bench-cross-runtime.sh
caught by the agentic PR reviewer; no functional change.
1. Header `Prerequisites` block still listed `Java 21`. The same PR
bumped pom + CI + READMEs to 25, so the file-internal comment was
the last stale "Java 21" reference. Updated to `Java 25`.
2. The new `JAVA_BENCH_OPTS` example showed `-XX:+UseZGC
-XX:+ZGenerational`. Generational ZGC is the default since JDK 24
and the non-generational mode is removed in 25, so the
`-XX:+ZGenerational` flag is now obsolete — passing it emits a
warning on every server startup. Reduced the example to just
`-XX:+UseZGC` and noted that generational mode is default since
JDK 24.1 parent 54ef70a commit 59f2fd2
1 file changed
Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
175 | | - | |
176 | | - | |
177 | | - | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
178 | 179 | | |
179 | 180 | | |
180 | 181 | | |
| |||
0 commit comments