Skip to content

Commit a9830fc

Browse files
committed
style(cpp): reflow a 161-char comment the audit found had been dropped
Terminal audit returned FAIL, and this is the one finding in it that touched code. Round 12 reported a 161-character comment line in config.cpp against the 110-column ColumnLimit in .clang-format. I recorded the other findings from that round and silently let this one go, so it was still live at HEAD — never fixed, never disproved, never written down as accepted. It fell out at exactly the point the auditor predicted the evidence chain was weakest: where the only record of a finding is my own transcription of a report that no artifact preserves. That prediction landing is worth more than the fix. Nothing gates it, which is why nothing else caught it: clang-format is not installed locally and there is no CI job for it, already a tracked doc-gap. The audit's other three findings were record defects, all corrected in .code-review/closure-ledger-187-188.md and the scope addendum: a round/commit attribution that named a commit which never touched the file, two self-initiated commits credited as round fixes while my own evidence-gap record classified them otherwise, and a "rounds 7 through 12 found no code defect" claim that this ledger's own r12 row falsifies — sitting in the paragraph that justified stopping the loop. 254 C++ cases, lint clean.
1 parent 4e36cae commit a9830fc

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

pine-cpp/src/config/config.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,8 @@ Config load_config_from_json(const std::string& text) {
362362
// with an invalid storage_mode AND a nested field of the wrong type, this reports
363363
// the value error while pine-go reports the type error. pine-java sits in between:
364364
// it matches pine-go only for fields it reads through a throwing helper
365-
// (readStringList), and matches this for the ones it coerces via asText/asBoolean. Moving this call after nested parsing fixes that but re-breaks constraint 2
365+
// (readStringList), and matches this for the ones it coerces via asText/asBoolean.
366+
// Moving this call after nested parsing fixes that but re-breaks constraint 2
366367
// below; satisfying both needs a two-pass parse. Tracked in memory/doc-gaps.md.
367368
//
368369
// Two orderings had to be satisfied at once, and getting one right first broke

0 commit comments

Comments
 (0)