fix: Remove old ios file fallback

This change removes the fallback which would read from the very old location from dotnet days on ios.
This means that any user who is still on the old maui version (over a year old) and updates, their data will not carry over. Their data is not deleted yet, so if there is a bug report we can bring it back.

This old behaviour reading caused an issue where if we removed a value from the keyValueStore, it would not remove it from the old location, meaning when we read it again it would load extremely old data.
This lead to an issue with loading the current session state on ios apps which have transitioned from the old app to the new.

Basically the old version of the app which was essentially a web app (maui+blazor) used to write files in a different location to where the new react native app does, but only on ios. I added a compatibility layer where it would read those old files but not write them.

Recently when I changed the format from proto to json, what would happen is from file CURRENT_SESISON_VERSION LiftLog would read the what type of file it is (proto or JSON). Then from CURRENT_SESSION it would read the actual current session file. Now unfortately in ios it would actually read CURRENT_SESSION which would say it is the new format, but when it would read CURRENT_SESSION, that file is not there (as there is no current session, it is complete), but then it would fallback to CURRENT_SESSION_OLD_LOCATION where there WAS a file there from the maui version of liftlog. It tries to read the proto file as json and explodes.

I think it's been long enough, we don't need that fallback.

fixes: #860

Author: LiamMorrow

app/src/services/key-value-store.ts

@@ -1,18 +1,12 @@
 import { uuid } from '@/utils/uuid';
 import { File, Paths } from 'expo-file-system';
-import { Platform } from 'react-native';
-import { getLibraryDirectory } from '~/modules/native-lib';
 
 export class KeyValueStore {
   async getItem(key: string): Promise<string | undefined> {
     const file = getFile(key);
     if (file.exists) {
       return file.text();
     }
-    const oldFile = getOldDirFile(key);
-    if (oldFile?.exists) {
-      return oldFile.text();
-    }
     return undefined;
   }
 
@@ -21,10 +15,6 @@ export class KeyValueStore {
     if (file.exists) {
       return this.readBytes(file);
     }
-    const oldFile = getOldDirFile(key);
-    if (oldFile?.exists) {
-      return this.readBytes(oldFile);
-    }
     return undefined;
   }
 
@@ -62,10 +52,6 @@ export class KeyValueStore {
     if (file.exists) {
       return file.textSync();
     }
-    const oldFile = getOldDirFile(key);
-    if (oldFile?.exists) {
-      return oldFile.textSync();
-    }
     return undefined;
   }
 
@@ -89,17 +75,6 @@ export class KeyValueStore {
   }
 }
 
-function getOldDirFile(key: string): File | undefined {
-  // For iOS, the Library/Application Support directory (equivalent to .NET MAUI's FileSystem.AppDataDirectory)
-  // We want to only read from this, and store in the appropriate documents dir
-  if (Platform.OS === 'ios' || Platform.OS === 'macos') {
-    const libraryDir = getLibraryDirectory();
-    return new File(Paths.join(libraryDir, key));
-  } else {
-    return undefined;
-  }
-}
-
 function getFile(key: string): File {
   return new File(Paths.join(Paths.document, key));
 }