fix: Ensure deleted sessions persist as deleted

We hijacked the delete session effect that already existed, but it returned early if health connect was not enabled.
This change ensures that when a session is deleted, it always deletes it from the db.

fixes: #872

Author: LiamMorrow

app/src/store/stored-sessions/effects.ts

@@ -208,11 +208,18 @@ export function applyStoredSessionsEffects(addEffect: AddEffectFn) {
     },
   );
 
+  addEffect(deleteStoredSession, async (action, { extra: { logger, db } }) => {
+    await logger.time('deleteStoredSession', async () => {
+      await db
+        .delete(sessionsSchema)
+        .where(eq(sessionsSchema.id, action.payload));
+    });
+  });
   addEffect(
     deleteStoredSession,
     async (
       action,
-      { stateAfterReduce, extra: { healthExportService, logger, db } },
+      { stateAfterReduce, extra: { healthExportService, logger } },
     ) => {
       const workoutId = action.payload;
       if (
@@ -226,11 +233,6 @@ export function applyStoredSessionsEffects(addEffect: AddEffectFn) {
       } catch (e) {
         logger.error('Failed to delete workout from HealthConnect', e);
       }
-      await logger.time('deleteStoredSession', async () => {
-        await db
-          .delete(sessionsSchema)
-          .where(eq(sessionsSchema.id, action.payload));
-      });
     },
   );