Third test release 0.4.938

Fix some more format string warnings, and illegal compile-time
comparison warnings. -Wtautological-constant-out-of-range-compare

Author: rurban

ChangeLog

@@ -1,9 +1,40 @@
 Full history from the git log
 -----------------------------
 
+2018-06-30  Reini Urban  <[email protected]>
+
+       Third test release 0.4.938
+
+2018-06-29  Reini Urban  <[email protected]>
+
+       more format string types
+
+       enable glibc strcasestr
+       probed as yes, but not declared. same as on darwin.
+
+       ../../programs/dwggrep.c:213:7: warning: implicit declaration of function ‘strcasestr’ [-Wimplicit-function-declaration]
+              if (strcasestr(text, pattern))
+
+2018-06-29  Reini Urban  <[email protected]>
+
+       alldwg.inc: create from builddir
+       ./logs.sh can only be run from the builddir,
+       only there are the binaries.
+       call make from logs.sh, not gmake. we would really need a MAKE=$(MAKE)
+       but this is only done on regen-unknown by the maintainer.
+       make the alldwg.inc target a maintainer rule only. test -d ../.git || false
+
+2018-06-28  Reini Urban  <[email protected]>
+
+       eed: fix max limit from 1024 to obj->size
+       And on overlong stringsize just skip it to the end.
+
+       This fixes the error with hatch_color_ref.dwg from [GH #27]
+       and several LAYER entities with attached large EED data.
+
 2018-06-28  Reini Urban  <[email protected]>
 
-	Second test release 0.4.999
+	Second test release 0.4.924
 
 2018-06-28  Reini Urban  <[email protected]>
 

bindings/perl/Makefile.PL

@@ -26,7 +26,7 @@ $lddlflags .= " -lredwg";
 
 WriteMakefile (
   NAME         => 'LibreDWG',
-  VERSION      => '0.4_924',
+  VERSION      => '0.4_938',
   ($ccopts ? (CCFLAGS => $ccopts) : ()),
   ($ldopts ? (LDFLAGS => $ldopts) : ()),
   ($lddlflags ? (LDDLFLAGS => $lddlflags) : ()),

configure.ac

@@ -9,7 +9,7 @@ dnl You should have received a copy of the GNU General Public License
 dnl along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 AC_PREREQ([2.61])
-AC_INIT([LibreDWG],[0.4.924],[[email protected]],,
+AC_INIT([LibreDWG],[0.4.938],[[email protected]],,
         [https://savannah.gnu.org/projects/libredwg/])
 AC_CONFIG_AUX_DIR([build-aux])
 dnl for older systems use this:

doc/Doxyfile

@@ -6,7 +6,7 @@
 
 DOXYFILE_ENCODING      = UTF-8
 PROJECT_NAME           = "LibreDWG API"
-PROJECT_NUMBER         = 0.4.924
+PROJECT_NUMBER         = 0.4.938
 PROJECT_BRIEF          = "LibreDWG API - The DWG Library"
 PROJECT_LOGO           =
 OUTPUT_DIRECTORY       = doc/

src/common_entity_data.spec

@@ -67,7 +67,7 @@
       BITCODE_BS flags = bit_read_BS(dat);
       LOG_HANDLE("color flags: 0x%X [BS 0]\n", (unsigned)flags);
       ent->color.rgb = 0L;
-      ent->color.index = flags && 0xff; // or 0x1ff?
+      ent->color.index = flags & 0xff; // or 0x1ff?
       flags = flags >> 8;
       ent->color.flag = flags;
 

src/dec_macros.h

@@ -285,7 +285,7 @@
   }
 
 #define VECTOR_CHKCOUNT(name,size) \
-  if (dat->version >= R_2004 && size > 0x10000) { \
+  if (dat->version >= R_2004 && size > 0xff00) { \
     LOG_ERROR("Invalid " #name " vcount %ld", (long)size); \
     return DWG_ERR_VALUEOUTOFBOUNDS; } \
 
@@ -442,7 +442,7 @@
     LOG_HANDLE(" -> @%lu.%u (%lu)\n", dat->byte, dat->bit, bit_position(dat)); }
 
 #define REPEAT_CHKCOUNT(name,times) \
-  if (dat->version >= R_2004 && times > 0x1000) { \
+  if (dat->version >= R_2004 && times > 0xff00) { \
     LOG_ERROR("Invalid " #name " rcount %ld\n", (long)times); \
     return DWG_ERR_VALUEOUTOFBOUNDS; } \
 

src/decode.c

@@ -1476,7 +1476,7 @@ decompress_R2004_section(Bit_Chain *restrict dat, char *restrict decomp,
       if (comp_bytes > bytes_left) // bytes left to write
         {
           LOG_ERROR("Invalid comp_bytes %lu > %lu bytes left",
-                    (unsigned long)comp_bytes, bytes_left)
+                    (unsigned long)comp_bytes, (unsigned long)bytes_left)
           return DWG_ERR_VALUEOUTOFBOUNDS;
         }
       for (i = 0; i < comp_bytes; ++i)
@@ -1698,7 +1698,8 @@ read_R2004_section_info(Bit_Chain* dat, Dwg_Data *dwg,
 
               if (section_number > info->num_sections + info->sections[0]->number)
                 {
-                  LOG_TRACE("Strange Section Number: 0x%x\n", (unsigned long)section_number)
+                  LOG_TRACE("Strange Section Number: 0x%lx\n",
+                            (unsigned long)section_number)
                 }
               else
                 {

src/dwg.spec

@@ -3401,7 +3401,7 @@ DWG_ENTITY(HATCH)
   FIELD_BL (num_paths, 91);
   if (FIELD_VALUE(num_paths > 10000))
     {
-      LOG_ERROR("Invalid HATCH.num_paths %lu", _obj->num_paths);
+      LOG_ERROR("Invalid HATCH.num_paths " FORMAT_BL, _obj->num_paths);
       return DWG_ERR_VALUEOUTOFBOUNDS;
     }
   REPEAT(num_paths, paths, Dwg_HATCH_Path)
@@ -3412,7 +3412,7 @@ DWG_ENTITY(HATCH)
           FIELD_BL (paths[rcount1].num_segs_or_paths, 93);
           if (FIELD_VALUE(paths[rcount1].num_segs_or_paths > 10000))
             {
-              LOG_ERROR("Invalid HATCH.num_segs_or_paths %lu",
+              LOG_ERROR("Invalid HATCH.num_segs_or_paths " FORMAT_BL,
                         _obj->paths[rcount1].num_segs_or_paths);
               return DWG_ERR_VALUEOUTOFBOUNDS;
             }