Skip to content

[BUG] llvm target build ignores C_FLAGS AND CXX_FLAGS #5486

Open
@heitbaum

Description

@heitbaum

llvm cmake target options are being ignored.

Reference - https://gitlab.kitware.com/cmake/cmake/-/blob/master/Help/release/3.20.rst#L297-299

the following code is silently ignored in cmake < 3.20

-DCMAKE_C_FLAGS="${CFLAGS}" \
-DCMAKE_CXX_FLAGS="${CXXFLAGS}" \

it causes a fatal error in cmake 3.20 >=

what is the correct solution for the llvm/package.mk file? Removing the 2 lines would match existing behaviour - but assume that was not the intent.

can be tested with cmake 3.20.4

diff --git a/packages/devel/cmake/package.mk b/packages/devel/cmake/package.mk
index d0986997f9..3767ba40f2 100644
--- a/packages/devel/cmake/package.mk
+++ b/packages/devel/cmake/package.mk
@@ -3,8 +3,8 @@
 # Copyright (C) 2016-present Team LibreELEC (https://libreelec.tv)
 
 PKG_NAME="cmake"
-PKG_VERSION="3.19.2"
-PKG_SHA256="e3e0fd3b23b7fb13e1a856581078e0776ffa2df4e9d3164039c36d3315e0c7f0"
+PKG_VERSION="3.20.4"
+PKG_SHA256="87a4060298f2c6bb09d479de1400bc78195a5b55a65622a7dceeb3d1090a1b16"
 PKG_LICENSE="BSD"
 PKG_SITE="https://cmake.org/"
 PKG_URL="https://cmake.org/files/v$(get_pkg_version_maj_min)/cmake-${PKG_VERSION}.tar.gz"

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions