test(dream-cli): BATS coverage for compose wrapper + set -u/pipefail guards

test-compose-summary-wrapper.bats pins _compose_run_with_summary
success/error paths + zero-grep-match fallback + exit-code
propagation (#406).

test-dream-cli-flags.bats pins dream-cli shell-flag hygiene: set
-euo pipefail at line 6, nounset safety under minimal env, static
assertions on conditional-var syntax (#410).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: yasinBursali

dream-server/tests/bats-tests/test-compose-summary-wrapper.bats

@@ -0,0 +1,219 @@
+#!/usr/bin/env bats
+# ============================================================================
+# BATS tests for _compose_run_with_summary in dream-cli.
+# ============================================================================
+# Guards against re-breakage of PR #406 (compose wrapper surfaces a compact
+# summary on success, an error banner + grep'd keywords + log path on
+# failure, and propagates the compose exit code so `dream restart/stop/start`
+# aborts under `set -e`).
+#
+# Test strategy:
+#   - Extract _compose_run_with_summary + its helper (log/success/warn/
+#     log_error) text from dream-cli.
+#   - PATH-inject a `docker` stub that can be told to exit 0 / exit 1 with
+#     error-keyword output / exit 1 with no-keyword output.
+#   - Run the wrapper and assert on printed output + return code.
+
+load '../bats/bats-support/load'
+load '../bats/bats-assert/load'
+
+setup() {
+    export TMPDIR_TEST="$BATS_TEST_TMPDIR"
+    mkdir -p "$TMPDIR_TEST/bin"
+
+    # Color vars used by log/success/warn/log_error — stub to empty so
+    # assert_output matches plain strings without escape sequences.
+    export RED="" GREEN="" YELLOW="" BLUE="" CYAN="" NC=""
+
+    # Minimal logger helpers that match dream-cli's line 45–50 definitions.
+    # We redefine rather than extract because (a) they're trivial and (b)
+    # dream-cli's real definitions pull in color vars we've already stubbed.
+    log()       { echo "[dream] $1"; }
+    success()   { echo "✓ $1"; }
+    warn()      { echo "⚠ $1"; }
+    log_error() { echo "✗ $1" >&2; }
+    export -f log success warn log_error
+
+    # Extract _compose_run_with_summary from dream-cli.
+    local _cli="$BATS_TEST_DIRNAME/../../dream-cli"
+    eval "$(awk '/^_compose_run_with_summary\(\) \{/,/^\}$/' "$_cli")"
+
+    # docker stub — behavior driven by DOCKER_STUB_MODE env var:
+    #   success     → exit 0 with benign stdout
+    #   fail-keyword→ exit 1, stdout contains 'error', 'failed', 'unhealthy', 'dependency'
+    #   fail-nomatch→ exit 1, stdout has no error keywords
+    cat > "$TMPDIR_TEST/bin/docker" <<'STUB'
+#!/usr/bin/env bash
+echo "DOCKER_ARGS: $*" >> "$DOCKER_CALL_LOG"
+case "${DOCKER_STUB_MODE:-success}" in
+    success)
+        echo "Network dream-net created"
+        echo "Container dream-foo started"
+        exit 0
+        ;;
+    fail-keyword)
+        echo "Container dream-foo starting"
+        echo "Error response from daemon: service dream-foo failed to start"
+        echo "unhealthy container dream-bar"
+        echo "dependency dream-baz not ready"
+        exit 1
+        ;;
+    fail-nomatch)
+        echo "Container dream-foo starting"
+        echo "network busy (try again later)"
+        exit 1
+        ;;
+    *)
+        echo "unknown DOCKER_STUB_MODE: $DOCKER_STUB_MODE" >&2
+        exit 127
+        ;;
+esac
+STUB
+    chmod +x "$TMPDIR_TEST/bin/docker"
+    export PATH="$TMPDIR_TEST/bin:$PATH"
+    export DOCKER_CALL_LOG="$TMPDIR_TEST/docker.log"
+    : > "$DOCKER_CALL_LOG"
+}
+
+teardown() {
+    rm -rf "$TMPDIR_TEST/bin" "$TMPDIR_TEST/docker.log"
+}
+
+# ── success path ────────────────────────────────────────────────────────────
+
+@test "wrapper: success prints compact '<verb> — done' banner and returns 0" {
+    export DOCKER_STUB_MODE=success
+    run _compose_run_with_summary "Restarting all services" up -d
+    assert_success
+    assert_output --partial "Restarting all services..."
+    assert_output --partial "Restarting all services — done"
+}
+
+@test "wrapper: success removes the compose log tmpfile" {
+    export DOCKER_STUB_MODE=success
+    # Track how many mktemp-produced files exist before & after. We rely on
+    # $TMPDIR being the system tmp — the wrapper uses `mktemp` with no args.
+    local before=$(find /tmp -maxdepth 1 -name 'tmp.*' -type f 2>/dev/null | wc -l)
+    run _compose_run_with_summary "Starting all services" up -d
+    assert_success
+    local after=$(find /tmp -maxdepth 1 -name 'tmp.*' -type f 2>/dev/null | wc -l)
+    # Zero net new temp files (create + rm).
+    [ "$after" -le "$before" ]
+}
+
+@test "wrapper: success does NOT print error banner or log path" {
+    export DOCKER_STUB_MODE=success
+    run _compose_run_with_summary "Starting all services" up -d
+    assert_success
+    refute_output --partial "Full compose output:"
+    refute_output --partial "failed:"
+}
+
+# ── failure path, matching keywords (PR #406) ───────────────────────────────
+
+@test "wrapper: failure prints error banner, matched lines, and log path" {
+    export DOCKER_STUB_MODE=fail-keyword
+    run _compose_run_with_summary "Restarting service x" up -d x
+    assert_failure
+    assert_output --partial "Restarting service x failed:"
+    # At least one error-keyword line should be surfaced (indented two spaces).
+    assert_output --partial "Error response from daemon"
+    assert_output --partial "Full compose output:"
+}
+
+@test "wrapper: failure propagates the compose exit code (1)" {
+    export DOCKER_STUB_MODE=fail-keyword
+    run _compose_run_with_summary "Restarting" up -d
+    # docker stub exits 1; wrapper must return 1.
+    [ "$status" -eq 1 ]
+}
+
+@test "wrapper: failure preserves the compose log file (not auto-removed)" {
+    export DOCKER_STUB_MODE=fail-keyword
+    run _compose_run_with_summary "Restarting" up -d
+    assert_failure
+    # Extract the "Full compose output: /tmp/tmp.XXXXXX" path from output.
+    local log_line
+    log_line=$(printf '%s\n' "$output" | grep -E 'Full compose output:' | head -1)
+    [ -n "$log_line" ]
+    local log_path="${log_line##*: }"
+    [ -f "$log_path" ]
+    rm -f "$log_path"
+}
+
+# ── failure path, zero keyword matches (nounset/pipefail-hardening) ─────────
+
+# These two tests must execute the wrapper under `set -euo pipefail` because
+# the `|| warn "(no error keywords matched...)"` branch only fires when
+# grep's exit-1 propagates through the pipeline — and only pipefail makes
+# grep the pipeline's final exit code. dream-cli line 6 IS `set -euo pipefail`
+# in production; bats' setup() doesn't inherit that, so we set it explicitly
+# via the subshell.
+
+@test "wrapper: failure with no keyword match fires the warn fallback (under pipefail)" {
+    export DOCKER_STUB_MODE=fail-nomatch
+    # Re-extract the wrapper inside a pipefail-enabled subshell.
+    run bash -c '
+        set -euo pipefail
+        RED="" GREEN="" YELLOW="" BLUE="" CYAN="" NC=""
+        log()       { echo "[dream] $1"; }
+        success()   { echo "✓ $1"; }
+        warn()      { echo "⚠ $1"; }
+        log_error() { echo "✗ $1" >&2; }
+        eval "$(awk "/^_compose_run_with_summary\(\) \{/,/^\}$/" "'"$BATS_TEST_DIRNAME/../../dream-cli"'")"
+        _compose_run_with_summary "Stopping service y" down y
+    '
+    assert_failure
+    assert_output --partial "Stopping service y failed:"
+    assert_output --partial "(no error keywords matched in compose log)"
+    assert_output --partial "Full compose output:"
+}
+
+@test "wrapper: failure with no keyword match still propagates exit code" {
+    export DOCKER_STUB_MODE=fail-nomatch
+    run bash -c '
+        set -euo pipefail
+        RED="" GREEN="" YELLOW="" BLUE="" CYAN="" NC=""
+        log()       { echo "[dream] $1"; }
+        success()   { echo "✓ $1"; }
+        warn()      { echo "⚠ $1"; }
+        log_error() { echo "✗ $1" >&2; }
+        eval "$(awk "/^_compose_run_with_summary\(\) \{/,/^\}$/" "'"$BATS_TEST_DIRNAME/../../dream-cli"'")"
+        _compose_run_with_summary "Stopping" down
+    '
+    [ "$status" -eq 1 ]
+}
+
+# ── docker compose args passthrough ─────────────────────────────────────────
+
+@test "wrapper: all args after verb are passed to docker compose" {
+    export DOCKER_STUB_MODE=success
+    run _compose_run_with_summary "Up" -f extra.yml up -d my-service
+    assert_success
+    # Stub records its argv to DOCKER_CALL_LOG; first arg must be `compose`
+    # because the wrapper calls `docker compose <args>`.
+    run cat "$DOCKER_CALL_LOG"
+    assert_output --partial "DOCKER_ARGS: compose --progress quiet -f extra.yml up -d my-service"
+}
+
+# ── propagation into callers (cmd_restart/cmd_stop/cmd_start) ───────────────
+
+@test "wrapper: caller returns wrapper's non-zero exit (smoke)" {
+    export DOCKER_STUB_MODE=fail-keyword
+    # Simulate `cmd_restart`: wrapper is the last statement, so its exit
+    # code becomes the function's exit code.
+    _simulated_caller() {
+        _compose_run_with_summary "Restarting all services" up -d
+    }
+    run _simulated_caller
+    [ "$status" -eq 1 ]
+}
+
+@test "wrapper: caller returns 0 on success (smoke)" {
+    export DOCKER_STUB_MODE=success
+    _simulated_caller() {
+        _compose_run_with_summary "Restarting all services" up -d
+    }
+    run _simulated_caller
+    [ "$status" -eq 0 ]
+}

dream-server/tests/bats-tests/test-dream-cli-flags.bats

@@ -0,0 +1,96 @@
+#!/usr/bin/env bats
+# ============================================================================
+# BATS tests for dream-cli's shell-flag hygiene.
+# ============================================================================
+# Guards against re-breakage of:
+#   - PR #410 / nounset audit:     line 6 must be `set -euo pipefail`
+#   - Pipefail SIGPIPE audit:      `sed -n '1p'` must be used (not `head -1`)
+#   - Nounset audit:               minimal-env invocations must not crash
+#                                  on undefined variables
+#
+# These are static-assertion tests (grep, sed) plus one subprocess invocation
+# under `env -i` to catch any bare `${FOO}` that sneaks back in.
+
+load '../bats/bats-support/load'
+load '../bats/bats-assert/load'
+
+setup() {
+    export CLI="$BATS_TEST_DIRNAME/../../dream-cli"
+}
+
+# ── line 6 shell-mode assertion (PR #410) ───────────────────────────────────
+
+@test "flags: line 6 is exactly 'set -euo pipefail'" {
+    run sed -n '6p' "$CLI"
+    assert_success
+    assert_output "set -euo pipefail"
+}
+
+@test "flags: no weaker shell-mode line exists anywhere in dream-cli" {
+    # If someone accidentally re-introduces `set -eo pipefail` (dropping
+    # nounset) or bare `set -e`, this catches it.
+    run grep -nE '^set -e[^u]' "$CLI"
+    # grep returning 1 means no match — that's what we want.
+    assert_failure
+}
+
+# ── sed -n '1p' replacement for `head -1` (pipefail SIGPIPE audit) ──────────
+
+@test "flags: no bare '| head -1' pipelines in dream-cli" {
+    # `| head -1` under `set -o pipefail` can SIGPIPE the upstream command
+    # and abort. Project-blessed replacement is `| sed -n '1p'`.
+    run grep -nE '\| head -1([^0-9]|$)' "$CLI"
+    assert_failure
+}
+
+@test "flags: sed -n '1p' idiom is present where bootstrap + preset code path needs it" {
+    # Just assert the idiom is used — the exact count can drift with
+    # refactors, but it must be >0 to prove the replacement happened.
+    run grep -cE "sed -n '1p'" "$CLI"
+    assert_success
+    [ "$output" -gt 0 ]
+}
+
+# ── nounset syntax: conditional var references use ${FOO:-default} ──────────
+
+@test "flags: conditional var references follow \${FOO:-default} form" {
+    # The nounset audit (PR #11) converted many bare `${VAR}` refs that
+    # fire only on optional/env-dependent paths to `${VAR:-}` / `${VAR:-default}`.
+    # Assert that the characteristic pattern is widely present; >20 occurrences
+    # confirm the audit changes are still in place.
+    run grep -cE '\$\{[A-Za-z_][A-Za-z_0-9]*:-' "$CLI"
+    assert_success
+    [ "$output" -gt 20 ]
+}
+
+# ── end-to-end: dream-cli doesn't crash on nounset with minimal env ─────────
+
+@test "flags: --version runs under minimal env without unbound-var crash" {
+    # Strip the environment down to the bare minimum. If dream-cli references
+    # any var without `:-` on the --version / --help code path, `set -u`
+    # aborts here and this test fails.
+    run env -i \
+        HOME="/tmp" \
+        PATH="/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/Volumes/X/homebrew/bin" \
+        TERM="dumb" \
+        bash "$CLI" --version
+    # --version exits 0 or reports a help summary; either way it must not
+    # crash with "unbound variable".
+    refute_output --partial "unbound variable"
+}
+
+@test "flags: help runs under minimal env without unbound-var crash" {
+    run env -i \
+        HOME="/tmp" \
+        PATH="/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/Volumes/X/homebrew/bin" \
+        TERM="dumb" \
+        bash "$CLI" help
+    refute_output --partial "unbound variable"
+}
+
+# ── script parses under bash -n ─────────────────────────────────────────────
+
+@test "flags: dream-cli passes bash -n (syntax check)" {
+    run bash -n "$CLI"
+    assert_success
+}