Merge pull request #952 from boffin-dmytro/fix/installer-silent-error-masks

fix(installer): replace silent || true masks with warnings in phase scripts

Author: Lightheartdevs

dream-server/installers/phases/06-directories.sh

@@ -94,12 +94,16 @@ Fix with: sudo chown -R \$(id -u):\$(id -g) $INSTALL_DIR/config $INSTALL_DIR/dat
                 "$SCRIPT_DIR/" "$INSTALL_DIR/"
         else
             # Fallback: cp -r everything, then remove runtime artifacts
-            cp -r "$SCRIPT_DIR"/* "$INSTALL_DIR/" 2>/dev/null || true
-            cp "$SCRIPT_DIR"/.gitignore "$INSTALL_DIR/" 2>/dev/null || true
-            rm -rf "$INSTALL_DIR/.git" 2>/dev/null || true
+            if ! cp -r "$SCRIPT_DIR"/* "$INSTALL_DIR/" 2>>"$LOG_FILE"; then
+                warn "Source copy incomplete — some files may be missing"
+            fi
+            if ! cp "$SCRIPT_DIR"/.gitignore "$INSTALL_DIR/" 2>>"$LOG_FILE"; then
+                warn "Failed to copy .gitignore"
+            fi
+            rm -rf "$INSTALL_DIR/.git" 2>>"$LOG_FILE" || true
         fi
         # Ensure scripts are executable
-        chmod +x "$INSTALL_DIR"/*.sh "$INSTALL_DIR"/scripts/*.sh "$INSTALL_DIR"/dream-cli 2>/dev/null || true
+        chmod +x "$INSTALL_DIR"/*.sh "$INSTALL_DIR"/scripts/*.sh "$INSTALL_DIR"/dream-cli 2>>"$LOG_FILE" || warn "Some scripts may not be executable — verify after install"
         ai_ok "Source files installed"
     else
         log "Running in-place (source == install dir), skipping file copy"
@@ -124,7 +128,9 @@ Fix with: sudo chown -R \$(id -u):\$(id -g) $INSTALL_DIR/config $INSTALL_DIR/dat
             cp "$SCRIPT_DIR/config/openclaw/$OPENCLAW_CONFIG" "$INSTALL_DIR/config/openclaw/openclaw.json"
         else
             warn "OpenClaw config $OPENCLAW_CONFIG not found, using default"
-            cp "$SCRIPT_DIR/config/openclaw/openclaw.json.example" "$INSTALL_DIR/config/openclaw/openclaw.json" 2>/dev/null || true
+            if ! cp "$SCRIPT_DIR/config/openclaw/openclaw.json.example" "$INSTALL_DIR/config/openclaw/openclaw.json" 2>>"$LOG_FILE"; then
+                warn "Failed to copy OpenClaw default config — you may need to create it manually"
+            fi
         fi
         # Resolve provider name/URL before any sed replacements that depend on them
         OPENCLAW_PROVIDER_NAME="${OPENCLAW_PROVIDER_NAME_DEFAULT}"

dream-server/installers/phases/11-services.sh

@@ -256,10 +256,21 @@ MODELS_INI_EOF
         if [[ "$_BOOTSTRAP_ACTIVE" == "true" ]]; then
             _env_file="$INSTALL_DIR/.env"
             if [[ -f "$_env_file" ]]; then
-                awk -v v="$GGUF_FILE" '{ if (index($0, "GGUF_FILE=") == 1) print "GGUF_FILE=" v; else print }'                     "$_env_file" > "${_env_file}.tmp" && cat "${_env_file}.tmp" > "$_env_file" && rm -f "${_env_file}.tmp"
-                awk -v v="$LLM_MODEL" '{ if (index($0, "LLM_MODEL=") == 1) print "LLM_MODEL=" v; else print }'                     "$_env_file" > "${_env_file}.tmp" && cat "${_env_file}.tmp" > "$_env_file" && rm -f "${_env_file}.tmp"
-                awk -v v="$MAX_CONTEXT" '{ if (index($0, "MAX_CONTEXT=") == 1) print "MAX_CONTEXT=" v; else print }'                     "$_env_file" > "${_env_file}.tmp" && cat "${_env_file}.tmp" > "$_env_file" && rm -f "${_env_file}.tmp"
-                ai_ok "Patched .env for bootstrap model ($GGUF_FILE)"
+                _env_patch_ok=true
+                for _key_val in "GGUF_FILE=$GGUF_FILE" "LLM_MODEL=$LLM_MODEL" "MAX_CONTEXT=$MAX_CONTEXT"; do
+                    _key="${_key_val%%=*}"
+                    _val="${_key_val#*=}"
+                    if ! awk -v v="$_val" '{ if (index($0, "'"$_key"'=") == 1) print "'"$_key"'=" v; else print }' \
+                        "$_env_file" > "${_env_file}.tmp" 2>>"$LOG_FILE" \
+                        && cat "${_env_file}.tmp" > "$_env_file" 2>>"$LOG_FILE" \
+                        && rm -f "${_env_file}.tmp"; then
+                        _env_patch_ok=false
+                        warn "Failed to patch $_key in .env"
+                    fi
+                done
+                if [[ "$_env_patch_ok" == "true" ]]; then
+                    ai_ok "Patched .env for bootstrap model ($GGUF_FILE)"
+                fi
             fi
         fi
     fi