Commit 787083b
chore(bash32): guard declare -A callers + route dream-cli validate through $BASH
Five scripts used declare -A (bash 4+ associative arrays) without the
safety net already present in dream-cli and lib/service-registry.sh:
- scripts/pre-download.sh (user-invoked per FAQ.md)
- scripts/dream-test-functional.sh (dev/test tool)
- scripts/validate-env.sh (invoked by dream config validate)
- lib/progress.sh (sourced by install-core.sh)
- installers/phases/03-features.sh (sourced by install-core.sh)
On macOS the system /bin/bash is 3.2.57 and declare -A fails with a
cryptic "invalid option" error. Pattern A guards (standalone scripts)
use bare exit 1; Pattern B guards (sourced libs) use
"return 1 2>/dev/null || exit 1", matching the accepted patterns in
dream-cli:8-14 and lib/service-registry.sh:18-24.
Also makes dream config validate functional on macOS by invoking the
sibling subprocesses through "$BASH", so the modern bash that dream-cli
is running under is inherited by validate-env.sh and validate-manifests.sh
rather than being re-resolved through their #!/bin/bash shebang.
Removes a dead "2>/dev/null || true" fallback on declare -A SERVICE_PORTS
in dream-test-functional.sh; surrounding set -e + the service-registry
guard already abort the script before that line under bash 3.2.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent d5154c3 commit 787083b
6 files changed
Lines changed: 43 additions & 3 deletions
File tree
- dream-server
- installers/phases
- lib
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1114 | 1114 | | |
1115 | 1115 | | |
1116 | 1116 | | |
1117 | | - | |
| 1117 | + | |
1118 | 1118 | | |
1119 | 1119 | | |
1120 | 1120 | | |
1121 | 1121 | | |
1122 | 1122 | | |
1123 | 1123 | | |
1124 | 1124 | | |
1125 | | - | |
| 1125 | + | |
1126 | 1126 | | |
1127 | 1127 | | |
1128 | 1128 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
23 | 31 | | |
24 | 32 | | |
25 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
5 | 13 | | |
6 | 14 | | |
7 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
14 | 22 | | |
15 | 23 | | |
16 | 24 | | |
| |||
31 | 39 | | |
32 | 40 | | |
33 | 41 | | |
34 | | - | |
| 42 | + | |
35 | 43 | | |
36 | 44 | | |
37 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
20 | 28 | | |
21 | 29 | | |
22 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
10 | 18 | | |
11 | 19 | | |
12 | 20 | | |
| |||
0 commit comments