Skip to content

Commit d1b0039

Browse files
Merge pull request #145 from yasinBursali/fix/dashboard-api-socket-fd-leak
fix(dashboard-api): close socket with context manager to prevent FD leak
2 parents 208749f + 0c5317a commit d1b0039

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

  • dream-server/extensions/services/dashboard-api

dream-server/extensions/services/dashboard-api/main.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,11 +166,10 @@ async def preflight_ports(request: PortCheckRequest):
166166

167167
conflicts = []
168168
for port in request.ports:
169-
sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
170-
sock.settimeout(1)
171169
try:
172-
sock.bind(("0.0.0.0", port))
173-
sock.close()
170+
with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as sock:
171+
sock.settimeout(1)
172+
sock.bind(("0.0.0.0", port))
174173
except socket.error:
175174
conflicts.append({"port": port, "service": port_services.get(port, "Unknown"), "in_use": True})
176175
return {"conflicts": conflicts, "available": len(conflicts) == 0}

0 commit comments

Comments
 (0)